Multi-Object-Mode: Edit Curve Tools #54648

New Issue

Campbell Barton · 2018-04-16T12:58:16+02:00

Campbell Barton commented

2018-04-16 12:58:16 +02:00

~~CURVE_OT_select_all~~ 170dd30881
~~CURVE_OT_select_random~~ 4e14437cb0
~~CURVE_OT_select_nth~~ 47afabbb42
~~CURVE_OT_select_linked~~ 647232f7f1
~~CURVE_OT_select_similar~~ 4e9911663a
~~CURVE_OT_de_select_first~~ 9d9d44dbcb
~~CURVE_OT_de_select_last~~ df613a52e6
~~CURVE_OT_select_next~~ 95150b8414
~~CURVE_OT_select_previous~~ 95150b8414
~~CURVE_OT_select_more~~ 45aa812fb3
~~CURVE_OT_select_less~~ 45aa812fb3

~~CURVE_OT_dissolve_verts~~ d7c6013d01
~~CURVE_OT_delete~~ 0973ea5132
~~CURVE_OT_spin~~258ad21cf2
~~CURVE_OT_extrude_move~~ 993f4d4827
~~CURVE_OT_duplicate_move~~ b9d5888728
~~CURVE_OT_split~~ e9980e5a75
~~CURVE_OT_separate~~ 4135c7786e
~~CURVE_OT_make_segment~~ 3335618489
~~CURVE_OT_cyclic_toggle~~ 93b99306d8
~~CURVE_OT_normals_make_consistent~~ 500ebf7348
~~CURVE_OT_handle_type_set~~ 3d4fd6ce1e
~~CURVE_OT_tilt_clear~~ 14344de261
~~CURVE_OT_switch_direction~~ 3e55b3c6d0
~~CURVE_OT_subdivide~~ 17aef80207
~~CURVE_OT_decimate~~ bafd1b6d92
~~CURVE_OT_hide~~ 597d0ce93c
~~CURVE_OT_reveal~~ b5a18c1aac

Other:

~~CURVE_OT_draw (Doesn't de-select all other selected objects, need to refactor ED_curve_select_all & ED_curve_deselect_all, see: ED_pose_deselect_all_multi)~~ 2959e4c72c

## Select Menu: - ~~CURVE_OT_select_all~~ 170dd30881 - ~~CURVE_OT_select_random~~ 4e14437cb0 - ~~CURVE_OT_select_nth~~ 47afabbb42 - ~~CURVE_OT_select_linked~~ 647232f7f1 - ~~CURVE_OT_select_similar~~ 4e9911663a - ~~CURVE_OT_de_select_first~~ 9d9d44dbcb - ~~CURVE_OT_de_select_last~~ df613a52e6 - ~~CURVE_OT_select_next~~ 95150b8414 - ~~CURVE_OT_select_previous~~ 95150b8414 - ~~CURVE_OT_select_more~~ 45aa812fb3 - ~~CURVE_OT_select_less~~ 45aa812fb3 ## Curve Menu: - ~~CURVE_OT_dissolve_verts~~ d7c6013d01 - ~~CURVE_OT_delete~~ 0973ea5132 - ~~CURVE_OT_spin~~258ad21cf2 - ~~CURVE_OT_extrude_move~~ 993f4d4827 - ~~CURVE_OT_duplicate_move~~ b9d5888728 - ~~CURVE_OT_split~~ e9980e5a75 - ~~CURVE_OT_separate~~ 4135c7786e - ~~CURVE_OT_make_segment~~ 3335618489 - ~~CURVE_OT_cyclic_toggle~~ 93b99306d8 - ~~CURVE_OT_normals_make_consistent~~ 500ebf7348 - ~~CURVE_OT_handle_type_set~~ 3d4fd6ce1e - ~~CURVE_OT_tilt_clear~~ 14344de261 - ~~CURVE_OT_switch_direction~~ 3e55b3c6d0 - ~~CURVE_OT_subdivide~~ 17aef80207 - ~~CURVE_OT_decimate~~ bafd1b6d92 - ~~CURVE_OT_hide~~ 597d0ce93c - ~~CURVE_OT_reveal~~ b5a18c1aac ## Other: - ~~`CURVE_OT_draw` (Doesn't de-select all other selected objects, need to refactor `ED_curve_select_all` & `ED_curve_deselect_all`, see: `ED_pose_deselect_all_multi`)~~ 2959e4c72c

Campbell Barton self-assigned this 2018-04-16 12:58:16 +02:00

Campbell Barton commented

2018-04-16 12:58:16 +02:00

Added subscriber: @ideasman42

Guy Boicey commented

2018-05-09 03:15:43 +02:00

Added subscriber: @stealthtech

Guy Boicey commented

2018-05-09 03:15:43 +02:00

When in edit mode I'm not able to select multiple control points. I have to do the following as a work around.

In Object Mode select a Bezier Curve
Switch to Edit Mode and select the Control Points
Switch back to Object Mode and select another Bezier Curve
Switch to Edit Model and select the Control Points
Switch back to Object Mode and Select both Bezier Curves
Switch back to Edit Mode and perform the operators.

The expected behavior

Select the Bezier Curves
Switch to Edit Mode

Select Control Points from any Bezier Curve selected

When in edit mode I'm not able to select multiple control points. I have to do the following as a work around. - In Object Mode select a Bezier Curve - Switch to Edit Mode and select the Control Points - Switch back to Object Mode and select another Bezier Curve - Switch to Edit Model and select the Control Points - Switch back to Object Mode and Select both Bezier Curves - Switch back to Edit Mode and perform the operators. The expected behavior - Select the Bezier Curves - Switch to Edit Mode # Select Control Points from any Bezier Curve selected

Guy Boicey commented

2018-05-09 03:21:06 +02:00

Default colors make it hard to distinguish between selected and none selected Control Points

Default

Versus one with more contrast

Default colors make it hard to distinguish between selected and none selected Control Points Default ![DefaultColors.PNG](https://archive.blender.org/developer/F3308477/DefaultColors.PNG) Versus one with more contrast ![ChangedColor.PNG](https://archive.blender.org/developer/F3308482/ChangedColor.PNG)

Dalai Felinto commented

2018-05-11 12:51:25 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2018-05-11 12:51:25 +02:00

@stealthtech

The patches overall are fine, but we need to skip the for loop when there is no selected elements. There is no equivalent of totvertsel/edge/face in curves. You need to add this (as its own patch), so we can proceed with the other patches? It should be straight forward.

@stealthtech The patches overall are fine, but we need to skip the for loop when there is no selected elements. There is no equivalent of `totvertsel`/edge/face in curves. You need to add this (as its own patch), so we can proceed with the other patches? It should be straight forward.

Guy Boicey commented

2018-05-11 21:05:18 +02:00

@dfelinto

It should be straight forward but it is not, which is because I'm a noob at this.

First question what would justify that this would need to be a separate patch? Would I update my existing patches? How do I do this? I'm lost on this one. I was working on some other pieces of code and lost my updates and I don't want that to happen again. On a side note, the YouTube video which lead me here was awesome, great job. If there was one that covered end to end on how to actually do these patches, with git and diffing and branching would be great. The documentation is good otherwise I would not have gotten this far, but a video like a picture says thousands more words than words themselves. Teaching by example is great and your video did some of that, just some parts where left out. This could also be part of this as well how to make an update to a patch after being submitted.

Before I dive into making all sorts of code changes I want to share my thoughts and my direction. I see that most functions do something similar to this:

ListBase *editnurb = object_editcurve_get(obedit);
Nurb *nu;
for (nu = editnurb->first; nu; nu = nu->next)

My thoughts are that this could be the basis for the test. Now what would that test would be I don't know? Is it testing if editnurb is NULL? Is it to test if editnurb->first exist? Or do we go deeper than this and add something similar to tot...sel?

How do you test if two vertices are selected for such functions as subdivide?

And my last question, which I think I know the answer which is performance. Why was there no test before Multi-Object-Mode and why does there need to be one now? I'm guessing performance, you don't want to do a loop on N objects if you don't have to where as before Multi-Object-Mode there was only one.

@dfelinto It should be straight forward but it is not, which is because I'm a noob at this. First question what would justify that this would need to be a separate patch? Would I update my existing patches? How do I do this? I'm lost on this one. I was working on some other pieces of code and lost my updates and I don't want that to happen again. On a side note, the YouTube video which lead me here was awesome, great job. If there was one that covered end to end on how to actually do these patches, with git and diffing and branching would be great. The documentation is good otherwise I would not have gotten this far, but a video like a picture says thousands more words than words themselves. Teaching by example is great and your video did some of that, just some parts where left out. This could also be part of this as well how to make an update to a patch after being submitted. Before I dive into making all sorts of code changes I want to share my thoughts and my direction. I see that most functions do something similar to this: ``` ListBase *editnurb = object_editcurve_get(obedit); Nurb *nu; for (nu = editnurb->first; nu; nu = nu->next) ``` My thoughts are that this could be the basis for the test. Now what would that test would be I don't know? Is it testing if `editnurb` is `NULL`? Is it to test if `editnurb->first` exist? Or do we go deeper than this and add something similar to `tot...sel`? How do you test if two vertices are selected for such functions as subdivide? And my last question, which I think I know the answer which is performance. Why was there no test before Multi-Object-Mode and why does there need to be one now? I'm guessing performance, you don't want to do a loop on N objects if you don't have to where as before Multi-Object-Mode there was only one.

Guy Boicey commented

2018-05-11 21:44:56 +02:00

I think I might have found something would this work? I applied it to a few operations with some test output and looks to skip curves that have no selected control points.

if(!ED_curve_nurb_select_check((Curve *)obedit->data, object_editcurve_get(obedit)->first)) {
    continue;
}

In some function you can use declared varialbes for example in the curve_dissolve_exec

for (uint ob_index = 0; ob_index < objects_len; ob_index++)
{
    Object *obedit = objects[ob_index];
    Curve *cu = (Curve *)obedit->data;
    ListBase *editnurb = object_editcurve_get(obedit);
    if(!ED_curve_nurb_select_check(cu, editnurb->first)) {
        continue;
    }

    .
    .
    .

And for operations that require more than one I could use ED_curve_nurb_select_count?

For example subdivided_exec

if(!ED_curve_nurb_select_count((Curve *)obedit->data, object_editcurve_get(obedit)->first) < 2) {
    continue;
}

I think I might have found something would this work? I applied it to a few operations with some test output and looks to skip curves that have no selected control points. ``` if(!ED_curve_nurb_select_check((Curve *)obedit->data, object_editcurve_get(obedit)->first)) { continue; } ``` In some function you can use declared varialbes for example in the `curve_dissolve_exec` ``` for (uint ob_index = 0; ob_index < objects_len; ob_index++) { Object *obedit = objects[ob_index]; Curve *cu = (Curve *)obedit->data; ListBase *editnurb = object_editcurve_get(obedit); if(!ED_curve_nurb_select_check(cu, editnurb->first)) { continue; } . . . ``` And for operations that require more than one I could use `ED_curve_nurb_select_count`? For example `subdivided_exec` ``` if(!ED_curve_nurb_select_count((Curve *)obedit->data, object_editcurve_get(obedit)->first) < 2) { continue; } ```

Nick Milios commented

2018-05-11 23:09:28 +02:00

Added subscriber: @semaphore

Nick Milios commented

2018-05-11 23:09:28 +02:00

Same here in MetaBall
https://developer.blender.org/T54649

i am waiting @dfelinto to clarify what he means..
because i am thinking we need to implement somthing like tot...sel....

Same here in MetaBall https://developer.blender.org/T54649 i am waiting @dfelinto to clarify what he means.. because i am thinking we need to implement somthing like tot...sel....

Dalai Felinto commented

2018-05-13 13:28:08 +02:00

To use ED_curve_nurb_select_check and ED_curve_nurb_select_count don't you need to cycle through the Nurbs to know if any of it is selected?
e.g.: for (i = 0, nu = editnurb->first; nu; i++, nu = nu->next) ?

This is where an util like what @ideasman42 did for metaballs can be handy.

First question what would justify that this would need to be a separate patch?

We try to have git commits as atomic as possible. That said it is ok if it is part of one of the patches, but afterwards you still need to update the remaining patches to use it.

To use `ED_curve_nurb_select_check` and `ED_curve_nurb_select_count` don't you need to cycle through the Nurbs to know if any of it is selected? e.g.: `for (i = 0, nu = editnurb->first; nu; i++, nu = nu->next)` ? This is where an util like what @ideasman42 did for metaballs can be handy. > First question what would justify that this would need to be a separate patch? We try to have git commits as atomic as possible. That said it is ok if it is part of one of the patches, but afterwards you still need to update the remaining patches to use it.

Daniel Griffin commented

2018-05-17 06:17:06 +02:00

Added subscriber: @DGriffin

Daniel Griffin commented

2018-05-17 06:17:06 +02:00

This comment was removed by @DGriffin

*This comment was removed by @DGriffin*

Daniel Griffin commented

2018-05-17 08:15:01 +02:00

@dfelinto is there a way to get the count in the style that @ideasman42 did with the metaballs without cycling through the Nurbs? (Checking the f1 at each point)

Guy Boicey commented

2018-05-20 06:19:46 +02:00

@dfelinto you are correct we need a function that iterates through editnurb for a given Curve and check if any are selected. I wrapped the body of ED_curve_nurb_select_check with a loop for (const Nurb *nu = cu->editnurb->nurbs.first; nu; nu = nu->next). Other parts of ED_curve_nurb_select_check depend on the Curve so I figure pass in the Curve instead of editnurb.

I followed the naming conventions and locations like the ones for metaballs, created bool BKE_curve_is_any_nurbs_selected(const Curve *cu) located in /blender/source/blender/blenkernel/intern/curve.c. I figure those things along with the place of the code is trivial and if needs to change someone else can do that.

If this is acceptable then I will make changes to the function to skip if not selected elements.

https://developer.blender.org/D3412

@dfelinto you are correct we need a function that iterates through `editnurb` for a given Curve and check if any are selected. I wrapped the body of `ED_curve_nurb_select_check` with a loop `for (const Nurb *nu = cu->editnurb->nurbs.first; nu; nu = nu->next)`. Other parts of `ED_curve_nurb_select_check` depend on the Curve so I figure pass in the Curve instead of `editnurb`. I followed the naming conventions and locations like the ones for metaballs, created `bool BKE_curve_is_any_nurbs_selected(const Curve *cu)` located in `/blender/source/blender/blenkernel/intern/curve.c`. I figure those things along with the place of the code is trivial and if needs to change someone else can do that. If this is acceptable then I will make changes to the function to skip if not selected elements. https://developer.blender.org/D3412

Habib Gahbiche commented

2018-10-28 16:13:43 +01:00

Added subscriber: @zazizizou

Duarte Farrajota Ramos commented

2018-10-29 01:42:02 +01:00

Added subscriber: @DuarteRamos

Dalai Felinto commented

2018-11-07 01:59:40 +01:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-11-07 01:59:40 +01:00

Dalai Felinto commented

2018-11-07 01:59:40 +01:00

All operators addressed, thanks everyone for the contributions.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Multi-Object-Mode: Edit Curve Tools #54648

Select Menu:

Curve Menu:

Other:

Select Control Points from any Bezier Curve selected