Library Overrides - investigate further performances issues. #54762

New Issue

Bastien Montagne · 2018-04-22T17:11:11+02:00

Bastien Montagne commented

2018-04-22 17:11:11 +02:00

Generating library override operation for a production character (like Autumn in Spring) implies going over and comparing several hundreds of thousands of RNA properties... No way to make this lightning fast, some ideas would be to try to remove (prune) paths that are not supposed to change ever... Not yet sure how to do this though, we already skip a good share of the whole RNA tree.

2a38b857f7 already tackled all low hanging fruits here, any further improvement will likely require deeper work for much less gain…

Generating library override operation for a production character (like Autumn in Spring) implies going over and comparing several hundreds of thousands of RNA properties... No way to make this lightning fast, some ideas would be to try to remove (prune) paths that are not supposed to change ever... Not yet sure how to do this though, we already skip a good share of the whole RNA tree. 2a38b857f7 already tackled all low hanging fruits here, any further improvement will likely require deeper work for much less gain…

Bastien Montagne self-assigned this 2018-04-22 17:11:11 +02:00

Bastien Montagne commented

2018-04-22 17:11:11 +02:00

Added subscribers: @mont29, @spockTheGray-4

Blazej Floch commented

2019-12-11 15:52:28 +01:00

Added subscriber: @Blazej-Floch

Blazej Floch commented

2019-12-11 15:52:28 +01:00

First off thanks for all the work that has gone into the library overrides.

We tested them on our production rigs but find this very issue to be showstopping.

Just selecting any control results in a 4 seconds delay, 3 of which are the mentioned RNA property comparisons - the hottest path being string comparisons.
When we disable Undo the delay reduces to 1 second (evaluation of the rig only).

We are neither sure why the full rig is evaluated nor why a selection of a control would result in a Undo-step record. That's something we need to look into separately.
But the performance issue discussed here still stands.

Any suggestions on how to speed up the process?

First off thanks for all the work that has gone into the library overrides. We tested them on our production rigs but find this very issue to be showstopping. Just selecting any control results in a 4 seconds delay, 3 of which are the mentioned RNA property comparisons - the hottest path being string comparisons. When we disable Undo the delay reduces to 1 second (evaluation of the rig only). We are neither sure why the full rig is evaluated nor why a selection of a control would result in a Undo-step record. That's something we need to look into separately. But the performance issue discussed here still stands. Any suggestions on how to speed up the process?

Bastien Montagne commented

2019-12-11 16:18:21 +01:00

@Blazej-Floch thanks for testing and reporting!

Are you using latest master? Commit 2a38b857f7 should have made things already much, much better than the 2.81 release situation on that aspect. Though there should still be some more improvements possible here…

@Blazej-Floch thanks for testing and reporting! Are you using latest master? Commit 2a38b857f7 should have made things already much, much better than the 2.81 release situation on that aspect. Though there should still be some more improvements possible here…

Blazej Floch commented

2019-12-11 19:48:44 +01:00

Thanks for the quick reply. I was not aware of this change on master.

The override time is now reduced to ~500 ms! I'll pass a build on to our production for further testing.

Thanks a lot.

BTW: A debug definition was left in that commit ;)
https://developer.blender.org/diffusion/B/browse/master/source/blender/makesrna/intern/rna_access_compare_override.c$30

Thanks for the quick reply. I was not aware of this change on master. The override time is now reduced to ~500 ms! I'll pass a build on to our production for further testing. Thanks a lot. BTW: A debug definition was left in that commit ;) https://developer.blender.org/diffusion/B/browse/master/source/blender/makesrna/intern/rna_access_compare_override.c$30

Bastien Montagne commented

2019-12-11 19:51:22 +01:00

Arg, thanks for noting that debug print! xD

Bastien Montagne was unassigned by Dalai Felinto

2019-12-23 16:36:16 +01:00

Bastien Montagne self-assigned this 2020-01-16 09:20:01 +01:00

Bastien Montagne changed title from ~~Static Overrides - investigate further performances issues.~~ to Library Overrides - investigate further performances issues.

2020-01-16 09:24:03 +01:00

Bastien Montagne commented

2020-06-19 10:39:19 +02:00

The following commits made typical override handling of complex production character several times faster again:

The following commits made typical override handling of complex production character several times faster again: * d5954ef11c * 722adcfc48 * 44f7852660

Bastien Montagne commented

2020-08-20 12:46:01 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2020-08-20 12:46:01 +02:00

Bastien Montagne commented

2020-08-20 12:46:01 +02:00

Would consider this as done/solved for now as well.

Thomas Dinges added this to the 2.91 milestone 2023-02-08 16:21:50 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Library Overrides - investigate further performances issues. #54762