Build is broken on 2.8 on darwin platform #54765

New Issue

Tycho Tatitsccheff · 2018-04-23T01:47:39+02:00

Tycho Tatitsccheff commented

2018-04-23 01:47:39 +02:00

System Information
Operating system and graphics card

Blender Version
Broken: branch 2.8, commit 574c0fe38f
Worked: branch 2.8, commit c23f33ac9e

Short description of error

Build is broken on 2.8 on darwin platform.

Exact steps for others to reproduce the error

follow wiki to setup build environment
open Xcode
run build
boom

Potentiel patch to fix

diff --git a/source/blender/editors/screen/area.c b/source/blender/editors/screen/area.c
index 588a2abec53..0897ac6f9a9 100644
--- a/source/blender/editors/screen/area.c
+++ b/source/blender/editors/screen/area.c
@@ -662,7 +662,7 @@ static void area_azone_initialize(wmWindow *win, const bScreen *screen, ScrArea

        /* can't click on bottom corners on OS X, already used for resizing */
 #ifdef __APPLE__
-       if (!(sa->totrct.xmin == 0 && sa->totrct.ymin == 0) || WM_window_is_fullscreen(win))
+       if (!(sa->totrct.xmin == 0 && sa->totrct.ymin == 0) || WM_window_is_fullscreen(win)) {
 #else
        (void)win;
 #endif
@@ -700,6 +700,10 @@ static void area_azone_initialize(wmWindow *win, const bScreen *screen, ScrArea
                az->y2 = coords[i][3];
                BLI_rcti_init(&az->rect, az->x1, az->x2, az->y1, az->y2);
        }
+       #ifdef __APPLE__
+       }
+       #endif
 }

 static void fullscreen_azone_initialize(ScrArea *sa, ARegion *ar)

After the patch, it builds.
I'm not sure of the correctness of the patch so I did not opened a diferential.

cc @ideasman42

**System Information** Operating system and graphics card **Blender Version** Broken: branch 2.8, commit 574c0fe38f Worked: branch 2.8, commit c23f33ac9e **Short description of error** Build is broken on 2.8 on darwin platform. ![image.png](https://archive.blender.org/developer/F2940979/image.png) **Exact steps for others to reproduce the error** - follow wiki to setup build environment - open Xcode - run build - boom ![image.png](https://archive.blender.org/developer/F2940979/image.png) **Potentiel patch to fix** ``` diff --git a/source/blender/editors/screen/area.c b/source/blender/editors/screen/area.c index 588a2abec53..0897ac6f9a9 100644 --- a/source/blender/editors/screen/area.c +++ b/source/blender/editors/screen/area.c @@ -662,7 +662,7 @@ static void area_azone_initialize(wmWindow *win, const bScreen *screen, ScrArea /* can't click on bottom corners on OS X, already used for resizing */ #ifdef __APPLE__ - if (!(sa->totrct.xmin == 0 && sa->totrct.ymin == 0) || WM_window_is_fullscreen(win)) + if (!(sa->totrct.xmin == 0 && sa->totrct.ymin == 0) || WM_window_is_fullscreen(win)) { #else (void)win; #endif @@ -700,6 +700,10 @@ static void area_azone_initialize(wmWindow *win, const bScreen *screen, ScrArea az->y2 = coords[i][3]; BLI_rcti_init(&az->rect, az->x1, az->x2, az->y1, az->y2); } + #ifdef __APPLE__ + } + #endif } static void fullscreen_azone_initialize(ScrArea *sa, ARegion *ar) ``` After the patch, it builds. I'm not sure of the correctness of the patch so I did not opened a diferential. cc @ideasman42

Tycho Tatitsccheff commented

2018-04-23 01:47:39 +02:00

Added subscribers: @ideasman42, @TychoTat

blender-admin commented

2018-04-23 01:47:39 +02:00

This issue was referenced by ede19477c8

This issue was referenced by ede19477c825a52aaca224eb72fd708adc7871f9

Philipp Oeser commented

2018-04-23 10:01:20 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-04-23 10:01:20 +02:00

Changed status from 'Open' to: 'Archived'

Philipp Oeser closed this issue

2018-04-23 10:01:20 +02:00

Philipp Oeser self-assigned this 2018-04-23 10:01:20 +02:00

Philipp Oeser commented

2018-04-23 10:01:20 +02:00

Thanx for investigating and raising awareness.

However, currently we are aware of many issues in 2.8 and actively working to fix them. But since replying to reports takes time, we have decided to limit bug reports to module team members.

Thanx for investigating and raising awareness. However, currently we are aware of many issues in 2.8 and actively working to fix them. But since replying to reports takes time, we have decided to limit bug reports to [module team ](https://wiki.blender.org/index.php/Dev:Doc/Process/Module_Owners/List) members.

Brecht Van Lommel commented

2018-04-23 13:43:36 +02:00

Changed status from 'Archived' to: 'Resolved'

Brecht Van Lommel commented

2018-04-23 13:43:56 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2018-04-23 13:43:56 +02:00

Thanks for the patch, the fix I committed was different since we now need to exclude both bottom corners of the window.

Tycho Tatitsccheff commented

2018-04-25 16:37:33 +02:00

Your welcome @brecht.

@lichtwerk I understand I wasn't going to open an issue to a alpha branch without suggesting a patch. If you prefer I can not open any reports next time : what do you think ? what is better for you ?

Your welcome @brecht. @lichtwerk I understand I wasn't going to open an issue to a alpha branch without suggesting a patch. If you prefer I can not open any reports next time : what do you think ? what is better for you ?

Ray molenkamp commented

2018-04-25 16:46:10 +02:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2018-04-25 16:46:10 +02:00

Tasks about build issues aren't allowed as outlined on the bug report form.

It's best to [post a differential ]] if you have a patch ready, however, since this is in the 2.8 branch, it's a little easier to manage if you submit the differential using [ https:*wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review | arc

Tasks about build issues aren't allowed [as outlined ](https://developer.blender.org/maniphest/task/edit/form/1/) on the bug report form. It's best to [post a differential ]] if you have a patch ready, however, since this is in the 2.8 branch, it's a little easier to manage if you submit the differential using [[ https:*wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review | arc ](https:*developer.blender.org/differential/diff/create/)

Tycho Tatitsccheff commented

2018-04-25 18:52:58 +02:00

Sure.

sorry that I didn't read the bug form properly.
will post a diff next time :)

Sure. sorry that I didn't read the bug form properly. will post a diff next time :)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Build is broken on 2.8 on darwin platform #54765