Depsgraph: Crash with COW with EEVEE viewport #55062

New Issue

Clément Foucault · 2018-05-14T17:40:58+02:00

Clément Foucault commented

2018-05-14 17:40:58 +02:00

Step to reproduce:

0.0 Start blender with COW enabled.
0.5 Load file. crash_cow_render.blend
1.0 Switch Viewport to Rendered mode (EEVEE).
2.0 Switch the texture panel to 3D viewport.
3.0 Crash.

The new viewport does not even use EEVEE (it uses workbench by default).
It has to do with the dynamic UBO data hack referencing data from the nodetree DNA.

Step to reproduce: 0.0 Start blender with COW enabled. 0.5 Load file. [crash_cow_render.blend](https://archive.blender.org/developer/F3364749/crash_cow_render.blend) 1.0 Switch Viewport to Rendered mode (EEVEE). 2.0 Switch the texture panel to 3D viewport. 3.0 Crash. The new viewport does not even use EEVEE (it uses workbench by default). It has to do with the dynamic UBO data hack referencing data from the nodetree DNA.

Sergey Sharybin was assigned by Clément Foucault

2018-05-14 17:40:58 +02:00

Clément Foucault commented

2018-05-14 17:40:58 +02:00

Added subscriber: @fclem

Clément Foucault changed title from ~~Depsgraph: Crash with COW after render in EEVEE~~ to Depsgraph: Crash with COW with EEVEE viewport

2018-05-14 18:45:38 +02:00

Brecht Van Lommel commented

2018-05-25 15:07:00 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2018-05-25 15:07:00 +02:00

Brecht Van Lommel commented

2018-05-25 15:09:06 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2018-05-25 15:09:06 +02:00

Changed status from 'Resolved' to: 'Open'

Brecht Van Lommel reopened this issue

2018-05-25 15:09:06 +02:00

Brecht Van Lommel commented

2018-05-25 15:09:06 +02:00

Oops, used the wrong bug number in commit.

Dalai Felinto commented

2018-06-01 14:52:29 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2018-06-01 14:52:29 +02:00

Reproduced in a simpler file:
cow-render-crash.blend

Just change to RENDERED mode (Shift + Z) and try to render (F12) you may need to refresh the view for it to crash.

I only get the error via QTCreator, not via command-line.

Full backtrace: running single-thread: P715

Reproduced in a simpler file: [cow-render-crash.blend](https://archive.blender.org/developer/F3544091/cow-render-crash.blend) Just change to RENDERED mode (Shift + Z) and try to render (F12) you may need to refresh the view for it to crash. I only get the error via QTCreator, not via command-line. Full backtrace: running single-thread: [P715](https://archive.blender.org/developer/P715.txt)

Sergey Sharybin was unassigned by Dalai Felinto

2018-06-02 18:30:15 +02:00

Dalai Felinto self-assigned this 2018-06-02 18:30:15 +02:00

Dalai Felinto commented

2018-06-02 18:30:15 +02:00

Added subscriber: @Sergey

Dalai Felinto commented

2018-06-05 11:59:58 +02:00

Added subscriber: @AlexanderRomanov

Dalai Felinto commented

2018-06-05 11:59:58 +02:00

@brecht @Sergey @fclem and @dfelinto meeting notes:

For now we force tree rebuilding for every change in the material.

@fclem will prevent deferred shader compilation to run for existent shaders.
@dfelinto will make the tree to rebuild and update UBO code to not refer to original data.

This may lead to performance decrease in animated node trees.
The next interesting steps are:

@AlexanderRomanov 's patch to expose the shaders to Python also make them more granular (D2577), if it doesn't help performance may lead to more compact shaders anyways and could be applied (at the least the part related to the shader code generation). I suspect the patch has both parts to mangled and is in a dire need of an update though.
Profile the shader generation steps and see if re-creation the shader in a production environment is an issue.
If it is: Port part of the re-creation of shaders to the (threaded) depsgraph. All the part related to localizing the tree, hashing and lookup could be threaded in this scenario.
Additionally we can revisit the idea of updating UBOs when the topology remains unchanged, instead of re-creating the shader.

@brecht @Sergey @fclem and @dfelinto meeting notes: For now we force tree rebuilding for every change in the material. - @fclem will prevent deferred shader compilation to run for existent shaders. - @dfelinto will make the tree to rebuild and update UBO code to not refer to original data. This may lead to performance decrease in animated node trees. The next interesting steps are: - @AlexanderRomanov 's patch to expose the shaders to Python also make them more granular ([D2577](https://archive.blender.org/developer/D2577)), if it doesn't help performance may lead to more compact shaders anyways and could be applied (at the least the part related to the shader code generation). I suspect the patch has both parts to mangled and is in a dire need of an update though. - Profile the shader generation steps and see if re-creation the shader in a production environment is an issue. - If it is: Port part of the re-creation of shaders to the (threaded) depsgraph. All the part related to localizing the tree, hashing and lookup could be threaded in this scenario. - Additionally we can revisit the idea of updating UBOs when the topology remains unchanged, instead of re-creating the shader.

blender-admin commented

2018-06-07 12:47:16 +02:00

This issue was referenced by 3126f85d26

This issue was referenced by 3126f85d26448d7e8698724a563e0f5a08f4f34f

Dalai Felinto commented

2018-06-07 12:57:13 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-06-07 12:57:13 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Depsgraph: Crash with COW with EEVEE viewport #55062