Crash when switch layer on texture paint mode #55349

New Issue

Dutrieux Olivier · 2018-06-06T14:35:12+02:00

Dutrieux Olivier commented

2018-06-06 14:35:12 +02:00

System Information
Windows 10 x64 pro & Nvidia 780

Blender Version
Broken: 2.79b

Short description of error
Crash when switch layer on texture paint mode

Exact steps for others to reproduce the error
Check this video to see the process to reproduce the problem : https://youtu.be/pdbkQPop3Bg

attach file : 8.7-Projection d’image en mode stencil.blend

Best regards

**System Information** Windows 10 x64 pro & Nvidia 780 **Blender Version** Broken: 2.79b **Short description of error** Crash when switch layer on texture paint mode **Exact steps for others to reproduce the error** Check this video to see the process to reproduce the problem : https://youtu.be/pdbkQPop3Bg attach file : [8.7-Projection d’image en mode stencil.blend](https://archive.blender.org/developer/F3601617/8.7-Projection_d_image_en_mode_stencil.blend) Best regards

Dutrieux Olivier commented

2018-06-06 14:35:12 +02:00

Added subscriber: @dutrieux

Philipp Oeser commented

2018-06-06 15:55:29 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2018-06-06 15:55:29 +02:00

Philipp Oeser commented

2018-06-06 15:55:29 +02:00

Confirmed.
PAINT_OT_add_texture_paint_slot needs another poll. Can do tomorrow.

Confirmed. `PAINT_OT_add_texture_paint_slot` needs another poll. Can do tomorrow.

Philipp Oeser commented

2018-06-08 15:11:55 +02:00

Excuse the little detour here:

atm. PAINT_OT_add_texture_paint_slot just polls with ED_operator_region_view3d_active. (this seems unneccessary, op could actually work without 3dview...)
BUT: it should make sure we have an active object.
Thing is that when you switch to another layer (so that you selected/active object is on a hidden layer), then context.active_object (CTX_data_active_object) is actually None.
Thats not good, so we have to make sure we have some valid CTX_data_active_object.

Lots of operators use ED_operator_object_active for their poll, so intuition would be to just use this one.
BUT: this will either return context.object OR context.active_object, so valid active object is still not ensured... (would still crash)

Seems to me we have two possible solutions:

use custom poll that just prevents usage in this case (see D3466)
use standard ED_operator_object_active poll and get object with ED_object_active_context (instead of CTX_data_active_object) (see D3467)

Excuse the little detour here: atm. `PAINT_OT_add_texture_paint_slot` just polls with `ED_operator_region_view3d_active`. (this seems unneccessary, op could actually work without 3dview...) BUT: it should make sure we have an active object. Thing is that when you switch to another layer (so that you selected/active object is on a hidden layer), then context.active_object (`CTX_data_active_object`) is actually None. Thats not good, so we have to make sure we have some valid `CTX_data_active_object`. Lots of operators use `ED_operator_object_active` for their poll, so intuition would be to just use this one. BUT: this will either return context.object OR context.active_object, so valid active object is still not ensured... (would still crash) Seems to me we have two possible solutions: - [x] use custom poll that just prevents usage in this case (see [D3466](https://archive.blender.org/developer/D3466)) - [x] use standard `ED_operator_object_active` poll and get object with `ED_object_active_context` (instead of `CTX_data_active_object`) (see [D3467](https://archive.blender.org/developer/D3467))

blender-admin commented

2018-06-11 09:12:29 +02:00

This issue was referenced by 474a145d78

This issue was referenced by 474a145d78ff9870e24fe6a2969bce6375da0754

Philipp Oeser commented

2018-06-11 09:33:29 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2018-06-11 09:33:29 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when switch layer on texture paint mode #55349