Double undo in sculpt mode after lasso mask. Follow up for Maniphest T55033 #55399

New Issue

Erick Tukuniata · 2018-06-08T12:54:29+02:00

Erick Tukuniata commented

2018-06-08 12:54:29 +02:00

System Information
win7 gtx 550ti

Blender Version
Broken: sadly i didn't see any hash here, this a follow up for Maniphest #55033
Worked: (optional):hash before undo changes?

Short description of error
Double undo in sculpt mode after lasso mask.

Exact steps for others to reproduce the error

In dyntopo sculpt some and lasso mask some part.
Notice that you have to undo twice before undo happens.

**System Information** win7 gtx 550ti **Blender Version** Broken: sadly i didn't see any hash here, this a follow up for Maniphest #55033 Worked: (optional):hash before undo changes? **Short description of error** Double undo in sculpt mode after lasso mask. **Exact steps for others to reproduce the error** - In dyntopo sculpt some and lasso mask some part. - Notice that you have to undo twice before undo happens.

Erick Tukuniata commented

2018-06-08 12:54:29 +02:00

Added subscriber: @ErickNyanduKabongo

Philipp Oeser commented

2018-06-15 16:10:59 +02:00

Added subscribers: @ideasman42, @lichtwerk

Campbell Barton was assigned by Philipp Oeser

2018-06-15 16:10:59 +02:00

Philipp Oeser commented

2018-06-15 16:10:59 +02:00

Note: we are getting two undo pushes with this operator [same for box mask btw.]

1  sculpt_undosys_step_encode      sculpt_undo.c     1034 0x1e58737 
2  undosys_step_encode             undo_system.c     149  0x27825b1 
3  BKE_undosys_step_push_with_type undo_system.c     454  0x2783a27 
4  BKE_undosys_step_push           undo_system.c     474  0x2783b47 
5  sculpt_undo_push_end            sculpt_undo.c     998  0x1e58685 
6  paint_mask_gesture_lasso_exec   paint_mask.c      512  0x1e1830d 
7  gesture_lasso_apply             wm_gesture_ops.c  612  0x185d0c8 
8  WM_gesture_lasso_modal          wm_gesture_ops.c  658  0x185d2f5

and

1  sculpt_undosys_step_encode      sculpt_undo.c     1034 0x1e58737 
2  undosys_step_encode             undo_system.c     149  0x27825b1 
3  BKE_undosys_step_push_with_type undo_system.c     454  0x2783a27 
4  BKE_undosys_step_push           undo_system.c     474  0x2783b47 
5  ED_undo_push                    ed_undo.c         91   0x187a2db 
6  ED_undo_push_op                 ed_undo.c         168  0x187a5d0 
7  wm_operator_finished            wm_event_system.c 755  0x184f035 
8  wm_handler_operator_call        wm_event_system.c 1821 0x1851c1a

Not sure if this is intended?

Of course, since the exec comes with its "own" undo call sculpt_undo_push_end, we could remove OPTYPE_UNDO [like e.g. mask fill] from the operator flags, but that's removing (amongst other things) the ability to redo as well...

Soo, passing this on to @ideasman42 ...

Note: we are getting two undo pushes with this operator [same for box mask btw.] ``` 1 sculpt_undosys_step_encode sculpt_undo.c 1034 0x1e58737 2 undosys_step_encode undo_system.c 149 0x27825b1 3 BKE_undosys_step_push_with_type undo_system.c 454 0x2783a27 4 BKE_undosys_step_push undo_system.c 474 0x2783b47 5 sculpt_undo_push_end sculpt_undo.c 998 0x1e58685 6 paint_mask_gesture_lasso_exec paint_mask.c 512 0x1e1830d 7 gesture_lasso_apply wm_gesture_ops.c 612 0x185d0c8 8 WM_gesture_lasso_modal wm_gesture_ops.c 658 0x185d2f5 ``` and ``` 1 sculpt_undosys_step_encode sculpt_undo.c 1034 0x1e58737 2 undosys_step_encode undo_system.c 149 0x27825b1 3 BKE_undosys_step_push_with_type undo_system.c 454 0x2783a27 4 BKE_undosys_step_push undo_system.c 474 0x2783b47 5 ED_undo_push ed_undo.c 91 0x187a2db 6 ED_undo_push_op ed_undo.c 168 0x187a5d0 7 wm_operator_finished wm_event_system.c 755 0x184f035 8 wm_handler_operator_call wm_event_system.c 1821 0x1851c1a ``` Not sure if this is intended? Of course, since the exec comes with its "own" undo call `sculpt_undo_push_end`, we could remove `OPTYPE_UNDO` [like e.g. `mask fill`] from the operator flags, but that's removing (amongst other things) the ability to redo as well... Soo, passing this on to @ideasman42 ...

Campbell Barton commented

2019-01-31 08:49:22 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2019-01-31 08:49:22 +01:00

Campbell Barton commented

2019-01-31 08:49:22 +01:00

Thanks @lichtwerk for looking into this, the bug doesn't exist anymore - but it's still strange to use the flag in one operator and not another.

Removed 8f4b7d706b

Thanks @lichtwerk for looking into this, the bug doesn't exist anymore - but it's still strange to use the flag in one operator and not another. Removed 8f4b7d706b

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Double undo in sculpt mode after lasso mask. Follow up for Maniphest T55033 #55399