Fix problem with Viewport Manipulator Gizmo #55420

New Issue

Antonio Vazquez · 2018-06-09T20:18:08+02:00

Antonio Vazquez commented

2018-06-09 20:18:08 +02:00

As the Drawing/Sculpt/Weight mode capture any mouse input, the manipulator cannot be used.

Now, as the Draw operator is enabled when press LMB, the event of the operator is captured before gizmo.

We need

a) handle before gizmo events
or
b) a function to detect the cursor is over gizmo, something like ED_is_over_gizmo()

As the Drawing/Sculpt/Weight mode capture any mouse input, the manipulator cannot be used. Now, as the Draw operator is enabled when press LMB, the event of the operator is captured before gizmo. We need **a)** handle before gizmo events or **b)** a function to detect the cursor is over gizmo, something like ED_is_over_gizmo()

Antonio Vazquez commented

2018-06-09 20:18:08 +02:00

Added subscribers: @antoniov, @pablovazquez, @mendio, @pepe-school-land, @JoshuaLeung

Antonio Vazquez changed title from ~~Fix problem with Viewport Manipulator~~ to Fix problem with Viewport Manipulator Gizmo

2018-07-24 12:14:49 +02:00

Antonio Vazquez commented

2018-07-24 12:16:58 +02:00

Added subscriber: @ideasman42

Antonio Vazquez commented

2018-07-24 12:16:58 +02:00

@ideasman42 Could you take a look on this problem.

Now, as the Draw operator is enabled when press LMB, the event of the operator is captured before gizmo.

We need a) handle before gizmo events or b) a function to detect the cursor is over gizmo, something like ED_is_over_gizmo()

@ideasman42 Could you take a look on this problem. Now, as the Draw operator is enabled when press LMB, the event of the operator is captured before gizmo. We need **a)** handle before gizmo events or **b)** a function to detect the cursor is over gizmo, something like ED_is_over_gizmo()

Campbell Barton commented

2018-07-30 10:00:37 +02:00

Checking if an event is over a manipulator isn't cheap.

Also, by design, its not good to have to search to find if an event would be handled.
(manipulators might be under the cursor but de-activated too... - pass-through for eg).

So think it's best to find why this works for sculpt mode-mode, vertex-paint, curve-draw - all work correctly, but not grease pencil.

Checking if an event is over a manipulator isn't cheap. Also, by design, its not good to have to search to find if an event would be handled. (manipulators might be under the cursor but de-activated too... - pass-through for eg). So think it's best to find why this works for sculpt mode-mode, vertex-paint, curve-draw - all work correctly, but not grease pencil.

Antonio Vazquez commented

2018-07-30 13:37:26 +02:00

@ideasman42 Following your advices, I looked at the GPENCIL_OT_draw operator and what were the differences with sculpt paint. I have seen that both operators are very similar (I guess the initial implementation was a duplication of sculpt operator and modified). Both operators keymaps definition are very similar and I do not find apparent differences.

I have been doing debug and I have found the Invoke function of SCULPT_OT_brush_stroke operator is only called when the mouse is pressed in the viewport, but if you press over the gizmo, the invoke function is not called, so I assume the operator is not started.

I have checked the keymap and operator poll of sculpt operator and both return true over the gizmo, so there is something that does that events of gizmo are captured before than sculpt.

I looked in keymap registration too, but I'm unable to find where it's the place to set the gizmo capture events before sculpt operators to do the same for grease pencil operators.

Could you help me?

@JoshuaLeung Do you have any idea?

@ideasman42 Following your advices, I looked at the GPENCIL_OT_draw operator and what were the differences with sculpt paint. I have seen that both operators are very similar (I guess the initial implementation was a duplication of sculpt operator and modified). Both operators keymaps definition are very similar and I do not find apparent differences. I have been doing debug and I have found the Invoke function of SCULPT_OT_brush_stroke operator is only called when the mouse is pressed in the viewport, but if you press over the gizmo, the invoke function is not called, so I assume the operator is not started. I have checked the keymap and operator poll of sculpt operator and both return true over the gizmo, so there is something that does that events of gizmo are captured before than sculpt. I looked in keymap registration too, but I'm unable to find where it's the place to set the gizmo capture events before sculpt operators to do the same for grease pencil operators. Could you help me? @JoshuaLeung Do you have any idea?

Campbell Barton commented

2018-11-12 08:54:07 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2018-11-12 08:54:07 +01:00

Campbell Barton self-assigned this 2018-11-12 08:54:07 +01:00

Campbell Barton commented

2018-11-12 08:54:08 +01:00

Fixed df6530594f

Fixed df6530594f

Sign in to join this conversation.