Ungroup in Node editor crash Blender #55462

New Issue

Cenek Strichel · 2018-06-13T00:44:45+02:00

Cenek Strichel commented

2018-06-13 00:44:45 +02:00

System Information
W10 64b

Blender Version
7c75c2d

Short description of error
Blender crash everytime I want to ungroup shader

Exact steps for others to reproduce the error

open crash.blend
select cube
ungroup shader in "kamuflaz texture" group
crash

**System Information** W10 64b **Blender Version** 7c75c2d **Short description of error** Blender crash everytime I want to ungroup shader **Exact steps for others to reproduce the error** 1) open [crash.blend](https://archive.blender.org/developer/F3680012/crash.blend) 2) select cube 3) ungroup shader in "kamuflaz texture" group 4) crash

Cenek Strichel commented

2018-06-13 00:44:45 +02:00

Added subscriber: @Cenda

Philipp Oeser commented

2018-06-13 09:45:31 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-06-13 09:45:31 +02:00

Can confirm, crash in master, worked in 2.79b, having a closer look now

Sergey Sharybin was assigned by Philipp Oeser

2018-06-13 11:13:51 +02:00

Philipp Oeser commented

2018-06-13 11:13:51 +02:00

Added subscriber: @Sergey

Philipp Oeser commented

2018-06-13 11:13:51 +02:00

bisected down to 1cddab18de

1  action_groups_clear_tempflags     action.c             392   0x251694e 
2  action_move_fcurves_by_basepath   anim_sys.c           442   0x251bac3 
3  BKE_animdata_separate_by_basepath anim_sys.c           546   0x251be34 
4  node_group_ungroup                node_group.c         263   0x19133ab 
5  node_group_ungroup_exec           node_group.c         368   0x191376e

in 1cddab18de BKE_id_copy_ex changed to not NULLify r_newid anymore (returning early out when source is NULL)

So when this happens with NULL action, the returned action is not NULL anymore (but garbage pointer created in BKE_action_copy), leading to problems later...

P726 is quick fix (but not sure returnpointer should always be NULL when source is NULL? or check LIB_ID_CREATE_NO_ALLOCATE as well?)

@Sergey: mind having a look?

bisected down to 1cddab18de ``` 1 action_groups_clear_tempflags action.c 392 0x251694e 2 action_move_fcurves_by_basepath anim_sys.c 442 0x251bac3 3 BKE_animdata_separate_by_basepath anim_sys.c 546 0x251be34 4 node_group_ungroup node_group.c 263 0x19133ab 5 node_group_ungroup_exec node_group.c 368 0x191376e ``` in 1cddab18de `BKE_id_copy_ex` changed to not NULLify `r_newid` anymore (returning early out when source is NULL) So when [this ](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_node/node_group.c;67e8c1e1c7cfbb000de903c9c4e83874adba411f$260) happens with NULL action, the returned action is not NULL anymore (but garbage pointer created in BKE_action_copy), leading to problems later... [P726](https://archive.blender.org/developer/P726.txt) is quick fix (but not sure returnpointer should **always** be NULL when source is NULL? or check LIB_ID_CREATE_NO_ALLOCATE as well?) @Sergey: mind having a look?

blender-admin commented

2019-01-25 16:49:40 +01:00

This issue was referenced by 693721cc7e

This issue was referenced by 693721cc7e7d617eeb1c2198a6628bb14f731d6b

Sergey Sharybin commented

2019-01-25 16:51:14 +01:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2019-01-25 16:51:14 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Ungroup in Node editor crash Blender #55462