crash internal animation player #55675

New Issue

Pablo Fournier · 2018-06-29T17:44:17+02:00

Pablo Fournier commented

2018-06-29 17:44:17 +02:00

Broken:ccca2c01649

when I try to scrub on the player it crash

Broken:ccca2c01649 when I try to scrub on the player it crash

Pablo Fournier commented

2018-06-29 17:44:17 +02:00

Added subscriber: @PabloFournier

Dalai Felinto commented

2018-06-29 17:51:49 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2018-06-29 17:51:49 +02:00

Note, the crash is because we are trying to divide by zero.
in blf_glyph.c i is zero:
i = (int)((gc->p2_width - (gc->pad * 2)) / gc->glyph_width_max);

Full backtrace: P745

Note, the crash is because we are trying to divide by zero. in blf_glyph.c i is zero: `i = (int)((gc->p2_width - (gc->pad * 2)) / gc->glyph_width_max);` Full backtrace: [P745](https://archive.blender.org/developer/P745.txt)

Dalai Felinto commented

2018-06-29 17:53:36 +02:00

And for the records, you can reproduce the error with: ./blender -a -f 24 1.0 -s 1 -e 10 -j 1 /tmp/0001.png for a rendered sequence (it crashes once you scrab).

And for the records, you can reproduce the error with: `./blender -a -f 24 1.0 -s 1 -e 10 -j 1 /tmp/0001.png` for a rendered sequence (it crashes once you scrab).

Ray molenkamp was assigned by Dalai Felinto

2018-06-29 18:20:51 +02:00

Dalai Felinto commented

2018-06-29 18:20:51 +02:00

Added subscriber: @fclem

Dalai Felinto commented

2018-06-29 18:20:51 +02:00

There is a chance that this never worked in 2.8. But there is also a chance this was crashed with the recent OpenGL and BLF refactors.
To be honest I can barely bisect this since the moment I roll a few commits back, I get GWN_vao_alloc(): Assertionactive_ctx' failed.` or worse.

There is a chance that this never worked in 2.8. But there is also a chance this was crashed with the recent OpenGL and BLF refactors. To be honest I can barely bisect this since the moment I roll a few commits back, I get ` GWN_vao_alloc(): Assertion `active_ctx' failed.` or worse.

Ray molenkamp commented

2018-06-29 19:01:32 +02:00

Added subscriber: @ideasman42

Ray molenkamp commented

2018-06-29 19:01:32 +02:00

gpu_extensions_init is never called, P746 fixes it but @ideasman42 thought that calling GPU_Init was a bit heavy for what the player needed. P747 does the trick as well without having to call GPU_init, i'm not familiar enough with the player code to have a strong opinion here.

gpu_extensions_init is never called, [P746](https://archive.blender.org/developer/P746.txt) fixes it but @ideasman42 thought that calling `GPU_Init` was a bit heavy for what the player needed. [P747](https://archive.blender.org/developer/P747.txt) does the trick as well without having to call `GPU_init`, i'm not familiar enough with the player code to have a strong opinion here.

Brecht Van Lommel commented

2018-07-01 16:55:03 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2018-07-01 16:55:03 +02:00

I'm not sure why we wouldn't just call GPU_init() and GPU_exit(), different code paths for regular Blender and the animation player just make bugs more likely.

I'm not sure why we wouldn't just call `GPU_init()` and `GPU_exit()`, different code paths for regular Blender and the animation player just make bugs more likely.

blender-admin commented

2018-07-01 21:07:18 +02:00

This issue was referenced by bf7c815169

This issue was referenced by bf7c8151696255910594dcd9de1b4af7e7bdd296

Campbell Barton commented

2018-07-01 21:10:32 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2018-07-01 21:10:32 +02:00

Campbell Barton commented

2018-07-01 21:11:17 +02:00

@brecht, saw code-gen and orphan-texture creation, but looking closer - it's not heavy stuff, committed.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

crash internal animation player #55675