Crash when Render F12 or use Preview Materials #55816

New Issue

Antonio Vazquez · 2018-07-07T13:24:13+02:00

Antonio Vazquez commented

2018-07-07 13:24:13 +02:00

Windows 10 - Last source code compiled with VS2017 at 07-Jul 12:00

To reproduce:

Start default scene.
Press F12 or use material tab with preview.

I have doing debug and the error is in DRW_render_object_iter() function in draw_manager.c

the line with error is:

 const int object_type_exclude_viewport = draw_ctx->v3d->object_type_exclude_viewport;

The problem is v3d is NULL. All draw_ctx pointers are not initializated at this moment.

Windows 10 - Last source code compiled with VS2017 at 07-Jul 12:00 To reproduce: 1) Start default scene. 2) Press F12 or use material tab with preview. I have doing debug and the error is in DRW_render_object_iter() function in draw_manager.c the line with error is: ``` const int object_type_exclude_viewport = draw_ctx->v3d->object_type_exclude_viewport; ``` The problem is v3d is NULL. All draw_ctx pointers are not initializated at this moment.

Antonio Vazquez commented

2018-07-07 13:24:13 +02:00

Added subscriber: @antoniov

blender-admin commented

2018-07-07 13:24:13 +02:00

#55832 was marked as duplicate of this issue

blender-admin commented

2018-07-07 13:24:13 +02:00

#55851 was marked as duplicate of this issue

blender-admin commented

2018-07-07 13:24:13 +02:00

#55810 was marked as duplicate of this issue

blender-admin commented

2018-07-07 13:24:13 +02:00

#55822 was marked as duplicate of this issue

blender-admin commented

2018-07-07 13:24:13 +02:00

#55805 was marked as duplicate of this issue

blender-admin commented

2018-07-07 13:24:13 +02:00

#55853 was marked as duplicate of this issue

blender-admin commented

2018-07-07 13:24:13 +02:00

#55809 was marked as duplicate of this issue

Clément Foucault was assigned by Antonio Vazquez

2018-07-07 13:24:40 +02:00

Clément Foucault removed their assignment 2018-07-07 15:31:29 +02:00

Jeroen Bakker was assigned by Clément Foucault

2018-07-07 15:31:29 +02:00

Clément Foucault commented

2018-07-07 15:31:29 +02:00

Added subscriber: @fclem

Oliver Weissbarth commented

2018-07-08 19:24:15 +02:00

Added subscriber: @oweissbarth

Oliver Weissbarth commented

2018-07-08 19:24:15 +02:00

I can reproduce this on Linux.
I was able to narrow it down to a48b52d546. I built the current HEAD with and without it to isolate it.
Probable duplicates of this are: #55833, #55838, #55822

I can reproduce this on Linux. I was able to narrow it down to a48b52d54669. I built the current HEAD with and without it to isolate it. Probable duplicates of this are: #55833, #55838, #55822

Antonio Vazquez commented

2018-07-08 20:38:09 +02:00

This change fix the problem:

      const int object_type_exclude_viewport = draw_ctx->v3d != NULL ? draw_ctx->v3d->object_type_exclude_viewport : -1;

DEG_OBJECT_ITER_FOR_RENDER_ENGINE_BEGIN(depsgraph, ob)
{
	if (((object_type_exclude_viewport & (1 << ob->type)) == 0) || (object_type_exclude_viewport < 0)) {
		DST.ob_state = NULL;
		callback(vedata, ob, engine, depsgraph);
	}
}
DEG_OBJECT_ITER_FOR_RENDER_ENGINE_END


I have not sent the commit because I want to know the opinion of @jbakker

This change fix the problem: ``` ``` ``` const int object_type_exclude_viewport = draw_ctx->v3d != NULL ? draw_ctx->v3d->object_type_exclude_viewport : -1; ``` DEG_OBJECT_ITER_FOR_RENDER_ENGINE_BEGIN(depsgraph, ob) { if (((object_type_exclude_viewport & (1 << ob->type)) == 0) || (object_type_exclude_viewport < 0)) { DST.ob_state = NULL; callback(vedata, ob, engine, depsgraph); } } DEG_OBJECT_ITER_FOR_RENDER_ENGINE_END ``` I have not sent the commit because I want to know the opinion of @jbakker

Vuk Gardašević commented

2018-07-09 06:00:52 +02:00

Added subscribers: @david.hillard, @bdp