Color Picker Value Bug #56741

Closed
opened 2018-09-10 14:46:51 +02:00 by Julien Kaspar · 27 comments
Member

Blender Version
Broken: 0284392c48

Short description of error
When dragging the Value up to the brightest point in the color picker, the value goes beyond the maximum of 1 and instead up to 16.292.
The halfway point of Value on the color picker is also not 0.5 but instead 0.18.
There seems to be some conflict with the color picker graphic and the color correction in the editors.

**Blender Version** Broken: 0284392c489 **Short description of error** When dragging the Value up to the brightest point in the color picker, the value goes beyond the maximum of 1 and instead up to 16.292. The halfway point of Value on the color picker is also not 0.5 but instead 0.18. There seems to be some conflict with the color picker graphic and the color correction in the editors.
Author
Member

Added subscriber: @JulienKaspar

Added subscriber: @JulienKaspar

Added subscriber: @brecht

Added subscriber: @brecht

When dragging the Value up to the brightest point in the color picker, the value goes beyond the maximum of 1 and instead up to 16.292.

I can't reproduce this one. Are you using the default color picker or did you change it in the user preferences? Are you just dragging the vertical value slider with the mouse?

The halfway point of Value on the color picker is also not 0.5 but instead 0.18.

This by design, the middle show 0.5 in display space which is about 0.18 in scene linear space. We could make it 0.5 in scene linear space but then darker colors will only have a little bit of space at the bottom of the slider.

> When dragging the Value up to the brightest point in the color picker, the value goes beyond the maximum of 1 and instead up to 16.292. I can't reproduce this one. Are you using the default color picker or did you change it in the user preferences? Are you just dragging the vertical value slider with the mouse? > The halfway point of Value on the color picker is also not 0.5 but instead 0.18. This by design, the middle show 0.5 in display space which is about 0.18 in scene linear space. We could make it 0.5 in scene linear space but then darker colors will only have a little bit of space at the bottom of the slider.

Added subscriber: @WilliamReynish

Added subscriber: @WilliamReynish

I can reproduce it.

If you set the color picker to HSV, then move the V all the way to 1, and then return to RGB, the values are over 1 (16.2917, 16.2917, 16.2917).

I can reproduce it. If you set the color picker to HSV, then move the V all the way to 1, and then return to RGB, the values are over 1 (16.2917, 16.2917, 16.2917).

@JulienKaspar, does the issue happen in the daily build from https://builder.blender.org/download for you?

If it doesn't, I think we need to upgrade OpenColorIO in the studio.

@JulienKaspar, does the issue happen in the daily build from https://builder.blender.org/download for you? If it doesn't, I think we need to upgrade OpenColorIO in the studio.
Author
Member

@brecht All of the color picker types act out but the default only once you change the HSV sliders to the maximum.
I noticed that it does actually work as it should (mostly) for the HSV sliders but the RGB ones all act wrong.
These three don't match with the HSV values or the graphic color picker.

@brecht All of the color picker types act out but the default only once you change the HSV sliders to the maximum. I noticed that it does actually work as it should (mostly) for the HSV sliders but the RGB ones all act wrong. These three don't match with the HSV values or the graphic color picker.

I for one get the same bug with builds from builder.blender.org

I for one get the same bug with builds from builder.blender.org
Author
Member

@brecht I am currently working with the latest compiled version of Blender 2.8.

@brecht I am currently working with the latest compiled version of Blender 2.8.

Right, I suspect this is happening due issues with an older version of OpenColorIO, which the Linux studio builds and macOS buildbot are still using. The Linux buildbot on the other hand was upgraded and so would not have the bug, if my theory is right.

Right, I suspect this is happening due issues with an older version of OpenColorIO, which the Linux studio builds and macOS buildbot are still using. The Linux buildbot on the other hand was upgraded and so would not have the bug, if my theory is right.

Added subscriber: @mont29

Added subscriber: @mont29

@JulienKaspar did you try with a linux buildbot build? or did you update ocio in the studio already?

@JulienKaspar did you try with a linux buildbot build? or did you update ocio in the studio already?
Author
Member

@mont29 I just update Blender with the buildbot. How can/should I update the OpenColorIO manually? Are you having the same issue?

@mont29 I just update Blender with the buildbot. How can/should I update the OpenColorIO manually? Are you having the same issue?

Added subscriber: @Sergey

Added subscriber: @Sergey

@JulienKaspar you downloaded blender from https://builder.blender.org/download ? Then you have nothing to do but try that blender and see if things work or not (just to be sure, buildbot has nothing to do with the build script you have at the studio ;) ).

Studio OCIO update is job for @Sergey or @brecht!

And no, here everything seems to work fine.

@JulienKaspar you downloaded blender from https://builder.blender.org/download ? Then you have nothing to do but try that blender and see if things work or not (just to be sure, buildbot has nothing to do with the build script you have at the studio ;) ). Studio OCIO update is job for @Sergey or @brecht! And no, here everything seems to work fine.

It seems to work fine now on Mac after the libs were updated.

It seems to work fine now on Mac after the libs were updated.

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Brecht Van Lommel self-assigned this 2018-09-17 12:12:55 +02:00

We still need to update the libs in the studio, will be done soon. But seems no bug in Blender itself.

We still need to update the libs in the studio, will be done soon. But seems no bug in Blender itself.

Added subscriber: @frameshift

Added subscriber: @frameshift

Changed status from 'Resolved' to: 'Open'

Changed status from 'Resolved' to: 'Open'

Just wanted to report that this has been back for a few days. Current build with the problem is e4153946ad1.

Just wanted to report that this has been back for a few days. Current build with the problem is `e4153946ad1`.

This is weird. Studio sues OCIO 1.1.0, which is would guess is an updated version.

@brecht, i guess this is due to the for for the default view transform of the display. Guess a view somewhere is to be initialized to IMB_colormanagement_init_default_view_settings.

This is weird. Studio sues OCIO 1.1.0, which is would guess is an updated version. @brecht, i guess this is due to the for for the default view transform of the display. Guess a view somewhere is to be initialized to `IMB_colormanagement_init_default_view_settings`.

I think the bug is that the view transform is involved at all in HSV conversion, to me it seems HSV should be remain linear.

I think the bug is that the view transform is involved at all in HSV conversion, to me it seems HSV should be remain linear.

@brecht I would expect the same from the RGB values, no? Only involve the view transform in displaying the colours, not the numbers? I just assumed all of the values were always linear, and wherever I'd see an actual colour displayed, that would have been transformed. Or am I seeing things wrong?

@brecht I would expect the same from the RGB values, no? Only involve the view transform in displaying the colours, not the numbers? I just assumed all of the values were always linear, and wherever I'd see an actual colour displayed, that would have been transformed. Or am I seeing things wrong?

The RGB values are linear. I would also expect the view transform to be for displaying the colors only. It apparently was changed to fix #39627 (HSL color sliders acting funky), but it seems like the wrong solution.

The RGB values are linear. I would also expect the view transform to be for displaying the colors only. It apparently was changed to fix #39627 (HSL color sliders acting funky), but it seems like the wrong solution.

This issue was referenced by 6601a89650

This issue was referenced by 6601a89650f92454aa57bc01bedebd4086f6d98d

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#56741
No description provided.