Node group input sockets not drawing in sidebar #57090

New Issue

ziv · 2018-10-07T02:17:11+02:00

ziv commented

2018-10-07 02:17:11 +02:00

System Information
windows 8.1
GeForce GTX 1070

Blender Version
Broken: 2.8 alpha 2 c419cb7305

Short description of error
when I create a new node group with ctrl+g the values are invisible on the N panel(the one on the right) but you can still click on them and rename them but they don't show up but the outputs do show up

*tested it and new nodes you plug in into input also don't appear under the input section the values are invisible but it still works as buttons

Exact steps for others to reproduce the error
Open up the Shader Editor
take a random node that has an output and plug that into a random node that has an input
select the node with the input and press ctrl+g
check the panel on the right
something similar to this should have happened

**System Information** windows 8.1 GeForce GTX 1070 **Blender Version** Broken: 2.8 alpha 2 c419cb7305f **Short description of error** when I create a new node group with ctrl+g the values are invisible on the N panel(the one on the right) but you can still click on them and rename them but they don't show up but the outputs do show up *tested it and new nodes you plug in into input also don't appear under the input section the values are invisible but it still works as buttons **Exact steps for others to reproduce the error** Open up the Shader Editor take a random node that has an output and plug that into a random node that has an input select the node with the input and press ctrl+g check the panel on the right something similar to this should have happened ![why is this happening.PNG](https://archive.blender.org/developer/F4968449/why_is_this_happening.PNG)

ziv commented

2018-10-07 02:17:11 +02:00

Added subscriber: @ZivShalit

Philipp Oeser commented

2018-10-07 11:56:14 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2018-10-07 11:56:14 +02:00

Philipp Oeser commented

2018-10-07 11:56:14 +02:00

D3776 fixes part of the problem [some remain -- see comments in that Differential]

[D3776](https://archive.blender.org/developer/D3776) fixes part of the problem [some remain -- see comments in that Differential]

Philipp Oeser commented

2018-10-19 16:35:32 +02:00

Added subscribers: @fclem, @mont29

Philipp Oeser commented

2018-10-19 16:35:32 +02:00

Just an update on this:

Inputs and Outputs now show again (after 7d38654ecd)

But following issue remains:
For Inputs the node sockets draw incorrectly [for the very first in the list as well as for the currently selected Input].
For the currently selected they are actually drawn, but are overdrawn by the "row highlighting" (can check this by increasing their radius in code)
If I change the python NODE_UL_interface_sockets.draw_item code to first draw the prop and then the template_node_socket it also draws correctly (thats why Outputs work fine)

So there doesnt seem to be a problem in uiTemplateNodeSocket nor ui_draw_but_NODESOCKET [checked code as good as I could and everything seems fine there].

Instead I suspect (shot in the dark for now) either something going wrong with uiTemplateList and how uiLayoutOverlap is drawn in 2.8 or maybe something how the drawcalls get batched in 2.8?
Will continue investigating [unless @fclem or @mont29 have an idea right away?]

Just an update on this: Inputs and Outputs now show again (after 7d38654ecd) But following issue remains: For Inputs the node sockets draw incorrectly [for the very first in the list as well as for the currently **selected** Input]. For the currently selected they are actually drawn, but are overdrawn by the "row highlighting" (can check this by increasing their radius in code) If I change the python `NODE_UL_interface_sockets.draw_item` code to **first** draw the `prop` and then the `template_node_socket` it also draws correctly (thats why Outputs work fine) So there doesnt seem to be a problem in `uiTemplateNodeSocket` nor `ui_draw_but_NODESOCKET` [checked code as good as I could and everything seems fine there]. Instead I suspect (shot in the dark for now) either something going wrong with `uiTemplateList` and how `uiLayoutOverlap` is drawn in 2.8 or maybe something how the drawcalls get batched in 2.8? Will continue investigating [unless @fclem or @mont29 have an idea right away?]

Clément Foucault commented

2018-10-20 01:09:19 +02:00

Text is batched in order to reduce drawcalls count. You might have to flush the text draw cache in order to draw things in a specific order. See usage of BLF_batch_draw_flush().

I didn't look too much into this issue so it might be a shot in the dark too.

EDIT: Nevermind, it's not about text isn't it? It's too late I should sleep haha.

Text is batched in order to reduce drawcalls count. You might have to flush the text draw cache in order to draw things in a specific order. See usage of BLF_batch_draw_flush(). I didn't look too much into this issue so it might be a shot in the dark too. EDIT: Nevermind, it's not about text isn't it? It's too late I should sleep haha.

Brecht Van Lommel changed title from ~~node group input names not showing~~ to Node group input sockets not drawing in sidebar

2019-03-19 11:00:50 +01:00

Marco commented

2019-05-14 12:21:53 +02:00

Added subscriber: @nacioss

Marco commented

2019-05-14 12:21:53 +02:00

Changed status from 'Open' to: 'Resolved'

Marco closed this issue

2019-05-14 12:21:53 +02:00

Marco commented

2019-05-14 12:21:53 +02:00

It is working in 2.8 build of 2019-05-13

Philipp Oeser commented

2019-05-14 12:38:56 +02:00

Changed status from 'Resolved' to: 'Open'

Philipp Oeser reopened this issue

2019-05-14 12:38:56 +02:00

Philipp Oeser commented

2019-05-14 12:38:56 +02:00

In #57090#544313, @lichtwerk wrote:
Inputs and Outputs now show again (after 7d38654ecd)

But following issue remains:
For Inputs the node sockets draw incorrectly [for the very first in the list as well as for the currently selected Input].
For the currently selected they are actually drawn, but are overdrawn by the "row highlighting" (can check this by increasing their radius in code)
If I change the python NODE_UL_interface_sockets.draw_item code to first draw the prop and then the template_node_socket it also draws correctly (thats why Outputs work fine)

There is still the issue of dots/sockets drawn incorrectly, this isnt solved...

> In #57090#544313, @lichtwerk wrote: > Inputs and Outputs now show again (after 7d38654ecd) > > But following issue remains: > For Inputs the node sockets draw incorrectly [for the very first in the list as well as for the currently **selected** Input]. > For the currently selected they are actually drawn, but are overdrawn by the "row highlighting" (can check this by increasing their radius in code) > If I change the python `NODE_UL_interface_sockets.draw_item` code to **first** draw the `prop` and then the `template_node_socket` it also draws correctly (thats why Outputs work fine) There is still the issue of dots/sockets drawn incorrectly, this isnt solved...

blender-admin commented

2019-05-27 23:10:35 +02:00

This issue was referenced by b2b1aa2f8e

This issue was referenced by b2b1aa2f8ead62cb376342b11348fe8495ae736d

Philipp Oeser commented

2019-05-28 11:06:03 +02:00

OK, had a look at this again, and it turns out drawing actually works correctly when UI_widgetbase_draw_cache is disabled.
[to check this, just comment out UI_widgetbase_draw_cache_begin and UI_widgetbase_draw_cache_end in UI_block_draw]

To properly have the drawing code of ui_draw_but_NODESOCKET in the draw cache, it needs to be a widget as well, I guess.
(Otherwise it will still draw via ui_draw_but in UI_block_draw, but drawn over by the cached widgets immediately after)
(Only other possibility would be to flush the widget draw cache just for drawing this socket -- sounds like a bad choice to me...)

In D4963, I have "widgified" the drawing code of ui_draw_but_NODESOCKET.

OK, had a look at this again, and it turns out drawing actually works correctly when `UI_widgetbase_draw_cache` is disabled. [to check this, just comment out `UI_widgetbase_draw_cache_begin` and `UI_widgetbase_draw_cache_end` in `UI_block_draw`] To properly have the drawing code of `ui_draw_but_NODESOCKET` in the draw cache, it needs to be a widget as well, I guess. (Otherwise it will still draw via `ui_draw_but` in `UI_block_draw`, but drawn over by the cached widgets immediately after) (Only other possibility would be to flush the widget draw cache just for drawing this socket -- sounds like a bad choice to me...) In [D4963](https://archive.blender.org/developer/D4963), I have "widgified" the drawing code of `ui_draw_but_NODESOCKET`.

Philipp Oeser commented

2019-05-28 12:27:39 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-05-28 12:27:39 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node group input sockets not drawing in sidebar #57090