Assert when deleting duplicated collection (id->us == 0) #57288

New Issue

Dalai Felinto · 2018-10-18T01:29:56+02:00

Dalai Felinto commented

2018-10-18 01:29:56 +02:00

System Information
Operating system and graphics card

Blender Version
Broken: a2922f9840 (blender2.8 HEAD)
Worked: ?

Short description of error
Assert after removing duplicated collection.

Exact steps for others to reproduce the error

In the outliner duplicate the initial collection (i.e., Collection).
Now in the outliner still, select and delete this new collection.

BLI_assert failed: //source/blender/blenkernel/intern/library_remap.c:1010, BKE_libblock_delete(), at 'id->us == 0'

Full backtrace: P800

**System Information** Operating system and graphics card **Blender Version** Broken: a2922f98400c (blender2.8 HEAD) Worked: ? **Short description of error** Assert after removing duplicated collection. **Exact steps for others to reproduce the error** * In the outliner duplicate the initial collection (i.e., Collection). * Now in the outliner still, select and delete this new collection. `BLI_assert failed: //source/blender/blenkernel/intern/library_remap.c:1010, BKE_libblock_delete(), at 'id->us == 0'` Full backtrace: [P800](https://archive.blender.org/developer/P800.txt)

Dalai Felinto commented

2018-10-18 01:29:57 +02:00

Added subscriber: @dfelinto

Brecht Van Lommel was assigned by Dalai Felinto

2018-10-18 01:31:27 +02:00

Dalai Felinto commented

2018-10-18 01:31:27 +02:00

Added subscriber: @brecht

Dalai Felinto commented

2018-10-18 01:31:27 +02:00

@brecht I can look at it on Friday, if you don't tackle it by then.

Dalai Felinto commented

2018-10-18 01:48:17 +02:00

Added subscriber: @mont29

Dalai Felinto commented

2018-10-18 01:48:17 +02:00

Actually @mont29 what is the point of this assert? The if almost suggest we expect to get there. Unless it is there just for the convenience of the debug print:

if (id->us != 0) {
#ifdef DEBUG_PRINT
    printf("%s: deleting %s (%d)\n", __func__, id->name, id->us);
#endif
    BLI_assert(id->us == 0);
}

Actually @mont29 what is the point of this assert? The if almost suggest we expect to get there. Unless it is there just for the convenience of the debug print: ``` if (id->us != 0) { #ifdef DEBUG_PRINT printf("%s: deleting %s (%d)\n", __func__, id->name, id->us); #endif BLI_assert(id->us == 0); } ```

Brecht Van Lommel was unassigned by Bastien Montagne

2018-10-22 13:51:25 +02:00

Bastien Montagne self-assigned this 2018-10-22 13:51:25 +02:00

Bastien Montagne commented

2018-10-22 13:51:25 +02:00

@dfelinto ideally this should never happen anymore… but currently 'just' asserting because it's not always critical issue and we can survive it (so not worth killing release Blender over it)

That’s most likely some missing ID pointer handling somewhere, will check.

@dfelinto ideally this should never happen anymore… but currently 'just' asserting because it's not always critical issue and we can survive it (so not worth killing release Blender over it) That’s most likely some missing ID pointer handling somewhere, will check.

blender-admin commented

2018-10-23 11:59:53 +02:00

This issue was referenced by f927f388f6

This issue was referenced by f927f388f6608cb802b489907ef0c280607d900c

Bastien Montagne commented

2018-10-23 12:02:59 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2018-10-23 12:02:59 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Assert when deleting duplicated collection (id->us == 0) #57288