Material preview icons not updating #57316

New Issue

John Reed · 2018-10-20T03:48:25+02:00

John Reed commented

2018-10-20 03:48:25 +02:00

when adding multiple materials in Eevee the icons remain grey no matter if I choose different colors or not.
also, the material preview seems to be not working correctly...sometimes shows material, sometimes doesn't.
Thanks,
J.Reed

when adding multiple materials in Eevee the icons remain grey no matter if I choose different colors or not. also, the material preview seems to be not working correctly...sometimes shows material, sometimes doesn't. Thanks, J.Reed

John Reed commented

2018-10-20 03:48:25 +02:00

Added subscriber: @JohnReed

blender-admin commented

2018-10-20 03:48:25 +02:00

#57555 was marked as duplicate of this issue

Antonio Vazquez commented

2018-10-20 11:09:30 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2018-10-20 11:09:30 +02:00

I can confirm in Windows that icons keep gray. Not sure if this is done by design or not.

The preview works.

I can confirm in Windows that icons keep gray. Not sure if this is done by design or not. ![image.png](https://archive.blender.org/developer/F5151784/image.png) The preview works.

Philipp Oeser commented

2018-10-22 11:21:25 +02:00

Added subscribers: @brecht, @lichtwerk

Philipp Oeser commented

2018-10-22 11:21:25 +02:00

Same here (cycles, eevee, materials defined for OpenGl render engine dont get icons at all...), before digging deeper: @brecht: this is not by design, right?

Brecht Van Lommel changed title from ~~Material Icons All Grey~~ to Material preview icons not updating

2018-10-22 17:33:55 +02:00

Brecht Van Lommel commented

2018-10-22 17:40:31 +02:00

The icons don't seem to be getting updated at all, they display in colors fine for existing files.

Antonio Vazquez commented

2018-10-31 22:15:08 +01:00

These changes do the trick, but maybe they are totally wrong:

diff --git a/source/blender/editors/space_node/node_draw.c b/source/blender/editors/space_node/node_draw.c
index f00b745..0c80568 100644
--- a/source/blender/editors/space_node/node_draw.c
+++ b/source/blender/editors/space_node/node_draw.c
@@ -140,8 +140,14 @@ void ED_node_tag_update_id(ID *id)
 	if (ntree->type == NTREE_SHADER) {
 		DEG_id_tag_update(id, 0);
 
-		if (GS(id->name) == ID_MA)
+		if (GS(id->name) == ID_MA) {
+			Material *ma = (Material *)id;
+			PreviewImage *preview = ma->preview;
+			if ((preview->flag[ICON_SIZE_ICON] & PRV_CHANGED) == 0) {
+				preview->flag[ICON_SIZE_ICON] |= PRV_CHANGED;
+			}
 			WM_main_add_notifier(NC_MATERIAL | ND_SHADING, id);
+		}
 		else if (GS(id->name) == ID_LA)
 			WM_main_add_notifier(NC_LAMP | ND_LIGHTING, id);
 		else if (GS(id->name) == ID_WO)
diff --git a/source/blender/makesrna/intern/rna_material.c b/source/blender/makesrna/intern/rna_material.c
index a842513..091f551 100644
--- a/source/blender/makesrna/intern/rna_material.c
+++ b/source/blender/makesrna/intern/rna_material.c
@@ -151,6 +151,11 @@ static void rna_Material_draw_update(Main *UNUSED(bmain), Scene *UNUSED(scene),
 {
 	Material *ma = ptr->id.data;
 
+	PreviewImage *preview = ma->preview;
+	if ((preview->flag[ICON_SIZE_ICON] & PRV_CHANGED) == 0) {
+		preview->flag[ICON_SIZE_ICON] |= PRV_CHANGED;
+	}
+
 	DEG_id_tag_update(&ma->id, DEG_TAG_COPY_ON_WRITE);
 	WM_main_add_notifier(NC_MATERIAL | ND_SHADING_DRAW, ma);
 }

The problem is the icon preview is not set to update. The changes in node_draw.c are for materials using nodes. The changes in rna_material.c for materials not using nodes.

@brecht Could you take a look?

These changes do the trick, but maybe they are totally wrong: ``` diff --git a/source/blender/editors/space_node/node_draw.c b/source/blender/editors/space_node/node_draw.c index f00b745..0c80568 100644 --- a/source/blender/editors/space_node/node_draw.c +++ b/source/blender/editors/space_node/node_draw.c @@ -140,8 +140,14 @@ void ED_node_tag_update_id(ID *id) if (ntree->type == NTREE_SHADER) { DEG_id_tag_update(id, 0); - if (GS(id->name) == ID_MA) + if (GS(id->name) == ID_MA) { + Material *ma = (Material *)id; + PreviewImage *preview = ma->preview; + if ((preview->flag[ICON_SIZE_ICON] & PRV_CHANGED) == 0) { + preview->flag[ICON_SIZE_ICON] |= PRV_CHANGED; + } WM_main_add_notifier(NC_MATERIAL | ND_SHADING, id); + } else if (GS(id->name) == ID_LA) WM_main_add_notifier(NC_LAMP | ND_LIGHTING, id); else if (GS(id->name) == ID_WO) diff --git a/source/blender/makesrna/intern/rna_material.c b/source/blender/makesrna/intern/rna_material.c index a842513..091f551 100644 --- a/source/blender/makesrna/intern/rna_material.c +++ b/source/blender/makesrna/intern/rna_material.c @@ -151,6 +151,11 @@ static void rna_Material_draw_update(Main *UNUSED(bmain), Scene *UNUSED(scene), { Material *ma = ptr->id.data; + PreviewImage *preview = ma->preview; + if ((preview->flag[ICON_SIZE_ICON] & PRV_CHANGED) == 0) { + preview->flag[ICON_SIZE_ICON] |= PRV_CHANGED; + } + DEG_id_tag_update(&ma->id, DEG_TAG_COPY_ON_WRITE); WM_main_add_notifier(NC_MATERIAL | ND_SHADING_DRAW, ma); } ``` The problem is the icon preview is not set to update. The changes in node_draw.c are for materials using nodes. The changes in rna_material.c for materials not using nodes. @brecht Could you take a look?

Philipp Oeser commented

2018-11-01 12:20:45 +01:00

Added subscriber: @Kent-Davis

Kent Davis commented

2018-11-01 12:45:46 +01:00

MacOS 10.14.1
5K 27" 2017

I am use SecondLife and OSGRid. Object cube is 6 faces (6 Materials) export to collada .dae then import collada on Blender 2.79b it work few weeks ago.
I follow exactly.

Blender 2.79b render preview it work. I am use 7 Materials then texture each materials.
Blender 2.80 render preview not work.
https://imgur.com/a/jZ1or01
https://imgur.com/a/VLk5uok

File: fancyMailBox.zip (Can help you can found between Blender 2.79b it work but Blender 2.80 not work.)
fancyMailBox.zip

MacOS 10.14.1 5K 27" 2017 I am use SecondLife and OSGRid. Object cube is 6 faces (6 Materials) export to collada .dae then import collada on Blender 2.79b it work few weeks ago. I follow exactly. Blender 2.79b render preview it work. I am use 7 Materials then texture each materials. Blender 2.80 render preview not work. https://imgur.com/a/jZ1or01 https://imgur.com/a/VLk5uok File: fancyMailBox.zip (Can help you can found between Blender 2.79b it work but Blender 2.80 not work.) [fancyMailBox.zip](https://archive.blender.org/developer/F5322262/fancyMailBox.zip)

Philipp Oeser commented

2018-11-01 12:58:42 +01:00

@Kent-Davis : no need to post here again, your original report was merged and is visible from here to everyone interested.

Kent Davis commented

2018-11-01 13:14:30 +01:00

Really that is great merged I never see that one before. You did great job.

Brecht Van Lommel commented

2018-11-01 14:23:44 +01:00

@antoniov, this is not the right fix. It's setting the preview to be refreshed in two places, but it should be handled in a more generic way. It seems grease pencil is also doing this manual update in RNA which is wrong too.

The depsgraph is supposed to call ED_render_id_flush_update, which will tag the icons to be refreshed. I'll commit a fix.

@antoniov, this is not the right fix. It's setting the preview to be refreshed in two places, but it should be handled in a more generic way. It seems grease pencil is also doing this manual update in RNA which is wrong too. The depsgraph is supposed to call `ED_render_id_flush_update`, which will tag the icons to be refreshed. I'll commit a fix.

Brecht Van Lommel commented

2018-11-01 14:29:43 +01:00

Added subscriber: @Sergey

Brecht Van Lommel commented

2018-11-01 14:29:43 +01:00

Actually I need @Sergey's help. This is the patch I have: P813.

The problem is that it is refreshing icons everytime the file is loaded, which is a serious performance issue on complex scenes. We need to detect which datablocks have been edited by the users, not all datablocks to be updated by the depsgraph.

Actually I need @Sergey's help. This is the patch I have: [P813](https://archive.blender.org/developer/P813.txt). The problem is that it is refreshing icons everytime the file is loaded, which is a serious performance issue on complex scenes. We need to detect which datablocks have been edited by the users, not all datablocks to be updated by the depsgraph.

blender-admin commented

2018-11-02 16:02:46 +01:00

This issue was referenced by 3e5483ffe1

This issue was referenced by 3e5483ffe10567731e3e84bb6f9ccc6ba1cdbce8

Brecht Van Lommel commented

2018-11-02 16:54:43 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2018-11-02 16:54:43 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Material preview icons not updating #57316