Data is not evaluated for grease pencil VFX in render animation but works in viewport #57484

New Issue

Antonio Vazquez · 2018-10-29T10:22:15+01:00

Antonio Vazquez commented

2018-10-29 10:22:15 +01:00

If you add a VFX and animate any property or add any depsgraph related object (for example the location of one object to manage VFX), the data is evaluated in viewport, but when render the data is not evaluated.

To reproduce:

Open attached file
Move timeline current frame. The VFX works.
Render one frame (F12)->works
Render animation. (Ctrl+F12)->All frames are equal.

DEPSGRAP_FX.blend

If you add a VFX and animate any property or add any depsgraph related object (for example the location of one object to manage VFX), the data is evaluated in viewport, but when render the data is not evaluated. To reproduce: 1) Open attached file 2) Move timeline current frame. The VFX works. 3) Render one frame (F12)->works 4) Render animation. (Ctrl+F12)->All frames are equal. [DEPSGRAP_FX.blend](https://archive.blender.org/developer/F5281495/DEPSGRAP_FX.blend)

Antonio Vazquez commented

2018-10-29 10:22:15 +01:00

Added subscriber: @antoniov

blender-admin commented

2018-10-29 10:22:15 +01:00

#58285 was marked as duplicate of this issue

Philipp Oeser commented

2018-10-29 11:06:38 +01:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2018-10-29 11:06:38 +01:00

Philipp Oeser commented

2018-10-29 11:06:38 +01:00

Confirmed, will have a look.

Philipp Oeser removed their assignment 2018-10-30 16:42:11 +01:00

Sergey Sharybin was assigned by Philipp Oeser

2018-10-30 16:42:11 +01:00

Philipp Oeser commented

2018-10-30 16:42:11 +01:00

Added subscriber: @Sergey

Philipp Oeser commented

2018-10-30 16:42:11 +01:00

Well, did some reading, but no solution within time constraints...
Getting this:
add_node_handle_relation(Swirl ShaderFx) - Could not find op_from (ComponentKey(OBEmpty, 8, ''))

Would kindly ask @Sergey to take over...

Well, did some reading, but no solution within time constraints... Getting this: `add_node_handle_relation(Swirl ShaderFx) - Could not find op_from (ComponentKey(OBEmpty, 8, ''))` Would kindly ask @Sergey to take over...

Antonio Vazquez commented

2018-10-30 20:15:20 +01:00

@lichtwerk I get this console warning sometimes in modifiers and vfx that use an object (wave, light, etc..) no idea why and when the warning is produced.

Philipp Oeser commented

2018-11-30 11:24:33 +01:00

Added subscriber: @BerbankGreen

Sergey Sharybin removed their assignment 2019-01-29 15:46:46 +01:00

Antonio Vazquez was assigned by Sergey Sharybin

2019-01-29 15:46:46 +01:00

Sergey Sharybin commented

2019-01-29 15:46:46 +01:00

I've committed 33dcf9fa which solves some of the aspects of this bug. The rest goes deeper in roots of grease pencil design, which violates the render/viewport data separation

@antoniov, you should never go from evaluated to original object when rendering (aka in draw manager). The only case when it's OK is when object is in edit or sculpt/paint mode (where some data is still local, but the paint session is shared). Without following this rule you'll never have reliable and stable animation playing.

If you remove all DEG_get_original_id from draw manager this bug will be solved.

For the performance of drawing follow similar way as sculpting/particle edit mode: allow sharing data between evaluated and original object when in paint mode. Fort all the rest keep clear separation, and never change the "domain" (original <-> evaluated).

I've committed 33dcf9fa which solves some of the aspects of this bug. The rest goes deeper in roots of grease pencil design, which violates the render/viewport data separation @antoniov, you should never go from evaluated to original object when rendering (aka in draw manager). The only case when it's OK is when object is in edit or sculpt/paint mode (where some data is still local, but the paint session is shared). Without following this rule you'll never have reliable and stable animation playing. If you remove all `DEG_get_original_id` from draw manager this bug will be solved. For the performance of drawing follow similar way as sculpting/particle edit mode: allow sharing data between evaluated and original object when in paint mode. Fort all the rest keep clear separation, and never change the "domain" (original <-> evaluated).

Antonio Vazquez commented

2019-01-29 17:25:52 +01:00

@Sergey I have done the change (remove any <DEG_get_original_id>) in greasepencil object branch to test the draw manager. If all works fine, I will move the change to master.

I only keep this in drawing because use the evaluated takes a lot of time (I had to change this some time ago due performance problems), but it's only in a logic place.

@Sergey I have done the change (remove any <DEG_get_original_id>) in greasepencil object branch to test the draw manager. If all works fine, I will move the change to master. I only keep this in drawing because use the evaluated takes a lot of time (I had to change this some time ago due performance problems), but it's only in a logic place.

Antonio Vazquez commented

2019-01-30 16:37:05 +01:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2019-01-30 16:37:05 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Data is not evaluated for grease pencil VFX in render animation but works in viewport #57484