Quit messagebox is hidden when exit with Fullscreen mode enabled #57648

Closed
opened 2018-11-06 11:31:59 +01:00 by Antonio Vazquez · 12 comments

Windows 10 - Last version compiled

This maybe cannot be considered a bug, but I open this task to review it.

If you enable the Fullscreen mode and after making some changes select Quit in the menu, Blender looks frozen, but the problem is the Messagebox is hidden.

image.png

Really, it's not a bug, but for sure a lot of users will think Blender is locked.

Windows 10 - Last version compiled This maybe cannot be considered a bug, but I open this task to review it. If you enable the Fullscreen mode and after making some changes select Quit in the menu, Blender looks frozen, but the problem is the Messagebox is hidden. ![image.png](https://archive.blender.org/developer/F5406706/image.png) Really, it's not a bug, but for sure a lot of users will think Blender is locked.
Author
Member

Added subscriber: @antoniov

Added subscriber: @antoniov
Author
Member

Doing some research, it looks is not easy to make the messagebox to be on top of all in all situations.

Maybe, someone that know Ghost modules, could force the Fullscreen off in this situation.... it's only a idea.

Doing some research, it looks is not easy to make the messagebox to be on top of all in all situations. Maybe, someone that know Ghost modules, could force the Fullscreen off in this situation.... it's only a idea.
Member

Added subscribers: @LazyDodo, @lichtwerk

Added subscribers: @LazyDodo, @lichtwerk
Member

Since this is windows (only?), maybe @LazyDodo knows?

Since this is windows (only?), maybe @LazyDodo knows?
Member

you can pass MB_TOPMOST to the messagebox function and it'll be topmost, however i'd prefer we'd land D3118 which gets rid of the OS specific messagebox all together

you can pass MB_TOPMOST to the messagebox function and it'll be topmost, however i'd prefer we'd land [D3118](https://archive.blender.org/developer/D3118) which gets rid of the OS specific messagebox all together
Author
Member

@LazyDodo The Messagebox is already using MB_TOPMOST

return (MessageBox(window ? ((GHOST_WindowWin32 *)window)->getHWND() : 0, "Some changes have not been saved.\nDo you really want to quit?",
	                   "Exit Blender", MB_OKCANCEL | MB_ICONWARNING | MB_TOPMOST) == IDOK);

The thing is this code is working in 2.79, in 2.80 doesn't

I think your solution of using a general fix for all OS is better.

@LazyDodo The Messagebox is already using MB_TOPMOST ``` return (MessageBox(window ? ((GHOST_WindowWin32 *)window)->getHWND() : 0, "Some changes have not been saved.\nDo you really want to quit?", "Exit Blender", MB_OKCANCEL | MB_ICONWARNING | MB_TOPMOST) == IDOK); ``` The thing is this code is working in 2.79, in 2.80 doesn't I think your solution of using a general fix for all OS is better.
Member

Added subscriber: @brecht

Added subscriber: @brecht
Member

@brecht wants to add some feature to D3118 which could be a bit, so we still might have to look into fixing this ;/

perhaps adding MB_SETFOREGROUND will do the trick?

@brecht wants to add some feature to [D3118](https://archive.blender.org/developer/D3118) which could be a bit, so we still might have to look into fixing this ;/ perhaps adding `MB_SETFOREGROUND` will do the trick?
Author
Member

I have tested adding MB_SETFOREGROUND flag and gets the same result. I tried

  1. "MB_OKCANCEL | MB_ICONWARNING | MB_TOPMOST | MB_SETFOREGROUND"

and

  1. "MB_OKCANCEL | MB_ICONWARNING | MB_SETFOREGROUND"

with the same result

I have tested adding MB_SETFOREGROUND flag and gets the same result. I tried 1) "MB_OKCANCEL | MB_ICONWARNING | MB_TOPMOST | MB_SETFOREGROUND" and 2) "MB_OKCANCEL | MB_ICONWARNING | MB_SETFOREGROUND" with the same result
Member

did some googling, this seems to be the same issue, but yikes, looks messy.

did some googling, [this ](https://stackoverflow.com/questions/2378918/modal-dialogs-opened-by-a-fullscreen-opengl-window-on-windows-7-are-not-showing) seems to be the same issue, but yikes, looks messy.

This issue was referenced by c6d1ae2f8a

This issue was referenced by c6d1ae2f8aa246c009e3cbace0ab0860be8acf3a

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#57648
No description provided.