Culling of smoke depending on view direction #57678

New Issue

Mal Duffin · 2018-11-07T15:56:06+01:00

Mal Duffin commented

2018-11-07 15:56:06 +01:00

System Information
Windows 10, GTX 1070

Blender Version
Broken: Blender 2.8 Alpha 2 7b271d5fc1

Short description of error
The smoke itself seems to disappear, depending on the rotation of the viewport.

Exact steps for others to reproduce the error

Load up the attached .blend file
Shift A to play the smoke ( let the timeline loop, takes a few seconds, in order to build the smoke sim )

After the first timeline loop, all 4 spheres are emitting smoke, but may not look like it.

Rotate the viewport to see from above the wireframe cube ( smoke domain )

You will see all 4 spheres emitting smoke.

Rotate around the cube, and you'll see that the smoke disappears for some of the spheres depending on the angle of viewing.

The smoke from all 4 spheres should always be visible from all angles.

smoke_culling_bug.blend

Note that the culling happens with just one sphere, having more spheres helps improve the possibility that one of them will be visible.

**System Information** Windows 10, GTX 1070 **Blender Version** Broken: Blender 2.8 Alpha 2 7b271d5fc11 **Short description of error** The smoke itself seems to disappear, depending on the rotation of the viewport. **Exact steps for others to reproduce the error** 1) Load up the attached .blend file 2) Shift A to play the smoke ( let the timeline loop, takes a few seconds, in order to build the smoke sim ) After the first timeline loop, all 4 spheres are emitting smoke, but may not look like it. 3) Rotate the viewport to see from above the wireframe cube ( smoke domain ) You will see all 4 spheres emitting smoke. 4) Rotate around the cube, and you'll see that the smoke disappears for some of the spheres depending on the angle of viewing. The smoke from all 4 spheres should always be visible from all angles. [smoke_culling_bug.blend](https://archive.blender.org/developer/F5426933/smoke_culling_bug.blend) Note that the culling happens with just one sphere, having more spheres helps improve the possibility that one of them will be visible. ![image.png](https://archive.blender.org/developer/F5427158/image.png) ![image.png](https://archive.blender.org/developer/F5427165/image.png) ![image.png](https://archive.blender.org/developer/F5427177/image.png) ![image.png](https://archive.blender.org/developer/F5427184/image.png)

Mal Duffin commented

2018-11-07 15:56:06 +01:00

Added subscriber: @MalDuffin

Mal Duffin commented

2018-11-07 16:27:40 +01:00

If I change the camera clip start, it has an effect on the visibility of the smoke.

If I change the camera clip start, it has an effect on the visibility of the smoke. ![image.png](https://archive.blender.org/developer/F5427208/image.png) ![image.png](https://archive.blender.org/developer/F5427217/image.png) ![image.png](https://archive.blender.org/developer/F5427223/image.png)

Philipp Oeser commented

2018-11-08 11:14:08 +01:00

Added subscribers: @fclem, @lichtwerk

Clément Foucault was assigned by Philipp Oeser

2018-11-08 11:14:08 +01:00

Philipp Oeser commented

2018-11-08 11:14:08 +01:00

@fclem : not sure about smoke in regards to #56352 (atm. smoke also doesnt appear in lookdev/rendered view/ F12 render btw.), but can confirm the display weirdness...
[I am on a nvidia 970m btw.]

@fclem : not sure about smoke in regards to #56352 (atm. smoke also doesnt appear in lookdev/rendered view/ F12 render btw.), but can confirm the display weirdness... [I am on a nvidia 970m btw.]

Clément Foucault commented

2018-11-08 14:50:01 +01:00

I can confirm too. I will fix it soon.

blender-admin commented

2018-11-12 21:14:51 +01:00

This issue was referenced by 6ba7345ca5

This issue was referenced by 6ba7345ca5393077dddbfaa48651a209b23e9bd0

Clément Foucault commented

2018-11-12 21:19:03 +01:00

Changed status from 'Open' to: 'Resolved'

Clément Foucault closed this issue

2018-11-12 21:19:03 +01:00

Mal Duffin commented

2018-11-12 23:52:46 +01:00

Hi Clément,

I tested with the old scene, but it had the same old issue.

However, when I create the scene from scratch it works - but if I then scale the box used for the domain ( s 10 ), then I see the same issue again.

Try these steps.

New Scene
With the default cube selected, open the Physics panel
Select Smoke, then Domain type
Shift A and add a UV Sphere
In the Physics Panel, select Smoke, then Flow
Reselect the Domain cube, and scale it by eg 10

Shift + SPACE and let the timeline run a complete loop, then rotate around the cube to see the issue.

Hi Clément, I tested with the old scene, but it had the same old issue. However, when I create the scene from scratch it works - but if I then scale the box used for the domain ( s 10 ), then I see the same issue again. Try these steps. 1) New Scene 2) With the default cube selected, open the Physics panel 3) Select Smoke, then Domain type 4) Shift A and add a UV Sphere 5) In the Physics Panel, select Smoke, then Flow 6) Reselect the Domain cube, and scale it by eg 10 Shift + SPACE and let the timeline run a complete loop, then rotate around the cube to see the issue.

Clément Foucault commented

2018-11-13 00:28:30 +01:00

@MalDuffin what's the build number? the buildbot are only updating around 1am. So you might have tested an old build without the fix.

Mal Duffin commented

2018-11-13 09:23:51 +01:00

I had tried to build locally, but I was getting a crash - and did indeed download the latest BuildBot build, which didn't seem to have the commit.

The crash is related to your commit ( https://lists.blender.org/pipermail/bf-blender-cvs/2018-November/116145.html ), see the call stack below ( mutex is null, the crash occurs on BLI_mutex_unlock ).

If I revert that commit and rebuild, the smoke works as expected - nice one!

I had tried to build locally, but I was getting a crash - and did indeed download the latest BuildBot build, which didn't seem to have the commit. The crash is related to your commit ( https://lists.blender.org/pipermail/bf-blender-cvs/2018-November/116145.html ), see the call stack below ( mutex is null, the crash occurs on BLI_mutex_unlock ). ![image.png](https://archive.blender.org/developer/F5528470/image.png) If I revert that commit and rebuild, the smoke works as expected - nice one!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Culling of smoke depending on view direction #57678