Blender 2.8 Crashes when I click on undo and redo while working with image or image empty #57889

New Issue

Judah King · 2018-11-17T09:36:11+01:00

Judah King commented

2018-11-17 09:36:11 +01:00

System Information
Windows 10 Pro 64Bit
Intel(R) Core(TM) i3-4005U CPU @ 1.70GHz, Intel® HD Graphics 4400 (Integrated)
8 GB RAM
Geforce nvidia 820m 2GB (Discrete GPU)
system-info.txt

Blender Version
Broken: Blender 2.80.31 2c347ebbba
Worked: (optional)

Short description of error
Blender Crashes When I click on undo and redo while working with image or image empty.

Exact steps for others to reproduce the error

Opened Blender
Added an Image from Add Menu, Add > Image or Add > Empty > Image
Scaled the Image
Then I clicked "Ctrl + Z = undo, Ctrl + Shift + Z = redo"
Blender crashed
Here is the blend file.
Burger.blend

Based on a (as simple as possible) attached .blend file with minimum amount of steps

**System Information** Windows 10 Pro 64Bit Intel(R) Core(TM) i3-4005U CPU @ 1.70GHz, Intel® HD Graphics 4400 (Integrated) 8 GB RAM Geforce nvidia 820m 2GB (Discrete GPU) [system-info.txt](https://archive.blender.org/developer/F5598241/system-info.txt) **Blender Version** Broken: Blender 2.80.31 2c347ebbba9 Worked: (optional) **Short description of error** Blender Crashes When I click on undo and redo while working with image or image empty. **Exact steps for others to reproduce the error** 1. Opened Blender 2. Added an Image from Add Menu, Add > Image or Add > Empty > Image 3. Scaled the Image 4. Then I clicked "Ctrl + Z = undo, Ctrl + Shift + Z = redo" 5. Blender crashed Here is the blend file. [Burger.blend](https://archive.blender.org/developer/F5598214/Burger.blend) Based on a (as simple as possible) attached .blend file with minimum amount of steps

Judah King commented

2018-11-17 09:36:11 +01:00

Added subscriber: @JoeRex

blender-admin commented

2018-11-17 09:36:11 +01:00

#57943 was marked as duplicate of this issue

blender-admin commented

2018-11-17 09:36:11 +01:00

#57942 was marked as duplicate of this issue

blender-admin commented

2018-11-17 09:36:11 +01:00

#57882 was marked as duplicate of this issue

blender-admin commented

2018-11-17 09:36:11 +01:00

#57916 was marked as duplicate of this issue

blender-admin commented

2018-11-17 09:36:11 +01:00

#57899 was marked as duplicate of this issue

blender-admin commented

2018-11-17 09:36:11 +01:00

#57886 was marked as duplicate of this issue

William Reynish commented

2018-11-17 17:15:52 +01:00

Added subscriber: @WilliamReynish

William Reynish commented

2018-11-17 17:15:52 +01:00

I can reproduce this crash consistently, yes.

Philipp Oeser commented

2018-11-19 09:57:12 +01:00

Added subscriber: @lichtwerk

Sergey Sharybin was assigned by Philipp Oeser

2018-11-19 09:57:12 +01:00

Philipp Oeser commented

2018-11-19 09:57:12 +01:00

Can confirm, getting

add_relation(Eval Order) - Could not find op_from (OperationKey(type: COPY_ON_WRITE, component name: '', operation code: COPY_ON_WRITE))
add_relation(Eval Order) - Failed, but op_to (OperationKey(type: COPY_ON_WRITE, component name: '', operation code: COPY_ON_WRITE)) was ok

looks like it's caused by 33ac6c25b9, add_relation returns NULL, just checking for that survives (see P825)

backtrace when doing the redo steps provided:

1  DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2496 0x2f09881 
2  DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2342 0x2f09333 
3  DEG_graph_build_from_view_layer                              depsgraph_build.cc       259  0x2ee655c 
4  DEG_graph_relations_update                                   depsgraph_build.cc       320  0x2ee6763 
5  BKE_scene_graph_update_tagged                                scene.c                  1419 0x2b5f29e 
6  wm_event_do_depsgraph                                        wm_event_system.c        334  0x1c4941c 
7  wm_event_do_refresh_wm_and_depsgraph                         wm_event_system.c        359  0x1c49501

backtrace when opening provided file:

1   DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2496 0x2f09881 
2   DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2342 0x2f09333 
3   DEG_graph_build_from_view_layer                              depsgraph_build.cc       259  0x2ee655c 
4   DEG_graph_relations_update                                   depsgraph_build.cc       320  0x2ee6763 
5   BKE_scene_graph_update_tagged                                scene.c                  1419 0x2b5f29e 
6   wm_event_do_depsgraph                                        wm_event_system.c        334  0x1c4941c 
7   wm_file_read_post                                            wm_files.c               492  0x1c549b3 
8   WM_file_read                                                 wm_files.c               633  0x1c54d73 
9   wm_file_read_opwrap                                          wm_files.c               1821 0x1c5784c 
10  wm_open_mainfile_exec                                        wm_files.c               1881 0x1c57aad

Can confirm, getting ``` add_relation(Eval Order) - Could not find op_from (OperationKey(type: COPY_ON_WRITE, component name: '', operation code: COPY_ON_WRITE)) add_relation(Eval Order) - Failed, but op_to (OperationKey(type: COPY_ON_WRITE, component name: '', operation code: COPY_ON_WRITE)) was ok ``` looks like it's caused by 33ac6c25b9, add_relation returns NULL, just checking for that survives (see [P825](https://archive.blender.org/developer/P825.txt)) backtrace when doing the redo steps provided: ``` 1 DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2496 0x2f09881 2 DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2342 0x2f09333 3 DEG_graph_build_from_view_layer depsgraph_build.cc 259 0x2ee655c 4 DEG_graph_relations_update depsgraph_build.cc 320 0x2ee6763 5 BKE_scene_graph_update_tagged scene.c 1419 0x2b5f29e 6 wm_event_do_depsgraph wm_event_system.c 334 0x1c4941c 7 wm_event_do_refresh_wm_and_depsgraph wm_event_system.c 359 0x1c49501 ``` backtrace when opening provided file: ``` 1 DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2496 0x2f09881 2 DEG::DepsgraphRelationBuilder::build_copy_on_write_relations deg_builder_relations.cc 2342 0x2f09333 3 DEG_graph_build_from_view_layer depsgraph_build.cc 259 0x2ee655c 4 DEG_graph_relations_update depsgraph_build.cc 320 0x2ee6763 5 BKE_scene_graph_update_tagged scene.c 1419 0x2b5f29e 6 wm_event_do_depsgraph wm_event_system.c 334 0x1c4941c 7 wm_file_read_post wm_files.c 492 0x1c549b3 8 WM_file_read wm_files.c 633 0x1c54d73 9 wm_file_read_opwrap wm_files.c 1821 0x1c5784c 10 wm_open_mainfile_exec wm_files.c 1881 0x1c57aad ```

Philipp Oeser commented

2018-11-19 09:58:58 +01:00

Added subscriber: @candreacchio