Crash updating grease pencil material preview #57896

New Issue

Antonio Vazquez · 2018-11-17T19:46:11+01:00

Antonio Vazquez commented

2018-11-17 19:46:11 +01:00

Last Daily Build and tested with last source code
Windows 10 64 bits

Since several days, if you add a grease pencil object and select the material tab, get a segment fault.

The grease pencil code has not been changed in last days and the error looks related to BKE_material_copy_data() function.

It looks the material->gp_style get damaged and set to NaN. The NaN value of this variable can produce crashes in lot of places. I think the task #57867 is related to this too.

To reproduce:

Start Blender with General template
Add GP object->Stroke
Select material tab
Crash

The crash also happens adding a material.

This is the crash log:

memcpy() Line 408	Unknown
MEM_lockfree_dupallocN(const void * vmemh) Line 190
BKE_material_copy_data(Main * bmain, Material * ma_dst, const Material * ma_src, const int flag) Line 210
BKE_id_copy_ex(Main * bmain, const ID * id, ID * * r_newid, const int flag, const bool test) Line 586
DEG::anonymous namespace'::id_copy_inplace_no_main(const ID * id, ID * newid) Line 280
DEG::deg_expand_copy_on_write_datablock(const DEG::Depsgraph * depsgraph, const DEG::IDDepsNode * id_node, DEG::DepsgraphNodeBuilder * node_builder, bool create_placeholders) Line 731
DEG::deg_update_copy_on_write_datablock(const DEG::Depsgraph * depsgraph, const DEG::IDDepsNode * id_node) Line 945
DEG::deg_evaluate_copy_on_write(Depsgraph * graph, const DEG::IDDepsNode * id_node) Line 1096

@lichtwerk Could you take a look? it looks the problem is not the grease pencil code, but some change done in how the objects are duplicated.

Last Daily Build and tested with last source code Windows 10 64 bits Since several days, if you add a grease pencil object and select the material tab, get a segment fault. The grease pencil code has not been changed in last days and the error looks related to BKE_material_copy_data() function. It looks the material->gp_style get damaged and set to NaN. The NaN value of this variable can produce crashes in lot of places. I think the task #57867 is related to this too. **To reproduce:** * Start Blender with General template * Add GP object->Stroke * Select material tab * Crash The crash also happens adding a material. This is the crash log: ``` memcpy() Line 408 Unknown MEM_lockfree_dupallocN(const void * vmemh) Line 190 BKE_material_copy_data(Main * bmain, Material * ma_dst, const Material * ma_src, const int flag) Line 210 BKE_id_copy_ex(Main * bmain, const ID * id, ID * * r_newid, const int flag, const bool test) Line 586 DEG::anonymous namespace'::id_copy_inplace_no_main(const ID * id, ID * newid) Line 280 DEG::deg_expand_copy_on_write_datablock(const DEG::Depsgraph * depsgraph, const DEG::IDDepsNode * id_node, DEG::DepsgraphNodeBuilder * node_builder, bool create_placeholders) Line 731 DEG::deg_update_copy_on_write_datablock(const DEG::Depsgraph * depsgraph, const DEG::IDDepsNode * id_node) Line 945 DEG::deg_evaluate_copy_on_write(Depsgraph * graph, const DEG::IDDepsNode * id_node) Line 1096 ``` @lichtwerk Could you take a look? it looks the problem is not the grease pencil code, but some change done in how the objects are duplicated.

Antonio Vazquez commented

2018-11-17 19:46:11 +01:00

Added subscribers: @lichtwerk, @antoniov