Node Editor: Some nodes lack red line when muted #58508

New Issue

Michael P. · 2018-12-02T12:32:44+01:00

Michael P. commented

2018-12-02 12:32:44 +01:00

Node Editor: Some nodes lack red line when muted

System Information
System: Windows 7 64bit
RAM: 4096 MB
renderer: 'GeForce GTX 760/PCIe/SSE2'
vendor: 'NVIDIA Corporation'
version: '4.5.0 NVIDIA 364.72'

Blender Version
Broken: blender-2.80.0-git.0f5b53ba4dc-windows64

Short description of error
Node Editor: Some nodes lack red line when muted

Exact steps for others to reproduce the error

Open the node editor
Add nodes from the screenshots
Press "M" to mute them
Some nodes have the red crossed through line, others don't

Expected:

Should be consistent (even if it's not a bug)
I can't tell which node is muted and which ones are not
I didn't find any indication in the properties either,
and the changed colors of the node header don't tell anything

Node Editor: Some nodes lack red line when muted **System Information** System: Windows 7 64bit RAM: 4096 MB renderer: 'GeForce GTX 760/PCIe/SSE2' vendor: 'NVIDIA Corporation' version: '4.5.0 NVIDIA 364.72' **Blender Version** Broken: blender-2.80.0-git.0f5b53ba4dc-windows64 **Short description of error** Node Editor: Some nodes lack red line when muted **Exact steps for others to reproduce the error** 1. Open the node editor 2. Add nodes from the screenshots 3. Press "M" to mute them 4. Some nodes have the red crossed through line, others don't Expected: 1. Should be consistent (even if it's not a bug) 2. I can't tell which node is muted and which ones are not I didn't find any indication in the properties either, and the changed colors of the node header don't tell anything ![grafik.png](https://archive.blender.org/developer/F5788514/grafik.png) ![grafik.png](https://archive.blender.org/developer/F5788535/grafik.png)

Michael P. commented

2018-12-02 12:32:44 +01:00

Added subscriber: @MichaelParucha

Jacques Lucke commented

2018-12-03 15:20:09 +01:00

Added subscribers: @WilliamReynish, @brecht, @JacquesLucke

Jacques Lucke commented

2018-12-03 15:20:09 +01:00

The red line indicates which input will be passed on at which output when the node is muted. On some nodes that does not make any sense. E.g. passing on the vector as color in the gradient texture node makes no sense.
Nevertheless I agree that some other indication is necessary here (or it should just not be possible to mute those nodes!).

@brecht, @WilliamReynish what do you think?

The red line indicates which input will be passed on at which output when the node is muted. On some nodes that does not make any sense. E.g. passing on the vector as color in the gradient texture node makes no sense. Nevertheless I agree that some other indication is necessary here (or it should just not be possible to mute those nodes!). @brecht, @WilliamReynish what do you think?

William Reynish commented

2018-12-03 15:33:38 +01:00

I think it's best to be consistent. Even if there's only one input and one output, we could still display the red line. The line both helps communicate what happens when a node is disabled, and the fact that it is disabled at all.

I see no immediate downside to just always drawing the red line when disabled. You then also know which socket to use when connecting to a disabled node.

I think it's best to be consistent. Even if there's only one input and one output, we could still display the red line. The line both helps communicate what happens when a node is disabled, and the fact that it is disabled at all. I see no immediate downside to just always drawing the red line when disabled. You then also know which socket to use when connecting to a disabled node.

Brecht Van Lommel commented

2018-12-03 15:44:59 +01:00

We could also make the node header properly red and grey out all the buttons in the node.

If we want to draw the red line, I guess it would have to be connected to some arbitrary point on the left side of the node. Some disabled nodes don't even have input sockets.

We could also make the node header properly red and grey out all the buttons in the node. If we want to draw the red line, I guess it would have to be connected to some arbitrary point on the left side of the node. Some disabled nodes don't even have input sockets.

Brecht Van Lommel commented

2018-12-03 15:46:09 +01:00

Mainly I think the regression compared to 2.7x is the theming, which does not make the header red enough. This should at least be fixed.

William Reynish commented

2018-12-03 16:08:29 +01:00

Hm, true. Probably better then to just grey out the contents of the node.

The line I see we can't always use, and the theme thing will never be clear enough I don't think.

Hm, true. Probably better then to just grey out the contents of the node. The line I see we can't always use, and the theme thing will never be clear enough I don't think.

Brecht Van Lommel commented

2019-03-26 13:55:14 +01:00

Closed as duplicate of #60719

Brecht Van Lommel closed this issue

2019-03-26 13:55:14 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node Editor: Some nodes lack red line when muted #58508