Insert and modify keyframes on evaluation time for path animation with linear interpolation impossible #59178

New Issue

Marcel Aulenbacher · 2018-12-11T11:36:09+01:00

2018-12-11 11:36:09 +01:00

System Information
Operating system: Win 10 Home
Graphics card: NVIDIA GTX 1050

Blender Version
Broken: 2.80, 9a8b6d51c1, blender2.8, 2018-12-11

Short description of error
Insert / modify keyframe values in evaluation time for path animation on bezier curve with linear interpolation impossible. Value resets to first value for first set keyframe.

Exact steps for others to reproduce the error

Use the start up file
Delete all scene elements
Set one window to curve modifier
Add a Bezier curve to the scene
In the object data window set two keyframes with random values
Set the key interpolation to linear in graph editor
In the object data window, try to modify one of the inserted keyframes, and / or insert a new keyframe with any random value

**System Information** Operating system: Win 10 Home Graphics card: NVIDIA GTX 1050 **Blender Version** Broken: 2.80, 9a8b6d51c12, blender2.8, 2018-12-11 **Short description of error** Insert / modify keyframe values in evaluation time for path animation on bezier curve with linear interpolation impossible. Value resets to first value for first set keyframe. **Exact steps for others to reproduce the error** - Use the start up file - Delete all scene elements - Set one window to curve modifier - Add a Bezier curve to the scene - In the object data window set two keyframes with random values - Set the key interpolation to linear in graph editor - In the object data window, try to modify one of the inserted keyframes, and / or insert a new keyframe with any random value

Marcel Aulenbacher commented

2018-12-11 11:36:09 +01:00

Added subscriber: @comvico

Sebastian Parborg commented

2018-12-12 14:41:13 +01:00

Added subscriber: @ZedDB

Sebastian Parborg commented

2018-12-12 14:41:13 +01:00

I can not reproduce this. However, I think this might be related to an other issue perhaps.

Could you give me a minimal .blend file with this issue? That way I can see if I can reproduce this on a blend file you created.

I can not reproduce this. However, I think this might be related to an other issue perhaps. Could you give me a minimal .blend file with this issue? That way I can see if I can reproduce this on a blend file you created.

Marcel Aulenbacher commented

2018-12-12 16:32:19 +01:00

Hi Sebastian.

Please find two files attached. Once you opened the .blend file, just click into the Time Evaluation field and try to change it.

bug-evaluation-time-lin-interpol.blend

Hi Sebastian. Please find two files attached. Once you opened the .blend file, just click into the Time Evaluation field and try to change it. ![window.PNG](https://archive.blender.org/developer/F5932944/window.PNG) [bug-evaluation-time-lin-interpol.blend](https://archive.blender.org/developer/F5932943/bug-evaluation-time-lin-interpol.blend)

Sergey Sharybin was assigned by Sebastian Parborg

2018-12-12 17:04:20 +01:00

Sebastian Parborg commented

2018-12-12 17:04:20 +01:00

Added subscriber: @Sergey

Sebastian Parborg commented

2018-12-12 17:04:20 +01:00

I can reproduce the issue on the .blend file you gave me!

@Sergey I'm guessing it's the same root cause as in issue #58739

I can reproduce the issue on the .blend file you gave me! @Sergey I'm guessing it's the same root cause as in issue #58739

Marcel Aulenbacher commented

2018-12-12 17:09:14 +01:00

It reads somehow similar. In my case the bug is just present once I change the interpolation from bezier to linear. It's when it breaks the function.
I got so far a plenty of plugins installed - it might be related. I didn't check though.

It reads somehow similar. In my case the bug is just present once I change the interpolation from bezier to linear. It's when it breaks the function. I got so far a plenty of plugins installed - it might be related. I didn't check though.

Eugen Fetsch commented

2018-12-13 10:25:14 +01:00

Added subscriber: @camomiles

Sergey Sharybin commented

2019-01-25 12:15:42 +01:00

This is caused by various areas of Blender doing drivers animation explicitly. This is something what should be left to dependency graph nowadays. Without this the old system which is based on checking RECALC flags on animation data fails dramatically (there is no reliable way we can set that flag within context of copy-on-write).

Here is a patch for this specific issue, but it might potentially introduce another ones, so need some more testing first:

P898: Fix for #59178

diff --git a/source/blender/blenkernel/intern/object_update.c b/source/blender/blenkernel/intern/object_update.c
index a159e713d01..5b0a722a131 100644
--- a/source/blender/blenkernel/intern/object_update.c
+++ b/source/blender/blenkernel/intern/object_update.c
@@ -159,27 +159,10 @@ void BKE_object_handle_data_update(
         Scene *scene,
         Object *ob)
 {
-	ID *data_id = (ID *)ob->data;
-	AnimData *adt = BKE_animdata_from_id(data_id);
-	Key *key;
 	float ctime = BKE_scene_frame_get(scene);
 
 	DEG_debug_print_eval(depsgraph, __func__, ob->id.name, ob);
 
-	/* TODO(sergey): Only used by legacy depsgraph. */
-	if (adt) {
-		/* evaluate drivers - datalevel */
-		/* XXX: for mesh types, should we push this to evaluated mesh instead? */
-		BKE_animsys_evaluate_animdata(depsgraph, scene, data_id, adt, ctime, ADT_RECALC_DRIVERS);
-	}
-
-	/* TODO(sergey): Only used by legacy depsgraph. */
-	key = BKE_key_from_object(ob);
-	if (key && key->block.first) {
-		if (!(ob->shapeflag & OB_SHAPE_LOCK))
-			BKE_animsys_evaluate_animdata(depsgraph, scene, &key->id, key->adt, ctime, ADT_RECALC_DRIVERS);
-	}
-
 	/* includes all keys and modifiers */
 	switch (ob->type) {
 		case OB_MESH:

This is caused by various areas of Blender doing drivers animation explicitly. This is something what should be left to dependency graph nowadays. Without this the old system which is based on checking RECALC flags on animation data fails dramatically (there is no reliable way we can set that flag within context of copy-on-write). Here is a patch for this specific issue, but it might potentially introduce another ones, so need some more testing first: [P898: Fix for #59178](https://archive.blender.org/developer/P898.txt) ``` diff --git a/source/blender/blenkernel/intern/object_update.c b/source/blender/blenkernel/intern/object_update.c index a159e713d01..5b0a722a131 100644 --- a/source/blender/blenkernel/intern/object_update.c +++ b/source/blender/blenkernel/intern/object_update.c @@ -159,27 +159,10 @@ void BKE_object_handle_data_update( Scene *scene, Object *ob) { - ID *data_id = (ID *)ob->data; - AnimData *adt = BKE_animdata_from_id(data_id); - Key *key; float ctime = BKE_scene_frame_get(scene); DEG_debug_print_eval(depsgraph, __func__, ob->id.name, ob); - /* TODO(sergey): Only used by legacy depsgraph. */ - if (adt) { - /* evaluate drivers - datalevel */ - /* XXX: for mesh types, should we push this to evaluated mesh instead? */ - BKE_animsys_evaluate_animdata(depsgraph, scene, data_id, adt, ctime, ADT_RECALC_DRIVERS); - } - - /* TODO(sergey): Only used by legacy depsgraph. */ - key = BKE_key_from_object(ob); - if (key && key->block.first) { - if (!(ob->shapeflag & OB_SHAPE_LOCK)) - BKE_animsys_evaluate_animdata(depsgraph, scene, &key->id, key->adt, ctime, ADT_RECALC_DRIVERS); - } - /* includes all keys and modifiers */ switch (ob->type) { case OB_MESH: ```

Alexander Gavrilov commented

2019-01-25 12:59:40 +01:00

Added subscriber: @angavrilov

Alexander Gavrilov commented

2019-01-25 12:59:40 +01:00

@Sergey IIRC the problem here is that there is a magic recalc flag that makes that call to evaluate drivers also update keyed animation, and that flag is never cleared once set - so presumably the solution is to get rid of adt->recalc?

Sergey Sharybin commented

2019-01-25 14:23:13 +01:00

@angavrilov , yes. But that's part of the issue. Other part is that animation shouldn't be evaluated from object/object data/particles update.

blender-admin commented

2019-01-29 11:59:17 +01:00

This issue was referenced by 83f8f44791

This issue was referenced by 83f8f44791374dd051728e44d89fbdeee15c60aa

Brecht Van Lommel commented

2019-01-31 12:07:36 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2019-01-31 12:07:36 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Insert and modify keyframes on evaluation time for path animation with linear interpolation impossible #59178