Python custom Operators fail to Undo properly if executed while in edit mode #59340

New Issue

Roger B · 2018-12-14T00:31:22+01:00

Roger B commented

2018-12-14 00:31:22 +01:00

System Information
Operating system: Win10
Graphics card: nVidia Quadro 600

Blender Version
Broken: 2.80 26c8e09cff
Worked: Unknown

Short description of error
Python custom Operators fail to Undo properly if executed while in edit mode

I've provided 3 operators that all show incorrect behavior if executed while you are working in edit mode. They may all be the same systemic issue or different, for now you can take your pick on which, or all, you repro with.

The behavior can change depending on if you use the REGISTER,UNDO tags and if you use a manual bpy.ops.ed.undo_push() (none of which are attempted below) but several tries at addressing the issue have been unsuccessful: https://devtalk.blender.org/t/addon-operators-and-undo-support/4271

Exact steps for others to reproduce the error
undo_repro.blend undo_repro.py

Start blender with --factory-startup option
Load the attached .blend:
- Reload this .blend for each individual repro
- You should be placed in editmode -- this is important. Do not manually switch modes during the repro
Invoke 1 of the 3 operators provided by using the built in script editor / py console etc:
- bpy.ops.view3d.rb_collection_undo_issue() - Adds a new collection to the scene, moves the object named "Cube" to that new collection
- bpy.ops.view3d.rb_mod_undo_issue() - Adds a modifier to the object named "Cube"
- bpy.ops.view3d.rb_separate_undo_issue() - Takes currently selected geo and separates into new object
Invoke CTRL-Z Undo
- Notice how none of the actions are undone properly
Invoke CTRL-Z Undo a second time; this time the actions are undone because the undo stack passes through the edit-mode toggle as set in the file
- If you were to perform N other actions between edit-mode toggle and the operator in question, you basically have to CTRL-Z undo N+1 times before the state is undone

**System Information** Operating system: Win10 Graphics card: nVidia Quadro 600 **Blender Version** Broken: 2.80 26c8e09cffd Worked: Unknown **Short description of error** Python custom Operators fail to Undo properly if executed while in edit mode I've provided 3 operators that all show incorrect behavior if executed while you are working in edit mode. They may all be the same systemic issue or different, for now you can take your pick on which, or all, you repro with. The behavior can change depending on if you use the REGISTER,UNDO tags and if you use a manual bpy.ops.ed.undo_push() (_none of which are attempted below_) but several tries at addressing the issue have been unsuccessful: https://devtalk.blender.org/t/addon-operators-and-undo-support/4271 **Exact steps for others to reproduce the error** [undo_repro.blend](https://archive.blender.org/developer/F5947351/undo_repro.blend) [undo_repro.py](https://archive.blender.org/developer/F5947353/undo_repro.py) * Start blender with --factory-startup option * Load the attached .blend: * Reload this .blend for each individual repro * You should be placed in editmode -- this is important. Do not manually switch modes during the repro * Invoke 1 of the 3 operators provided by using the built in script editor / py console etc: * bpy.ops.view3d.rb_collection_undo_issue() - Adds a new collection to the scene, moves the object named "Cube" to that new collection * bpy.ops.view3d.rb_mod_undo_issue() - Adds a modifier to the object named "Cube" * bpy.ops.view3d.rb_separate_undo_issue() - Takes currently selected geo and separates into new object * Invoke CTRL-Z Undo * Notice how none of the actions are undone properly * Invoke CTRL-Z Undo a second time; this time the actions are undone because the undo stack passes through the edit-mode toggle as set in the file * If you were to perform N other actions between edit-mode toggle and the operator in question, you basically have to CTRL-Z undo N+1 times before the state is undone

Roger B commented

2018-12-14 00:31:22 +01:00

Added subscriber: @rboxman

Sebastian Parborg commented

2018-12-14 12:23:43 +01:00

Added subscribers: @brecht, @ZedDB

Sebastian Parborg commented

2018-12-14 12:23:43 +01:00

I can confirm that I need to invoke undo two times for this to undo properly (or well, not properly in this case).

@brecht who to assign this to?

I can confirm that I need to invoke undo two times for this to undo properly (or well, not properly in this case). @brecht who to assign this to?

Campbell Barton was assigned by Brecht Van Lommel

2018-12-14 13:48:02 +01:00

Brecht Van Lommel commented

2018-12-14 13:48:02 +01:00

Added subscriber: @ideasman42

Brecht Van Lommel commented

2018-12-14 13:48:02 +01:00

@ideasman42 worked on the undo system last, and probably knows if this is a bug or a limitation.

Roger B commented

2019-05-28 21:49:46 +02:00

Re-testing now since lots of time has passed. Good news is that the collection issue and the mesh separation issue seem fixed for some simple cases I've tried. Bad news is that the modifier issue still remains and can still be repro'd with the above blend and script.

Campbell Barton was unassigned by Dalai Felinto

2019-12-23 16:35:37 +01:00

Sybren A. Stüvel commented

2020-02-10 16:13:36 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-02-10 16:13:36 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2020-02-10 16:13:36 +01:00

Sybren A. Stüvel self-assigned this 2020-02-10 16:13:36 +01:00

Sybren A. Stüvel commented

2020-02-10 16:13:36 +01:00

I re-tested the modifier issue, and I can't reproduce this any more on the current master branch (ec116e3d49), so I'll assume this has been resolved.

Please try the latest daily build: https://builder.blender.org/download/

If the problem persists, please let us know in a comment so we can re-open the report. Don't forget to mention the specific version you tested again.

I re-tested the modifier issue, and I can't reproduce this any more on the current master branch (ec116e3d492511298c9bf595c19e6c49e07c97f6), so I'll assume this has been resolved. Please try the latest daily build: https://builder.blender.org/download/ If the problem persists, please let us know in a comment so we can re-open the report. Don't forget to mention the specific version you tested again.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Python custom Operators fail to Undo properly if executed while in edit mode #59340