Materials made from 'Make Single User' share animation from the material they were made from #59390

New Issue

Laurence Weedy · 2018-12-14T23:07:35+01:00

Laurence Weedy commented

2018-12-14 23:07:35 +01:00

System Information
Operating system: Win10P Pro 64 bit
Graphics card: MSI 1080 - i7 6800k 16GB ram

Blender Version
version: 2.80 (sub 37), branch: blender2.8, commit date: 2018-12-14 16:29, hash: c7cc97c7b9, type: Release
build date: 14/12/2018, 08:44

Short description of error
This seems to work OK in 2.79 so guess is a bug.

In 2.8 -
With the default cube make a change the material so it has two shaders (say red and green) and a mix shader.
Set the factor of the mix node to say 0.2 and set a key frame for it.
Now Alt-D the cube to make another.
Go to Object/Relations/Make Single User and select Object&Data&Materials to make it single user.
Now go to the Shader Editor for the new cube and find the Factor of the Mix Shader and set it to a new value.

The two cubes will be different colours.
Press 'i' with cursor over the Factor window to make a key for it. Both cubes will become the same colour.

This is I think because Blender believes the Mix Shader for the two different materials are the same mix shader.

Hope that makes sense.

**System Information** Operating system: Win10P Pro 64 bit Graphics card: MSI 1080 - i7 6800k 16GB ram **Blender Version** version: 2.80 (sub 37), branch: blender2.8, commit date: 2018-12-14 16:29, hash: c7cc97c7b90, type: Release build date: 14/12/2018, 08:44 **Short description of error** This seems to work OK in 2.79 so guess is a bug. In 2.8 - With the default cube make a change the material so it has two shaders (say red and green) and a mix shader. Set the factor of the mix node to say 0.2 and set a key frame for it. Now Alt-D the cube to make another. Go to Object/Relations/Make Single User and select Object&Data&Materials to make it single user. Now go to the Shader Editor for the new cube and find the Factor of the Mix Shader and set it to a new value. ![Materials.jpg](https://archive.blender.org/developer/F5955707/Materials.jpg) The two cubes will be different colours. Press 'i' with cursor over the Factor window to make a key for it. Both cubes will become the same colour. This is I think because Blender believes the Mix Shader for the two different materials are the same mix shader. Hope that makes sense.

Laurence Weedy commented

2018-12-14 23:07:35 +01:00

Added subscriber: @LaurenceWeedy

Sebastian Parborg commented

2018-12-19 14:20:25 +01:00

Added subscriber: @ZedDB

Sergey Sharybin was assigned by Sebastian Parborg

2018-12-19 14:20:25 +01:00

Sebastian Parborg commented

2018-12-19 14:20:25 +01:00

I'm guessing this is a depsgraph issue?

Philipp Oeser commented

2018-12-19 14:42:00 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-12-19 14:42:00 +01:00

Think this is a duplicate of #59062?

Sergey Sharybin commented

2018-12-19 15:09:32 +01:00

@ZedDB but my guess is that is either make Make Single User doesn't make action local or does not inform dependency graph about changes.

@ZedDB but my guess is that is either make `Make Single User` doesn't make action local or does not inform dependency graph about changes.

Sergey Sharybin removed their assignment 2018-12-19 15:26:56 +01:00

Bastien Montagne was assigned by Sergey Sharybin

2018-12-19 15:26:56 +01:00

Sergey Sharybin commented

2018-12-19 15:26:56 +01:00

Added subscribers: @mont29, @Sergey

Sergey Sharybin commented

2018-12-19 15:26:56 +01:00

@mont29, afraid need to bounce this to you, as the most familiar with all the library remap and such. A bit of a long story:

single_mat_users() does BKE_material_copy(), which does not do anything with actions. So, there is BKE_animdata_copy_id_action() for material's animation right after material copy. So one of the fixes is to add BKE_animdata_copy_id_action() for material node tree (if that is not NULL).

Alternatively, maybe need to pass some extra flags to BKE_material_copy() to say, that we want LIB_ID_COPY_ACTIONS ?

@mont29, afraid need to bounce this to you, as the most familiar with all the library remap and such. A bit of a long story: `single_mat_users()` does `BKE_material_copy()`, which does not do anything with actions. So, there is `BKE_animdata_copy_id_action()` for material's animation right after material copy. So one of the fixes is to add `BKE_animdata_copy_id_action()` for material node tree (if that is not NULL). Alternatively, maybe need to pass some extra flags to `BKE_material_copy()` to say, that we want `LIB_ID_COPY_ACTIONS` ?

Laurence Weedy commented

2018-12-21 11:46:59 +01:00

Hello,
This problem seems to have been fixed now with this mornings build - Win 64 ending 7e5 - 21/12/18. Was still a problem with yesterdays build.

Hope this helps

Hello, This problem seems to have been fixed now with this mornings build - Win 64 ending 7e5 - 21/12/18. Was still a problem with yesterdays build. Hope this helps

Sebastian Parborg commented

2018-12-21 12:05:26 +01:00

Changed status from 'Open' to: 'Resolved'

Sebastian Parborg closed this issue

2018-12-21 12:05:26 +01:00

Sebastian Parborg commented

2018-12-21 12:05:26 +01:00

I'll close this as resolved then.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Materials made from 'Make Single User' share animation from the material they were made from #59390