The recent changes broke the pressure and tilt of the tablet pen #59645

New Issue

Martin Capitanio · 2018-12-20T00:00:26+01:00

Martin Capitanio commented

2018-12-20 00:00:26 +01:00

System Information

OS Linux, recent Ubuntu 18.04 LTS,
tested with GP and texture painting,

xsetwacom --list devices
Wacom Intuos4 4x6 Pad pad id: 12 type: PAD
Wacom Intuos4 4x6 Pen cursor id: 15 type: CURSOR
Wacom Intuos4 4x6 Pen stylus id: 13 type: STYLUS
Wacom Intuos4 4x6 Pen eraser id: 14 type: ERASER

Works

Krita v4.1.7, Gimp 2.10.8, Blender 2.79b

Last working blender2.8 commit:
5166132708 2018-11-24

./blender8-181123 --debug-events
wm_event_do_handlers: Handling event
wmEvent  type:1 / LEFTMOUSE, val:1 / PRESS,
         shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0,
         mouse:(631,563), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f000081e908
 tablet: active: 1, pressure 0.6023, tilt: (-0.1270 0.2381)
wm_event_do_handlers: Handling event
wmEvent  type:1 / LEFTMOUSE, val:2 / RELEASE,
         shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0,
         mouse:(688,576), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f0000921a88
 tablet: active: 1, pressure 0.0000, tilt: (-0.1746 0.2698)

Known broken

593ed1347c 2018-12-19 master

@ideasman42 the blender2.8 branch is broken after
Merge branch 'master' into blender2.8 059c1197
059c119719

and still broken on the current blender2.8 branch tip
a8198e6fbf 2018-12-19

( GHOST_SystemX11.cpp with un-commented printf's)

./blender8-181219 --debug-events
Tablet type:'(null)', name:'Virtual core pointer', index:0
Tablet type:'(null)', name:'Virtual core keyboard', index:1
...
Tablet type:'PAD', name:'Wacom Intuos4 4x6 Pad pad', index:10
Tablet type:'CURSOR', name:'Wacom Intuos4 4x6 Pen cursor', index:11
	found stylus
		found ValuatorClass
Tablet type:'STYLUS', name:'Wacom Intuos4 4x6 Pen stylus', index:12
Tablet type:'ERASER', name:'Wacom Intuos4 4x6 Pen eraser', index:13

...

wm_event_do_handlers: Handling event
wmEvent  type:1 / LEFTMOUSE, val:1 / PRESS,
         shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0,
         mouse:(376,662), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f0f475add08

wm_event_do_handlers: Handling event
wmEvent  type:1 / LEFTMOUSE, val:2 / RELEASE,
         shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0,
         mouse:(419,605), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f0f475c8088

System Information **** OS Linux, recent Ubuntu 18.04 LTS, tested with GP and texture painting, xsetwacom --list devices Wacom Intuos4 4x6 Pad pad id: 12 type: PAD Wacom Intuos4 4x6 Pen cursor id: 15 type: CURSOR Wacom Intuos4 4x6 Pen stylus id: 13 type: STYLUS Wacom Intuos4 4x6 Pen eraser id: 14 type: ERASER Works **** Krita v4.1.7, Gimp 2.10.8, Blender 2.79b Last working blender2.8 commit: 5166132708a42ce57ac83a6e5f85fe4190dba312 2018-11-24 ``` ./blender8-181123 --debug-events wm_event_do_handlers: Handling event wmEvent type:1 / LEFTMOUSE, val:1 / PRESS, shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0, mouse:(631,563), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f000081e908 tablet: active: 1, pressure 0.6023, tilt: (-0.1270 0.2381) wm_event_do_handlers: Handling event wmEvent type:1 / LEFTMOUSE, val:2 / RELEASE, shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0, mouse:(688,576), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f0000921a88 tablet: active: 1, pressure 0.0000, tilt: (-0.1746 0.2698) ``` Known broken **** 593ed1347c96aea691eb503a6bbed12c801f3faa 2018-12-19 master @ideasman42 the blender2.8 branch is broken after Merge branch 'master' into blender2.8 059c1197 https://github.com/sobotka/blender/commit/059c119719e04283808d3c7076886e1a58874f6b and still broken on the current blender2.8 branch tip a8198e6fbf6bc3ef870e89988593282489c011e4 2018-12-19 ( GHOST_SystemX11.cpp with un-commented printf's) ``` ./blender8-181219 --debug-events Tablet type:'(null)', name:'Virtual core pointer', index:0 Tablet type:'(null)', name:'Virtual core keyboard', index:1 ... Tablet type:'PAD', name:'Wacom Intuos4 4x6 Pad pad', index:10 Tablet type:'CURSOR', name:'Wacom Intuos4 4x6 Pen cursor', index:11 found stylus found ValuatorClass Tablet type:'STYLUS', name:'Wacom Intuos4 4x6 Pen stylus', index:12 Tablet type:'ERASER', name:'Wacom Intuos4 4x6 Pen eraser', index:13 ... wm_event_do_handlers: Handling event wmEvent type:1 / LEFTMOUSE, val:1 / PRESS, shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0, mouse:(376,662), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f0f475add08 wm_event_do_handlers: Handling event wmEvent type:1 / LEFTMOUSE, val:2 / RELEASE, shift:0, ctrl:0, alt:0, oskey:0, keymodifier:0, mouse:(419,605), ascii:'', utf8:'', keymap_idname:(null), pointer:0x7f0f475c8088 ```

Martin Capitanio commented

2018-12-20 00:00:26 +01:00

Added subscribers: @ideasman42, @capnm

Martin Capitanio commented

2018-12-20 00:46:03 +01:00

Removing pen from the whitelist fixes the issue for this tablet:
intern/ghost/intern/GHOST_SystemX11.cpp:2332

Tablet type:'PAD', name:'Wacom Intuos4 4x6 Pad pad', index:10
Tablet type:'CURSOR', name:'Wacom Intuos4 4x6 Pen cursor', index:11
Tablet type:'STYLUS', name:'Wacom Intuos4 4x6 Pen stylus', index:12
	found stylus
		found ValuatorClass
Tablet type:'ERASER', name:'Wacom Intuos4 4x6 Pen eraser', index:13
	found eraser

Looks like refreshXInputDevices() first needs to check all device types before running through the device names …

Removing `pen` from the whitelist fixes the issue for this tablet: [intern/ghost/intern/GHOST_SystemX11.cpp:2332 ](https://github.com/sobotka/blender/commit/059c119719e04283808d3c7076886e1a58874f6b#diff-2f96c37e18daf236a8af483a36558479R2332) ``` Tablet type:'PAD', name:'Wacom Intuos4 4x6 Pad pad', index:10 Tablet type:'CURSOR', name:'Wacom Intuos4 4x6 Pen cursor', index:11 Tablet type:'STYLUS', name:'Wacom Intuos4 4x6 Pen stylus', index:12 found stylus found ValuatorClass Tablet type:'ERASER', name:'Wacom Intuos4 4x6 Pen eraser', index:13 found eraser ``` Looks like `refreshXInputDevices()` first needs to check all device types before running through the device names …

Campbell Barton commented

2018-12-20 04:34:26 +01:00

Looks like e5bc9fae54 caused the issue.

Looks like e5bc9fae54 caused the issue.

Martin Capitanio commented

2018-12-20 05:16:20 +01:00

In particular, adding the "pen" to the whitelist causes the CURSOR to be erroneously recognized as a stylus in the device name check in tablet_mode_from_name():

Tablet type:'PAD', name:'Wacom Intuos4 4x6 Pad pad', index:10
Tablet type:'CURSOR', name:'Wacom Intuos4 4x6 Pen cursor', index:11
	found stylus
		found ValuatorClass
Tablet type:'STYLUS', name:'Wacom Intuos4 4x6 Pen stylus', index:12
Tablet type:'ERASER', name:'Wacom Intuos4 4x6 Pen eraser', index:13

In particular, adding the "pen" to the whitelist causes the CURSOR to be erroneously recognized as a stylus in the device name check in `tablet_mode_from_name()`: ``` Tablet type:'PAD', name:'Wacom Intuos4 4x6 Pad pad', index:10 Tablet type:'CURSOR', name:'Wacom Intuos4 4x6 Pen cursor', index:11 found stylus found ValuatorClass Tablet type:'STYLUS', name:'Wacom Intuos4 4x6 Pen stylus', index:12 Tablet type:'ERASER', name:'Wacom Intuos4 4x6 Pen eraser', index:13 ```

Brecht Van Lommel self-assigned this 2018-12-20 09:58:34 +01:00

blender-admin commented

2018-12-27 15:22:20 +01:00

This issue was referenced by 7bed048243

This issue was referenced by 7bed048243fef51e92b86e4383fa48d1d18d12ac

blender-admin commented

2018-12-27 15:22:20 +01:00

This issue was referenced by 29feb215f4

This issue was referenced by 29feb215f42d886659ee72c8166f9b207e127fec

blender-admin commented

2018-12-27 15:22:20 +01:00

This issue was referenced by 53a6a0b258

This issue was referenced by 53a6a0b2584a6730d6cfc03f3312ff0e5da91a4f

Brecht Van Lommel commented

2018-12-27 16:19:24 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2018-12-27 16:19:24 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

The recent changes broke the pressure and tilt of the tablet pen #59645