Font preview is grey on a white background #60415

New Issue

Paul McManus · 2019-01-11T09:53:59+01:00

Paul McManus commented

2019-01-11 09:53:59 +01:00

System Information
Operating system: Windows 10
Graphics card: GTX1080

Blender Version
Broken: 2.80, f98e4cbedb, blender2.7, 2019-01-11
Worked: build from 3 days ago

Launch Blender; drop a text object into the screen; select the Font property and browse to a folder containing font files; select the preview mode.

Font preview shows font styles in light grey on a white background. Legibility is greatly reduced.

**System Information** Operating system: Windows 10 Graphics card: GTX1080 **Blender Version** Broken: 2.80, f98e4cbedbb7, blender2.7, 2019-01-11 Worked: build from 3 days ago Launch Blender; drop a text object into the screen; select the Font property and browse to a folder containing font files; select the preview mode. Font preview shows font styles in light grey on a white background. Legibility is greatly reduced.

Paul McManus commented

2019-01-11 09:53:59 +01:00

Added subscriber: @PaulMcManus

Philipp Oeser commented

2019-01-11 10:15:21 +01:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2019-01-11 10:15:21 +01:00

Philipp Oeser commented

2019-01-11 10:15:21 +01:00

Not striclty a bug, but confirming for now and checking...

Philipp Oeser removed their assignment 2019-01-11 14:57:23 +01:00

Brecht Van Lommel was assigned by Philipp Oeser

2019-01-11 14:57:23 +01:00

Philipp Oeser commented

2019-01-11 14:57:23 +01:00

Added subscriber: @brecht

Philipp Oeser commented

2019-01-11 14:57:23 +01:00

caused by 7e7657da29

@brecht: mind checking? Following [just an exception for the font case] seems to fix, but I would need to check datablock previews more to really know whats going on...

P890: #60415 snippet



diff --git a/source/blender/editors/space_file/file_draw.c b/source/blender/editors/space_file/file_draw.c
index 4b2486f2a68..2c88ddb546d 100644
--- a/source/blender/editors/space_file/file_draw.c
+++ b/source/blender/editors/space_file/file_draw.c
@@ -389,10 +389,11 @@ static void file_draw_preview(
 	/* the image */
 	if (!is_icon && typeflags & FILE_TYPE_FTFONT) {
 		UI_GetThemeColor4fv(TH_TEXT, col);
+		GPU_blend_set_func_separate(GPU_SRC_ALPHA, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA);
+	}
+	else {
+		GPU_blend_set_func_separate(GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA);
 	}
-
-	/* Preview images use premultiplied alpha. */
-	GPU_blend_set_func_separate(GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA);
 
 	IMMDrawPixelsTexState state = immDrawPixelsTexSetup(GPU_SHADER_2D_IMAGE_COLOR);
 	immDrawPixelsTexScaled(&state, (float)xco, (float)yco, imb->x, imb->y, GL_RGBA, GL_UNSIGNED_BYTE, GL_NEAREST, imb->rect,

btw.: blendfile previews dont seem to get a proper alpha anymore in 2.8? its black for me where it was transparent in 2.7 [but again: I havent checked in depth...]
(feel free to throw back at me and I will do proper investigation...)

caused by 7e7657da29 @brecht: mind checking? Following [just an exception for the `font` case] seems to fix, but I would need to check datablock previews more to really know whats going on... [P890: #60415 snippet](https://archive.blender.org/developer/P890.txt) ``` diff --git a/source/blender/editors/space_file/file_draw.c b/source/blender/editors/space_file/file_draw.c index 4b2486f2a68..2c88ddb546d 100644 --- a/source/blender/editors/space_file/file_draw.c +++ b/source/blender/editors/space_file/file_draw.c @@ -389,10 +389,11 @@ static void file_draw_preview( /* the image */ if (!is_icon && typeflags & FILE_TYPE_FTFONT) { UI_GetThemeColor4fv(TH_TEXT, col); + GPU_blend_set_func_separate(GPU_SRC_ALPHA, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA); + } + else { + GPU_blend_set_func_separate(GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA); } - - /* Preview images use premultiplied alpha. */ - GPU_blend_set_func_separate(GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA, GPU_ONE, GPU_ONE_MINUS_SRC_ALPHA); IMMDrawPixelsTexState state = immDrawPixelsTexSetup(GPU_SHADER_2D_IMAGE_COLOR); immDrawPixelsTexScaled(&state, (float)xco, (float)yco, imb->x, imb->y, GL_RGBA, GL_UNSIGNED_BYTE, GL_NEAREST, imb->rect, ``` btw.: blendfile previews dont seem to get a proper alpha anymore in 2.8? its black for me where it was transparent in 2.7 [but again: I havent checked in depth...] (feel free to throw back at me and I will do proper investigation...)

blender-admin commented

2019-01-11 17:00:03 +01:00

This issue was referenced by 6abbab5b53

This issue was referenced by 6abbab5b5396a84a8f3169135f5937d76d3dcb6f

Brecht Van Lommel commented

2019-01-11 17:27:58 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2019-01-11 17:27:58 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Font preview is grey on a white background #60415