The tool system's "Spin" and "Spin (Duplicate)" operators are the same #60607

New Issue

Jesse Yurkovich · 2019-01-18T01:16:04+01:00

Jesse Yurkovich commented

2019-01-18 01:16:04 +01:00

System Information
Operating system: Win10
Graphics card: nVidia Quadro 600

Blender Version
Broken: 2.80 (sub 41), branch: master, commit date: 2019-01-16 19:04, hash: 8ba86020cc
Worked: N/A

Short description of error
The tool system's "Spin" and "Spin (Duplicate)" operators are the same. In other words they do the same thing by default. I believe that "Spin (Duplicate)" should have the "Dupli" option checked/set to True, but this is not the case.

Additionally, it would be best to spell out "Dupli" in the UI -- "Use Duplicates" would be my suggestion.

Exact steps for others to reproduce the error

Start with default .blend
Go to Edit mode on cube
Try to use the Spin or Spin (Duplicate) operators from the new T-panel
Observe that, by default, they both do the same thing and have the same settings

**System Information** Operating system: Win10 Graphics card: nVidia Quadro 600 **Blender Version** Broken: 2.80 (sub 41), branch: master, commit date: 2019-01-16 19:04, hash: 8ba86020cc50 Worked: N/A **Short description of error** The tool system's "Spin" and "Spin (Duplicate)" operators are the same. In other words they do the same thing by default. I believe that "Spin (Duplicate)" should have the "Dupli" option checked/set to True, but this is not the case. Additionally, it would be best to spell out "Dupli" in the UI -- "Use Duplicates" would be my suggestion. **Exact steps for others to reproduce the error** - Start with default .blend - Go to Edit mode on cube - Try to use the Spin or Spin (Duplicate) operators from the new T-panel - Observe that, by default, they both do the same thing and have the same settings

Jesse Yurkovich commented

2019-01-18 01:16:04 +01:00

Added subscriber: @deadpin

Jacques Lucke commented

2019-01-18 12:04:33 +01:00

Added subscriber: @ideasman42

William Reynish commented

2019-01-18 14:43:25 +01:00

Added subscriber: @WilliamReynish

William Reynish commented

2019-01-18 14:43:25 +01:00

Apart from the bug itself, I agree we should revise the naming here.

'Spin (Duplicate)' -> 'Spin Duplicates'
'Dupli' -> 'Use Duplicates'

No need to be needlessly cryptic.

Apart from the bug itself, I agree we should revise the naming here. 'Spin (Duplicate)' -> 'Spin Duplicates' 'Dupli' -> 'Use Duplicates' No need to be needlessly cryptic.

Joel Godin commented

2019-01-30 02:30:19 +01:00

Added subscriber: @FloridaJo

Joel Godin commented

2019-01-30 02:30:19 +01:00

Not sure its a bug, but rather a naming issue.
If you look at the panel, you have to check 'Dupli' for it to duplicate.

Otherwise it just spins.
So like in 2.79 there is just 'spin' then you click 'dupli' for duplicate. There is not 'spin' and 'spin (duplicate)'.

Not sure its a bug, but rather a naming issue. If you look at the panel, you have to check 'Dupli' for it to duplicate. ![1.png](https://archive.blender.org/developer/F6448326/1.png) Otherwise it just spins. So like in 2.79 there is just 'spin' then you click 'dupli' for duplicate. There is not 'spin' and 'spin (duplicate)'. ![2.png](https://archive.blender.org/developer/F6448345/2.png)

Joel Godin commented

2019-01-30 19:02:55 +01:00

Correction; it is a bug.
Spin (Duplicate) should open with 'dupli' set to True and it is not.

As you can see from the code, it is supposed to be defaulted to 'True', but it either is getting
overwritten on window update or something else. Will dig further.

def km_3d_view_tool_edit_mesh_spin(params):
    return (
        "3D View Tool: Edit Mesh, Spin",
        {"space_type": 'VIEW_3D', "region_type": 'WINDOW'},
        {"items": [
            ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'}, None),
        ]},
    )


def km_3d_view_tool_edit_mesh_spin_duplicate(params):
    return (
        "3D View Tool: Edit Mesh, Spin (Duplicate)",
        {"space_type": 'VIEW_3D', "region_type": 'WINDOW'},
        {"items": [
            ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'},
             {"properties": [("dupli", True)]}),
        ]},
    )

Correction; it is a bug. Spin (Duplicate) should open with 'dupli' set to True and it is not. As you can see from the code, it is supposed to be defaulted to 'True', but it either is getting overwritten on window update or something else. Will dig further. ``` def km_3d_view_tool_edit_mesh_spin(params): return ( "3D View Tool: Edit Mesh, Spin", {"space_type": 'VIEW_3D', "region_type": 'WINDOW'}, {"items": [ ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'}, None), ]}, ) def km_3d_view_tool_edit_mesh_spin_duplicate(params): return ( "3D View Tool: Edit Mesh, Spin (Duplicate)", {"space_type": 'VIEW_3D', "region_type": 'WINDOW'}, {"items": [ ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'}, {"properties": [("dupli", True)]}), ]}, ) ```

Joel Godin self-assigned this 2019-01-31 01:09:46 +01:00

Joel Godin removed their assignment 2019-02-04 14:04:56 +01:00

Campbell Barton was assigned by William Reynish

2019-02-04 15:40:40 +01:00

William Reynish commented

2019-02-04 15:40:40 +01:00

I think this one is for you, @ideasman42 :)

blender-admin commented

2019-11-01 01:22:04 +01:00

This issue was referenced by c1f8268734

This issue was referenced by c1f8268734af40a73661642b1bb3f8d27325dd96

Campbell Barton commented

2019-11-01 01:26:54 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2019-11-01 01:26:54 +01:00

Jesse Yurkovich commented

2019-11-01 18:44:14 +01:00

I believe this is still an issue. Here's a gif that shows the issue -- The initial invocation of the Spin (Duplicate) tool still does not have the correct option set:

I believe this is still an issue. Here's a gif that shows the issue -- The initial invocation of the Spin (Duplicate) tool still does not have the correct option set: ![spin-bug.gif](https://archive.blender.org/developer/F7892779/spin-bug.gif)

Campbell Barton commented

2019-11-03 04:40:20 +01:00

I can't redo this - the setting is always set correctly in 6db9b443bb5b893b2807850a43de56e81c77160e

I can't redo this - the setting is always set correctly in `6db9b443bb5b893b2807850a43de56e81c77160e`

Jesse Yurkovich commented

2019-11-04 08:25:07 +01:00

Tried again with today's build of master (e45cfb574e) using --factory-startup plus a completely clean preferences directory: it still repro's for me. At least one other person on blender-coders was also able to confirm the issue still happens for them as well. Is there anything for me to try and debug on my side (I have debug build available to set breakpoints as well)

Tried again with today's build of master (e45cfb574ee7) using `--factory-startup` plus a completely clean preferences directory: it still repro's for me. At least one other person on blender-coders was also able to confirm the issue still happens for them as well. Is there anything for me to try and debug on my side (I have debug build available to set breakpoints as well)

Joel Godin commented

2019-11-18 05:39:14 +01:00

I can verify that 'duplicates' still does not work.
Before it at least worked when you checked the box manually, but now it don't work at all. The checkbox 'duplicates' unchecks upon initiating action.

I can verify that 'duplicates' still does not work. Before it at least worked when you checked the box manually, but now it don't work at all. The checkbox 'duplicates' unchecks upon initiating action.

Campbell Barton commented

2019-11-18 06:53:48 +01:00

It's more of an implementation detail that spin and spin-duplicate share an operator.

If you start a new spin or spin-duplicate operation, it's going to use the option based on the tool set.

It's more of an implementation detail that spin and spin-duplicate share an operator. If you start a new spin or spin-duplicate operation, it's going to use the option based on the tool set.

Joel Godin commented

2019-11-18 12:49:02 +01:00

Spin and Spin Duplicate do the same thing is the main thing I'm pointing out.
No difference. Bug.

Spin and Spin Duplicate do the same thing is the main thing I'm pointing out. No difference. Bug.

Roberto Lopes commented

2022-04-05 11:18:46 +02:00

Added subscriber: @XDroid-3

Roberto Lopes commented

2022-04-05 11:18:46 +02:00

Bug still present in 3.1.2.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

The tool system's "Spin" and "Spin (Duplicate)" operators are the same #60607