Undo steps with texture paint break across memfile steps #61263

New Issue

Campbell Barton · 2019-02-07T00:45:45+01:00

Campbell Barton commented

2019-02-07 00:45:45 +01:00

Texture paint undo steps don't work properly when mixed with memfile undo (object mode operations).

Default cube.
Set texture paint mode, add 'Base Color' slot for painting.
Make one stroke.

Undo everything, redo everything.
All correct.

Now switch to object mode and undo, notice the image has been cleared.

Note that this is more of a limit in how image undo works than some mistake in the code. since 2.7x never supported this.

Image painting is an exception that needs special handling since it has undo data that exists outside global undo.

Reporting because this should be fixed before 2.8x release, or worse case we could limit texture paint undo/redo to the current painting session as 2.7x (would be a shame, but better then loosing the users work).

Texture paint undo steps don't work properly when mixed with memfile undo (object mode operations). - Default cube. - Set texture paint mode, add 'Base Color' slot for painting. - Make one stroke. --- - *Undo everything, redo everything.* - All correct. --- Now switch to object mode and undo, notice the image has been cleared. ---- Note that this is more of a limit in how image undo works than some mistake in the code. since 2.7x never supported this. Image painting is an exception that needs special handling since it has undo data that exists outside global undo. Reporting because this should be fixed before 2.8x release, or worse case we could limit texture paint undo/redo to the current painting session as 2.7x *(would be a shame, but better then loosing the users work)*.

Campbell Barton self-assigned this 2019-02-07 00:45:45 +01:00

Campbell Barton commented

2019-02-07 00:45:45 +01:00

Added subscriber: @ideasman42

blender-admin commented

2019-02-07 00:45:45 +01:00

#66890 was marked as duplicate of this issue

Campbell Barton changed title from ~~Texture paint steps break across memfile steps~~ to Undo steps with texture paint break across memfile steps

2019-02-07 00:47:12 +01:00

Dalai Felinto commented

2019-02-15 22:21:01 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2019-02-15 22:21:01 +01:00

Strange that if I do UNDO again after object mode + UNDO, the image is back. For the records, tested with eff3728db9.

Strange that if I do UNDO again after object mode + UNDO, the image is back. For the records, tested with eff3728db9.

Daniel Grauer commented

2019-04-07 17:17:28 +02:00

Added subscriber: @DanielGrauer

Lance Phan commented

2019-07-08 11:09:37 +02:00

Added subscriber: @ssendam

Germano Cavalcante commented

2019-07-11 19:07:45 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-07-11 19:07:45 +02:00

Has this bug already been fixed? I can't reproduce with the described steps.

Campbell Barton commented

2019-07-29 03:51:22 +02:00

Looked into this recently, the painting undo stack now works across mem-file undo steps in some situations (resolved 1d7be99ba4), however there is still a problem.

Even though mem-file undo attempts to keep Image.cache between undo steps, there are still times when it's cleared.

This clears the ImBuf which is the current in-memory state of the image.

I'm not sure why this only happens in some cases, needs further investigation.

Looked into this recently, the painting undo stack now works across mem-file undo steps in some situations (resolved 1d7be99ba4), however there is still a problem. Even though mem-file undo attempts to keep `Image.cache` between undo steps, there are still times when it's cleared. This clears the `ImBuf` which is the current in-memory state of the image. I'm not sure why this only happens in some cases, needs further investigation.

Juanfran Matheu commented

2019-08-16 13:12:29 +02:00

Added subscriber: @jfmatheu

Juanfran Matheu commented

2019-08-16 13:12:29 +02:00

Can't reproduce this with Blender 2.81 build from 14th August later build and with Blender 2.80 last build

Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: Radeon RX 580 Series ATI Technologies Inc. 4.5.13570 Core Profile Context 19.8.1 26.20.13001.29010

Can't reproduce this with Blender 2.81 build from 14th August later build and with Blender 2.80 last build Operating system: Windows-10-10.0.18362 64 Bits Graphics card: Radeon RX 580 Series ATI Technologies Inc. 4.5.13570 Core Profile Context 19.8.1 26.20.13001.29010

Campbell Barton commented

2019-08-16 16:23:37 +02:00

Thanks for checking.

This problem happens far less often then it used to, but it can still happen, so keeping this open.

Thanks for checking. This problem happens far less often then it used to, but it can still happen, so keeping this open.

Philipp Oeser commented

2019-09-06 12:48:04 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-09-06 12:48:04 +02:00

@ideasman42 : I have added this to 2.81 milestone (since it was set to "High"), mind checking again?

Campbell Barton commented

2019-09-18 12:46:50 +02:00

The issue is the image cache sometimes gets freed by memfile undo, the image then gets reloaded and the undo tiles are applied on-top of the wrong image data.

I looked into memfile undo image cache pointer map and it doesn't look like some mistake in the code causing this, in fact this works in most cases.

It turns out it's not enough just to correctly remap the images through memfile-undo - because the user can undo to a state before the image existed (which currently frees the image cache).

This test patch shows how keeping the image cache stored as part of the undo system can fix the issue, P1103. This adds ID / undo users to MovieCache. There might be better ways to keep the data around between memfile undo's though.

The issue is the image cache sometimes gets freed by memfile undo, the image then gets reloaded and the undo tiles are applied on-top of the wrong image data. I looked into memfile undo image cache pointer map and it doesn't look like some mistake in the code causing this, in fact this works in most cases. It turns out it's not enough just to correctly remap the images through memfile-undo - because the user can undo to a state before the image existed (which currently frees the image cache). This test patch shows how keeping the image cache stored as part of the undo system can fix the issue, [P1103](https://archive.blender.org/developer/P1103.txt). This adds ID / undo users to `MovieCache`. There might be better ways to keep the data around between memfile undo's though.

Campbell Barton commented

2019-09-25 15:38:47 +02:00

Added subscribers: @Sergey, @brecht

Campbell Barton commented

2019-09-25 15:38:47 +02:00

Note, talked to @brecht and @Sergey - P1103 is too fragile.

I'm working on making the undo system store all image data, since the image cache isn't reliable enough to apply changes to.

Note, talked to @brecht and @Sergey - [P1103](https://archive.blender.org/developer/P1103.txt) is too fragile. I'm working on making the undo system store all image data, since the image cache isn't reliable enough to apply changes to.

blender-admin commented

2019-10-01 16:07:06 +02:00

This issue was referenced by 151cc02b6f

This issue was referenced by 151cc02b6f8234c94a65618ae0437403e1aba689

Campbell Barton commented

2019-10-01 16:50:04 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2019-10-01 16:50:04 +02:00

Campbell Barton commented

2019-10-18 17:22:47 +02:00

Added subscribers: @SethTooQuick, @linosia, @Wallis