Missing Camera settings in props except Depth of Field #61499

New Issue

yuri kabantsev · 2019-02-13T08:05:21+01:00

yuri kabantsev commented

2019-02-13 08:05:21 +01:00

Mac OS X, Blender 2.8, by 13 february beta

Mac OS X, Blender 2.8, by 13 february beta ![Screenshot 2019-02-13 at 09.45.13.jpg](https://archive.blender.org/developer/F6597136/Screenshot_2019-02-13_at_09.45.13.jpg)

yuri kabantsev commented

2019-02-13 08:05:21 +01:00

Added subscriber: @kabantsev

blender-admin commented

2019-02-13 08:05:21 +01:00

#61516 was marked as duplicate of this issue

Arsen Mikitov commented

2019-02-13 09:02:59 +01:00

Added subscriber: @ArsenMikitov

Arsen Mikitov commented

2019-02-13 09:02:59 +01:00

Similar problem. Camera settings are not displayed.

Blender 2.80 Beta for Linux 64 bit (February 13, 00:04:27 - 9a8a5676da)
Operating system: Ubuntu 18.04
Graphics card: RTX-2080Ti

Similar problem. Camera settings are not displayed. Blender 2.80 Beta for Linux 64 bit (February 13, 00:04:27 - 9a8a5676da82) Operating system: Ubuntu 18.04 Graphics card: RTX-2080Ti

Michael Soluyanov commented

2019-02-13 09:09:07 +01:00

Added subscriber: @crantisz

Michael Soluyanov commented

2019-02-13 09:09:08 +01:00

Same thing on Linux build:
Blender 2.80 (sub 44)
build date: 2019-02-13
build time: 00:01:56
build commit date: 2019-02-13
build commit time: 00:00
build hash: 9a8a5676da
build platform: Linux

Camera settings have "Lens" tab in EEVEE, but in Cycles haven't.

Same thing on Linux build: Blender 2.80 (sub 44) build date: 2019-02-13 build time: 00:01:56 build commit date: 2019-02-13 build commit time: 00:00 build hash: 9a8a5676da82 build platform: Linux Camera settings have "Lens" tab in EEVEE, but in Cycles haven't.

Rainer Trummer commented

2019-02-13 09:17:03 +01:00

Added subscriber: @RainerTrummer

Rainer Trummer commented

2019-02-13 09:17:03 +01:00

Seems like 'CYCLES' is missing in the COMPAT_ENGINES set in a few UI tabs like for instance the lens panel:

class DATA_PT_lens(CameraButtonsPanel, Panel):
    bl_label = "Lens"
    COMPAT_ENGINES = {'BLENDER_EEVEE', 'BLENDER_WORKBENCH'}

Seems like 'CYCLES' is missing in the COMPAT_ENGINES set in a few UI tabs like for instance the lens panel: ``` class DATA_PT_lens(CameraButtonsPanel, Panel): bl_label = "Lens" COMPAT_ENGINES = {'BLENDER_EEVEE', 'BLENDER_WORKBENCH'} ```

Philipp Oeser commented

2019-02-13 09:36:06 +01:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2019-02-13 09:36:06 +01:00

Philipp Oeser commented

2019-02-13 09:36:06 +01:00

Confirmed, checking...

Rainer Trummer commented

2019-02-13 09:59:26 +01:00

This comment was removed by @RainerTrummer

*This comment was removed by @RainerTrummer*

Rainer Trummer commented

2019-02-13 10:07:29 +01:00

What makes it a bit confusing is that panels which serve a similar purpose (and almost look the same in the UI) are spread across different files. Check for example the camera aperture one. The cycles UI for this is in the file ui.py:

class CYCLES_CAMERA_PT_dof_aperture(CyclesButtonsPanel, Panel):
    bl_label = "Aperture"
    bl_parent_id = "CYCLES_CAMERA_PT_dof"

    @classmethod
    def poll(cls, context):
        return context.camera and CyclesButtonsPanel.poll(context)

    def draw(self, context):
        layout = self.layout
        layout.use_property_split = True
        flow = layout.grid_flow(row_major=True, columns=0, even_columns=True, even_rows=False, align=False)

        cam = context.camera
        ccam = cam.cycles

        col = flow.column()
        col.prop(ccam, "aperture_type")
        if ccam.aperture_type == 'RADIUS':
            col.prop(ccam, "aperture_size", text="Size")
        elif ccam.aperture_type == 'FSTOP':
            col.prop(ccam, "aperture_fstop", text="Number")
        col.separator()

        col = flow.column()
        col.prop(ccam, "aperture_blades", text="Blades")
        col.prop(ccam, "aperture_rotation", text="Rotation")
        col.prop(ccam, "aperture_ratio", text="Ratio")

The Eevee counterpart however resides in properties_data_camera.py:

class DATA_PT_camera_dof_aperture(CameraButtonsPanel, Panel):
    bl_label = "Aperture"
    bl_parent_id = "DATA_PT_camera_dof"
    COMPAT_ENGINES = {'BLENDER_EEVEE', 'BLENDER_WORKBENCH'}

    def draw(self, context):
        layout = self.layout
        layout.use_property_split = True

        cam = context.camera
        dof_options = cam.gpu_dof

        flow = layout.grid_flow(row_major=True, columns=0, even_columns=True, even_rows=False, align=False)

        col = flow.column()
        col.prop(dof_options, "fstop")
        col.prop(dof_options, "blades")

        col = flow.column()
        col.prop(dof_options, "rotation")
        col.prop(dof_options, "ratio")

This isn't related to the bug, but it makes tracking such things down a bit cumbersome.

What makes it a bit confusing is that panels which serve a similar purpose (and almost look the same in the UI) are spread across different files. Check for example the camera aperture one. The cycles UI for this is in the file `ui.py`: ``` class CYCLES_CAMERA_PT_dof_aperture(CyclesButtonsPanel, Panel): bl_label = "Aperture" bl_parent_id = "CYCLES_CAMERA_PT_dof" @classmethod def poll(cls, context): return context.camera and CyclesButtonsPanel.poll(context) def draw(self, context): layout = self.layout layout.use_property_split = True flow = layout.grid_flow(row_major=True, columns=0, even_columns=True, even_rows=False, align=False) cam = context.camera ccam = cam.cycles col = flow.column() col.prop(ccam, "aperture_type") if ccam.aperture_type == 'RADIUS': col.prop(ccam, "aperture_size", text="Size") elif ccam.aperture_type == 'FSTOP': col.prop(ccam, "aperture_fstop", text="Number") col.separator() col = flow.column() col.prop(ccam, "aperture_blades", text="Blades") col.prop(ccam, "aperture_rotation", text="Rotation") col.prop(ccam, "aperture_ratio", text="Ratio") ``` The Eevee counterpart however resides in `properties_data_camera.py`: ``` class DATA_PT_camera_dof_aperture(CameraButtonsPanel, Panel): bl_label = "Aperture" bl_parent_id = "DATA_PT_camera_dof" COMPAT_ENGINES = {'BLENDER_EEVEE', 'BLENDER_WORKBENCH'} def draw(self, context): layout = self.layout layout.use_property_split = True cam = context.camera dof_options = cam.gpu_dof flow = layout.grid_flow(row_major=True, columns=0, even_columns=True, even_rows=False, align=False) col = flow.column() col.prop(dof_options, "fstop") col.prop(dof_options, "blades") col = flow.column() col.prop(dof_options, "rotation") col.prop(dof_options, "ratio") ``` This isn't related to the bug, but it makes tracking such things down a bit cumbersome.

blender-admin commented

2019-02-13 10:15:40 +01:00

This issue was referenced by 5e3838faa2

This issue was referenced by 5e3838faa2e6dae0ac52860085f5dc4b7a000ea5

Philipp Oeser commented

2019-02-13 10:23:48 +01:00

@RainerTrummer: cycles usually takes panels with BLENDER_RENDER as a compat engine into account, except for a few instances [like apertue as you mentioned]
check get_panels() in cycles addon to see which panels cycles excludes...

Anyways, D4346 should fix this for now [adding BLENDER_RENDER back].
Not sure if we should swap BLENDER_RENDER with CYCLES throughout ui scripts at one time...

@RainerTrummer: cycles usually takes panels with `BLENDER_RENDER` as a compat engine into account, except for a few instances [like apertue as you mentioned] check `get_panels()` in cycles addon to see which panels cycles excludes... Anyways, [D4346](https://archive.blender.org/developer/D4346) should fix this for now [adding `BLENDER_RENDER` back]. Not sure if we should swap `BLENDER_RENDER` with `CYCLES` throughout ui scripts at one time...

Rainer Trummer commented

2019-02-13 10:28:02 +01:00

@lichtwerk For the sake of avoiding historical confusion, swapping 'BLENDER_RENDER' with 'CYCLES' would make a lot of sense. At the moment it's a bit like 'Yeah I know, last year Blender Render was meant to be Blender Internal, but now it's Cycles'. Conversations like this can get a bit rough :) Anyways, not related to this. Thanks for the patch, will test it now.

Rainer Trummer commented

2019-02-13 10:34:14 +01:00

Seems to be fine, all properties are back.

Philipp Oeser commented

2019-02-13 10:36:36 +01:00

Added subscriber: @brecht

Philipp Oeser commented

2019-02-13 10:36:36 +01:00

@RainerTrummer : will wait for @brecht to decide if swapping 'BLENDER_RENDER' with 'CYCLES' is desired at this point (external) addons would probably require updates then...

Philipp Oeser commented

2019-02-13 12:35:24 +01:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-02-13 12:35:24 +01:00

Brecht Van Lommel commented

2019-02-13 17:19:10 +01:00

Added subscriber: @goodwinds

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Missing Camera settings in props except Depth of Field #61499