sculpt mode: uncheck "use deform only" doesn't work in some cases #62070

New Issue

Massimiliano Puliero · 2019-03-01T03:53:05+01:00

2019-03-01 03:53:05 +01:00

System Information
Operating system: windows 7 64bit
Graphics card: gtx 1070

Blender Version
Broken: blender-2.80.0-git.e5194835de45-windows64

Short description of error
in Solid mode is not possible to sculpt with the modifiers active.
It works fine only in Eevee "LookDev" and "Rendered"

Exact steps for others to reproduce the error
In the attached Blend file you will find suzanne with subsurface modifier applied and "use deform only" uchecked, I should see the model subdivided.
please check the attached blend file.
Thank you

sculpt_deformonly.blend

**System Information** Operating system: windows 7 64bit Graphics card: gtx 1070 **Blender Version** Broken: blender-2.80.0-git.e5194835de45-windows64 **Short description of error** in Solid mode is not possible to sculpt with the modifiers active. It works fine only in Eevee "LookDev" and "Rendered" **Exact steps for others to reproduce the error** In the attached Blend file you will find suzanne with subsurface modifier applied and "use deform only" uchecked, I should see the model subdivided. please check the attached blend file. Thank you [sculpt_deformonly.blend](https://archive.blender.org/developer/F6733627/sculpt_deformonly.blend)

Massimiliano Puliero commented

2019-03-01 03:53:05 +01:00

Added subscriber: @MassimilianoPuliero

blender-admin commented

2019-03-01 03:53:05 +01:00

#65198 was marked as duplicate of this issue

Sergey Sharybin was assigned by Sebastian Parborg

2019-03-02 14:36:02 +01:00

Sergey Sharybin removed their assignment 2019-03-08 15:55:10 +01:00

Clément Foucault was assigned by Sergey Sharybin

2019-03-08 15:55:10 +01:00

Sergey Sharybin commented

2019-03-08 15:55:10 +01:00

Added subscribers: @fclem, @Sergey

Sergey Sharybin commented

2019-03-08 15:55:10 +01:00

This seems to be related to the actual drawing, i can see all dependnecy graphs updates and tags.
In Blender 2.7 there was a special trick to see whether drawing should happen from PBVH or not: https://developer.blender.org/diffusion/B/browse/blender2.7/source/blender/blenkernel/intern/cdderivedmesh.c$241

If my observations are correct, we don't do it in draw manager.

@fclem, might having a look? ;)

This seems to be related to the actual drawing, i can see all dependnecy graphs updates and tags. In Blender 2.7 there was a special trick to see whether drawing should happen from PBVH or not: https://developer.blender.org/diffusion/B/browse/blender2.7/source/blender/blenkernel/intern/cdderivedmesh.c$241 If my observations are correct, we don't do it in draw manager. @fclem, might having a look? ;)

Clément Foucault was unassigned by Brecht Van Lommel

2019-03-26 14:10:50 +01:00

Jeroen Bakker was assigned by Brecht Van Lommel

2019-03-26 14:10:50 +01:00

Jeroen Bakker commented

2019-04-24 13:43:13 +02:00

Seems to be evaluated correctly for eevee, but not for the workbench.

This has todo with the workbench not checking the type of pbvh.

  const bool is_sculpt_mode = is_active && (draw_ctx->object_mode & OB_MODE_SCULPT) != 0;
  /* For now just force fully shaded with eevee when supported. */
  const bool is_sculpt_mode_draw = is_sculpt_mode &&
                                   ((ob->sculpt && ob->sculpt->pbvh) &&
                                    (BKE_pbvh_type(ob->sculpt->pbvh) != PBVH_FACES));

...

if (is_sculpt_mode && is_sculpt_mode_draw == false) {
     DRW_cache_mesh_sculpt_coords_ensure(ob);
}

Seems to be evaluated correctly for eevee, but not for the workbench. This has todo with the workbench not checking the type of pbvh. ``` const bool is_sculpt_mode = is_active && (draw_ctx->object_mode & OB_MODE_SCULPT) != 0; /* For now just force fully shaded with eevee when supported. */ const bool is_sculpt_mode_draw = is_sculpt_mode && ((ob->sculpt && ob->sculpt->pbvh) && (BKE_pbvh_type(ob->sculpt->pbvh) != PBVH_FACES)); ... if (is_sculpt_mode && is_sculpt_mode_draw == false) { DRW_cache_mesh_sculpt_coords_ensure(ob); } ```

Jeroen Bakker commented

2019-05-29 10:50:35 +02:00

Added subscriber: @BukolaLaditan

Brecht Van Lommel commented

2019-05-29 15:06:20 +02:00

Closed as duplicate of #64333

Brecht Van Lommel closed this issue

2019-05-29 15:06:20 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

sculpt mode: uncheck "use deform only" doesn't work in some cases #62070