Graph Editor generator for angles works in Radians while the graph editor displays the result in degrees. #62238

New Issue

Alaska · 2019-03-06T05:23:11+01:00

Alaska commented

2019-03-06 05:23:11 +01:00

System Information:
N/A

Blender Version
Broken: Blender 2.80 Beta (18e5540a48) and Blender 2.79 (e290a0b056)

Short description of error:
If you use the "generator" modifier in the graph editor for an angle, the generator will work in radians while the graph editor will display the output in degrees.

Exact steps for others to reproduce the error

Open the startup file.
Select the default cube and key frame one of the rotational axis.
Open a graph editor and give the "key framed rotation" an "generator" modifier.
When entering values into the modifier such as 0 and 1 so your polynomial is y=x, the result shown on the graph editor is y=57.3x. This is because the values input to the generator is read as radians while the scale in the graph editor is read in degrees.

**System Information:** N/A **Blender Version** Broken: Blender 2.80 Beta (18e5540a48b6) and Blender 2.79 (e290a0b0568e) **Short description of error:** If you use the "generator" modifier in the graph editor for an angle, the generator will work in radians while the graph editor will display the output in degrees. **Exact steps for others to reproduce the error** 1. Open the startup file. 2. Select the default cube and key frame one of the rotational axis. 3. Open a graph editor and give the "key framed rotation" an "generator" modifier. 4. When entering values into the modifier such as 0 and 1 so your polynomial is y=x, the result shown on the graph editor is y=57.3x. This is because the values input to the generator is read as radians while the scale in the graph editor is read in degrees. ![Screenshot from 2020-05-17 17-11-35.png](https://archive.blender.org/developer/F8539706/Screenshot_from_2020-05-17_17-11-35.png)

Alaska commented

2019-03-06 05:23:11 +01:00

Added subscriber: @Alaska

Joshua Leung was assigned by Sebastian Parborg

2019-03-06 10:57:21 +01:00

Joep Peters commented

2019-03-06 11:25:15 +01:00

Added subscriber: @schweppie

Joep Peters commented

2019-03-06 11:25:16 +01:00

I've made a patch: D4458

I've made a patch: [D4458](https://archive.blender.org/developer/D4458)

Joep Peters commented

2019-03-06 11:27:48 +01:00

Ah.. just after making the D4458 patch I noticed the assignment @JoshuaLeung

Ah.. just after making the [D4458](https://archive.blender.org/developer/D4458) patch I noticed the assignment @JoshuaLeung

Joshua Leung commented

2019-03-06 13:57:38 +01:00

From discussions with various people over the years, we've all consistently come to the conclusion that all of these things should always be evaluated in radians only, since that's technically how Blender stores + uses all rotation values internally, and it's also what all the math/trig functions in every standard math library work.

It is only for user convenience that we set the "display units" to degrees, to make it easier for artists to use. Technically, everything is really getting evaluated/interpreted in radians everywhere. In the graph editor, we usually apply some conversions to map between the two as necessary when dealing with rotation curves. Perhaps this case is getting skipped when doing the display unit adjustments when drawing the curve, but I'd have to check carefully to know.

From discussions with various people over the years, we've all consistently come to the conclusion that all of these things should always be evaluated in radians only, since that's technically how Blender stores + uses all rotation values internally, and it's also what all the math/trig functions in every standard math library work. It is only for user convenience that we set the "display units" to degrees, to make it easier for artists to use. Technically, everything is really getting evaluated/interpreted in radians everywhere. In the graph editor, we usually apply some conversions to map between the two as necessary when dealing with rotation curves. Perhaps this case is getting skipped when doing the display unit adjustments when drawing the curve, but I'd have to check carefully to know.

Joshua Leung was unassigned by Dalai Felinto

2019-12-23 16:34:57 +01:00

Dalai Felinto commented

2019-12-23 16:34:57 +01:00

Added subscriber: @JoshuaLeung

Alaska commented

2020-05-18 12:45:16 +02:00

Added subscriber: @dr.sybren

Alaska commented

2020-05-18 12:45:16 +02:00

@dr.sybren Do you believe this could be added to the "quick hacks" project? Or is it too complex? Or is this more of a design task.

Sybren A. Stüvel commented

2020-05-19 14:42:23 +02:00

@Alaska I can't really tell, it's a UI interface issue and I'm not familiar with the C UI code. It could be fairly simple to let the UI code determine that the FCurve represents an angular value, but then again it may not be.

hatinacat2000 commented

2020-09-09 04:31:48 +02:00

Added subscriber: @hatinacat2000

hatinacat2000 commented

2020-09-09 04:31:48 +02:00

I've been using 2.82 for a while and I have a bachelors in math. I love radians...when they are written as FRACTIONS.
Nobody knows what the hell these values are in decimals so it REALLY messes up our animation workflow to reverse-engineer stored angles when we need to make changes. Regardless of how these angles are stored internally, they should be displayed in degrees. At the very least, we should be able to enter new values in degrees.

I've been using 2.82 for a while and I have a bachelors in math. I love radians...when they are written as FRACTIONS. Nobody knows what the hell these values are in decimals so it REALLY messes up our animation workflow to reverse-engineer stored angles when we need to make changes. Regardless of how these angles are stored internally, they should be displayed in degrees. At the very least, we should be able to enter new values in degrees.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Graph Editor generator for angles works in Radians while the graph editor displays the result in degrees. #62238