Blender Crashing after "Clear Sharp" of a mesh #62324

New Issue

Yolao Heinz · 2019-03-07T17:35:23+01:00

Yolao Heinz commented

2019-03-07 17:35:23 +01:00

System Information
Operating system:
Graphics card:

Windows 7
GeForce GTX 650Ti

Blender Version
blender-2.80-a280867ac2ed-win64

Short description of error
Blender is crashing every time after i clear the sharps of a duplicated face of an object and the hitting undo.

Exact steps for others to reproduce the error

With the default Cube enter Edit Mode select all the edges "Ctrl + e" "Mark Sharp"
With the same edges selected "Ctrl + e" "Edge Bevel Weight" to 1
With the same edges selected "Shift + e" and crease the edges to 1.
Select one of the faces of the cube "Shift + D" to duplicate that face and then "P" "Selection" to separate that face into a mesh.
Select the newly created mesh from the face of the cube, enter edit mode, select all the edges and hot "Ctrl + e" > "Clear Sharp"
Enter object mode, hit "ctrl + z" for undo and Blender will crash intermediately. This happens always.

**System Information** Operating system: Graphics card: Windows 7 GeForce GTX 650Ti **Blender Version** blender-2.80-a280867ac2ed-win64 **Short description of error** Blender is crashing every time after i clear the sharps of a duplicated face of an object and the hitting undo. **Exact steps for others to reproduce the error** - With the default Cube enter Edit Mode select all the edges "Ctrl + e" "Mark Sharp" - With the same edges selected "Ctrl + e" "Edge Bevel Weight" to 1 - With the same edges selected "Shift + e" and crease the edges to 1. - Select one of the faces of the cube "Shift + D" to duplicate that face and then "P" "Selection" to separate that face into a mesh. - Select the newly created mesh from the face of the cube, enter edit mode, select all the edges and hot "Ctrl + e" > "Clear Sharp" - Enter object mode, hit "ctrl + z" for undo and Blender will crash intermediately. This happens always.

Yolao Heinz commented

2019-03-07 17:35:23 +01:00

Added subscriber: @Yolao

Philipp Oeser commented

2019-03-08 09:34:19 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-03-08 09:34:19 +01:00

Confirmed, checking...

Philipp Oeser commented

2019-03-08 09:55:01 +01:00

same backtrace as in #62318

Though this doesnt cause the crash alone:
As soon as you set any Edge Bevel Weight in editmode, then enter objectmode [no need to separate the face into a new object], I am getting:
write_customdata error: layer '':29 - can't be written to file

checking further...

same backtrace as in #62318 Though this doesnt cause the crash alone: As soon as you set any `Edge Bevel Weight` in editmode, then enter objectmode [no need to separate the face into a new object], I am getting: `write_customdata error: layer '':29 - can't be written to file` checking further...

Philipp Oeser commented

2019-03-08 10:12:44 +01:00

quick bandaid would be still need to check if this could also be handled [here ]
P930: T62324_snippet



diff --git a/source/blender/blenloader/intern/writefile.c b/source/blender/blenloader/intern/writefile.c
index c2cd6f282e8..603e68c8771 100644
--- a/source/blender/blenloader/intern/writefile.c
+++ b/source/blender/blenloader/intern/writefile.c
@@ -2126,7 +2126,7 @@ static void write_customdata(
 		else if (layer->type == CD_MDISPS) {
 			write_mdisps(wd, count, layer->data, layer->flag & CD_FLAG_EXTERNAL);
 		}
-		else if (layer->type == CD_PAINT_MASK) {
+		else if (ELEM(layer->type, CD_PAINT_MASK, CD_BWEIGHT)) {
 			const float *layer_data = layer->data;
 			writedata(wd, DATA, sizeof(*layer_data) * count, layer_data);
 		}

this will then not crash / prevent the 'corrupted' CD_BWEIGHT, but it is probably best to also put in a security check in the unfortunate case where this layer is indeed corrupted...

quick bandaid would be [still need to check if this could also be handled [here ]](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/writefile.c$2141) [P930: T62324_snippet](https://archive.blender.org/developer/P930.txt) ``` diff --git a/source/blender/blenloader/intern/writefile.c b/source/blender/blenloader/intern/writefile.c index c2cd6f282e8..603e68c8771 100644 --- a/source/blender/blenloader/intern/writefile.c +++ b/source/blender/blenloader/intern/writefile.c @@ -2126,7 +2126,7 @@ static void write_customdata( else if (layer->type == CD_MDISPS) { write_mdisps(wd, count, layer->data, layer->flag & CD_FLAG_EXTERNAL); } - else if (layer->type == CD_PAINT_MASK) { + else if (ELEM(layer->type, CD_PAINT_MASK, CD_BWEIGHT)) { const float *layer_data = layer->data; writedata(wd, DATA, sizeof(*layer_data) * count, layer_data); } ``` this will then not crash / prevent the 'corrupted' CD_BWEIGHT, but it is probably best to also put in a security check in the unfortunate case where this layer is indeed corrupted...

Sebastian Parborg commented

2019-03-08 10:20:00 +01:00

Closed as duplicate of #62318

Sebastian Parborg closed this issue

2019-03-08 10:20:00 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender Crashing after "Clear Sharp" of a mesh #62324