Saving with "Remap Relative" makes ALL paths relative #62612

New Issue

Sybren A. Stüvel · 2019-03-15T14:07:17+01:00

Sybren A. Stüvel commented

2019-03-15 14:07:17 +01:00

System Information
Operating system: Ubuntu Linux 18.04

Blender Version
Broken: e583e86a9a
Worked: not sure this ever worked correctly

Short description of error

I would expect that saving a file with the "Remap Relative" checkbox checked would only remap relative paths. However, it makes all paths relative.
This is an issue a the Blender Animation Studio, where often we reference files on /render that should never be remapped to //../../../../../render.

Exact steps for others to reproduce the error

Extract remap_relative_bug.zip into $SOMEDIR/subdir1
Open the blend file
Choose File > External Data > Make all paths absolute
Inspect the path of the image shown, it is$SOMEDIR/subdir1/background_caminandes_3_03.jpg
Save the blend file to $SOMEDIR/subdir2 and make sure the "Remap Relative" checkbox is checked
Inspect the path of the image shown, it is now //../subdir1/background_caminandes_3_03.jpg

**System Information** Operating system: Ubuntu Linux 18.04 **Blender Version** Broken: e583e86a9af458058fb2f92de6aaafb681756549 Worked: not sure this ever worked correctly **Short description of error** I would expect that saving a file with the "Remap Relative" checkbox checked would only remap relative paths. However, it makes **all** paths relative. This is an issue a the Blender Animation Studio, where often we reference files on `/render` that should never be remapped to `//../../../../../render`. **Exact steps for others to reproduce the error** - Extract [remap_relative_bug.zip](https://archive.blender.org/developer/F6829689/remap_relative_bug.zip) into `$SOMEDIR/subdir1` - Open the blend file - Choose File > External Data > Make all paths absolute - Inspect the path of the image shown, it is`$SOMEDIR/subdir1/background_caminandes_3_03.jpg` - Save the blend file to `$SOMEDIR/subdir2` and make sure the "Remap Relative" checkbox is checked - Inspect the path of the image shown, it is now `//../subdir1/background_caminandes_3_03.jpg`

Sybren A. Stüvel commented

2019-03-15 14:07:17 +01:00

Added subscriber: @dr.sybren

Sebastian Parborg commented

2019-03-15 16:41:34 +01:00

Added subscribers: @brecht, @ZedDB

Brecht Van Lommel was assigned by Sebastian Parborg

2019-03-15 16:41:34 +01:00

Sebastian Parborg commented

2019-03-15 16:41:34 +01:00

@brecht while the tooltip indeed says that it will remap relative paths, the code in question only skips relative paths and converts all non-relative paths.
So I'm guessing this is intended?

@brecht while the tooltip indeed says that it will remap relative paths, the code in question only skips relative paths and converts all non-relative paths. So I'm guessing this is intended?

Brecht Van Lommel removed their assignment 2019-03-15 17:19:05 +01:00

Campbell Barton was assigned by Brecht Van Lommel

2019-03-15 17:19:05 +01:00

Philipp Oeser commented

2019-03-15 17:27:57 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-03-15 17:27:57 +01:00

No description provided.

Brecht Van Lommel commented

2019-03-15 17:32:30 +01:00

Added subscriber: @mont29

Brecht Van Lommel commented

2019-03-15 17:32:30 +01:00

@ideasman42 or @mont29 probably know more, but as far as I know this is intended. At least when saving a .blend for the first time making absolute paths relative is important, since we want relative paths by default but can't do it when the file is not saved yet.

An additional option could be added to the operator. For many workflows it's also never right to make a path to a different root folder relative, there could be a preference for that. But those are not bugs.

@ideasman42 or @mont29 probably know more, but as far as I know this is intended. At least when saving a .blend for the first time making absolute paths relative is important, since we want relative paths by default but can't do it when the file is not saved yet. An additional option could be added to the operator. For many workflows it's also never right to make a path to a different root folder relative, there could be a preference for that. But those are not bugs.

Sybren A. Stüvel commented

2019-03-16 11:15:54 +01:00

I think there is at least one bug here -- either in the name & tooltip, or in the implementation, because right now they contradict each other.

At least when saving a .blend for the first time making absolute paths relative is important, since we want relative paths by default but can't do it when the file is not saved yet.

That's all fine. However, when changing the relative paths because the blend file is saved in a different location, I don't see why absolute paths need to be touched at all.

For many workflows it's also never right to make a path to a different root folder relative, there could be a preference for that. But those are not bugs.

I agree, that would be a welcome feature, not a bug.

I think there is at least one bug here -- either in the name & tooltip, or in the implementation, because right now they contradict each other. > At least when saving a .blend for the first time making absolute paths relative is important, since we want relative paths by default but can't do it when the file is not saved yet. That's all fine. However, when changing the relative paths because the blend file is saved in a different location, I don't see why absolute paths need to be touched at all. > For many workflows it's also never right to make a path to a different root folder relative, there could be a preference for that. But those are not bugs. I agree, that would be a welcome feature, not a bug.

blender-admin commented

2019-03-18 03:57:16 +01:00

This issue was referenced by 6c0240e84a

This issue was referenced by 6c0240e84a2c06af506697242e0ba42fa4998ee5

Campbell Barton commented

2019-03-18 03:59:15 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2019-03-18 03:59:15 +01:00

Campbell Barton commented

2019-03-18 04:00:20 +01:00

what @brecht and @dr.sybren said: nice to support but with so many open bugs, clarify tooltip for now.

Sybren A. Stüvel commented

2019-03-18 15:33:52 +01:00

Changed status from 'Resolved' to: 'Open'

Sybren A. Stüvel reopened this issue

2019-03-18 15:33:52 +01:00

Sybren A. Stüvel commented

2019-03-18 15:33:52 +01:00

This seems to be a "make things consistent for now, fix properly later" kind of thing, so this task should remain open until it's properly addressed. The label of the checkbox hasn't changed, so "remap relative" still means "remap everything".

This is not just me being pedantic about a label on a checkbox. There are often cases where absolute paths are silently and unexpectedly turned into relative paths here in the studio. We use absolute vs. relative to determine which files should be BAT-packed when sent to the local farm (absolute paths are not packed, because workers can reach them at that path). Having absolute paths changed to relative causes files to be unnecessarily copied to the render farm; referencing blend files are then also rewritten to have their paths remapped. This causes an unnecessary increase in storage requirements and unnecessary delays for our artists.

This seems to be a "make things consistent for now, fix properly later" kind of thing, so this task should remain open until it's properly addressed. The label of the checkbox hasn't changed, so "remap relative" still means "remap everything". This is not just me being pedantic about a label on a checkbox. There are often cases where absolute paths are silently and unexpectedly turned into relative paths here in the studio. We use absolute vs. relative to determine which files should be BAT-packed when sent to the local farm (absolute paths are not packed, because workers can reach them at that path). Having absolute paths changed to relative causes files to be unnecessarily copied to the render farm; referencing blend files are then also rewritten to have their paths remapped. This causes an unnecessary increase in storage requirements and unnecessary delays for our artists.

John commented

2019-12-01 14:44:04 +01:00

Added subscriber: @John514

blender-admin commented

2020-02-18 12:03:07 +01:00

This issue was referenced by f7386b9757

This issue was referenced by f7386b97571e0207281f4504f45e13d4beb1c25b

Campbell Barton commented

2020-02-18 12:14:59 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2020-02-18 12:14:59 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Saving with "Remap Relative" makes ALL paths relative #62612