Shape key 008 has wrong frame time when created from python script #63326

New Issue

Arno Mayrhofer · 2019-04-06T00:19:53+02:00

Arno Mayrhofer commented

2019-04-06 00:19:53 +02:00

System Information
Operating system: Ubuntu 18.04
Graphics card: Built in Intel GP

Blender Version
Broken: version: 2.80 (sub 53), branch: blender2.7, commit date: 2019-04-03 23:27, hash: 0e78e3038d, type: Release
Worked: unknown

Short description of error
When creating a mesh from a python script and adding shape keys in a loop Key.008 has frame = 70 instead of 80. (all others are correct)

Exact steps for others to reproduce the error
Based on the default startup run the following script. The script is the default template to add an object and only has a few minor changes marked in a commented block.

bl_info = {
    "name": "New Object",
    "author": "Your Name Here",
    "version": (1, 0),
    "blender": (2, 80, 0),
    "location": "View3D > Add > Mesh > New Object",
    "description": "Adds a new Mesh Object",
    "warning": "",
    "wiki_url": "",
    "category": "Add Mesh",
}


import bpy
from bpy.types import Operator
from bpy.props import FloatVectorProperty
from bpy_extras.object_utils import AddObjectHelper, object_data_add
from mathutils import Vector


def add_object(self, context):
    scale_x = self.scale.x
    scale_y = self.scale.y

    verts = [
        Vector((-1 * scale_x, 1 * scale_y, 0)),
        Vector((1 * scale_x, 1 * scale_y, 0)),
        Vector((1 * scale_x, -1 * scale_y, 0)),
        Vector((-1 * scale_x, -1 * scale_y, 0)),
    ]

    edges = []
    faces = [[0, 1, 2, 3]]

    mesh = bpy.data.meshes.new(name="New Object Mesh")
    mesh.from_pydata(verts, edges, faces)
    - useful for development when the mesh may be invalid.
    - mesh.validate(verbose=True)
    object_data_add(context, mesh, operator=self)

    ##########
    - added code to generate shape keys

    ob = bpy.context.object
    ob.shape_key_add()
    ob.data.shape_keys.use_relative = False
    for i in range(10):
        ob.shape_key_add()
        ob.active_shape_key_index = i+1
        ob.data.shape_keys.eval_time = 10*(i+1)

    - end added code
    ##########


class OBJECT_OT_add_object(Operator, AddObjectHelper):
    """Create a new Mesh Object"""
    bl_idname = "mesh.add_object"
    bl_label = "Add Mesh Object"
    bl_options = {'REGISTER', 'UNDO'}

    scale: FloatVectorProperty(
        name="scale",
        default=(1.0, 1.0, 1.0),
        subtype='TRANSLATION',
        description="scaling",
    )

    def execute(self, context):

        add_object(self, context)

        return {'FINISHED'}


# Registration

def add_object_button(self, context):
    self.layout.operator(
        OBJECT_OT_add_object.bl_idname,
        text="Add Object",
        icon='PLUGIN')


# This allows you to right click on a button and link to the manual
def add_object_manual_map():
    url_manual_prefix = "https://docs.blender.org/manual/en/dev/"
    url_manual_mapping = (
        ("bpy.ops.mesh.add_object", "editors/3dview/object"),
    )
    return url_manual_prefix, url_manual_mapping


def register():
    bpy.utils.register_class(OBJECT_OT_add_object)
    bpy.utils.register_manual_map(add_object_manual_map)
    bpy.types.VIEW3D_MT_mesh_add.append(add_object_button)


def unregister():
    bpy.utils.unregister_class(OBJECT_OT_add_object)
    bpy.utils.unregister_manual_map(add_object_manual_map)
    bpy.types.VIEW3D_MT_mesh_add.remove(add_object_button)


if __name__ == "__main__":
    register()

Once the script was run, perform the adding of the object (Add->Mesh->Add Object) and investigate the shape keys. The output I get is the following:

Clearly, Key.008 should have a frame value of 80 instead of 70. All the other keys are fine.

I actually have a more complicated script that actually modifies the mesh across those keys and the animation really is broken at this frame.

**System Information** Operating system: Ubuntu 18.04 Graphics card: Built in Intel GP **Blender Version** Broken: version: 2.80 (sub 53), branch: blender2.7, commit date: 2019-04-03 23:27, hash: 0e78e3038d02, type: Release Worked: unknown **Short description of error** When creating a mesh from a python script and adding shape keys in a loop Key.008 has frame = 70 instead of 80. (all others are correct) **Exact steps for others to reproduce the error** Based on the default startup run the following script. The script is the default template to add an object and only has a few minor changes marked in a commented block. ``` bl_info = { "name": "New Object", "author": "Your Name Here", "version": (1, 0), "blender": (2, 80, 0), "location": "View3D > Add > Mesh > New Object", "description": "Adds a new Mesh Object", "warning": "", "wiki_url": "", "category": "Add Mesh", } import bpy from bpy.types import Operator from bpy.props import FloatVectorProperty from bpy_extras.object_utils import AddObjectHelper, object_data_add from mathutils import Vector def add_object(self, context): scale_x = self.scale.x scale_y = self.scale.y verts = [ Vector((-1 * scale_x, 1 * scale_y, 0)), Vector((1 * scale_x, 1 * scale_y, 0)), Vector((1 * scale_x, -1 * scale_y, 0)), Vector((-1 * scale_x, -1 * scale_y, 0)), ] edges = [] faces = [[0, 1, 2, 3]] mesh = bpy.data.meshes.new(name="New Object Mesh") mesh.from_pydata(verts, edges, faces) - useful for development when the mesh may be invalid. - mesh.validate(verbose=True) object_data_add(context, mesh, operator=self) ########## - added code to generate shape keys ob = bpy.context.object ob.shape_key_add() ob.data.shape_keys.use_relative = False for i in range(10): ob.shape_key_add() ob.active_shape_key_index = i+1 ob.data.shape_keys.eval_time = 10*(i+1) - end added code ########## class OBJECT_OT_add_object(Operator, AddObjectHelper): """Create a new Mesh Object""" bl_idname = "mesh.add_object" bl_label = "Add Mesh Object" bl_options = {'REGISTER', 'UNDO'} scale: FloatVectorProperty( name="scale", default=(1.0, 1.0, 1.0), subtype='TRANSLATION', description="scaling", ) def execute(self, context): add_object(self, context) return {'FINISHED'} # Registration def add_object_button(self, context): self.layout.operator( OBJECT_OT_add_object.bl_idname, text="Add Object", icon='PLUGIN') # This allows you to right click on a button and link to the manual def add_object_manual_map(): url_manual_prefix = "https://docs.blender.org/manual/en/dev/" url_manual_mapping = ( ("bpy.ops.mesh.add_object", "editors/3dview/object"), ) return url_manual_prefix, url_manual_mapping def register(): bpy.utils.register_class(OBJECT_OT_add_object) bpy.utils.register_manual_map(add_object_manual_map) bpy.types.VIEW3D_MT_mesh_add.append(add_object_button) def unregister(): bpy.utils.unregister_class(OBJECT_OT_add_object) bpy.utils.unregister_manual_map(add_object_manual_map) bpy.types.VIEW3D_MT_mesh_add.remove(add_object_button) if __name__ == "__main__": register() ``` Once the script was run, perform the adding of the object (Add->Mesh->Add Object) and investigate the shape keys. The output I get is the following: ![Screenshot from 2019-04-06 00-14-36.png](https://archive.blender.org/developer/F6914321/Screenshot_from_2019-04-06_00-14-36.png) Clearly, Key.008 should have a frame value of 80 instead of 70. All the other keys are fine. I actually have a more complicated script that actually modifies the mesh across those keys and the animation really is broken at this frame.

Arno Mayrhofer commented

2019-04-06 00:19:53 +02:00

Added subscriber: @azrael3000

Arno Mayrhofer commented

2019-04-06 12:24:32 +02:00

Fix for this issue can be found in D4656. Cause was a floating point comparison and associated precision issues.

Fix for this issue can be found in [D4656](https://archive.blender.org/developer/D4656). Cause was a floating point comparison and associated precision issues.

Sebastian Parborg commented

2019-04-07 18:07:45 +02:00

Added subscriber: @ZedDB

Arno Mayrhofer was assigned by Sebastian Parborg

2019-04-07 18:07:45 +02:00

Sebastian Parborg commented

2019-04-07 18:07:45 +02:00

I'll assign this to you are you already have come up with a solution. Good job!