Undoing the removal of a vertex group in edit mode changes other vertex groups and doesnt bring the removed vertex group back #63434

Open
opened 2019-04-09 20:13:02 +02:00 by Zachary · 18 comments

System Information
Operating system: Linux-5.4.13-201.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.44

Blender Version
Broken: version: 2.83 (sub 2), branch: master (modified), commit date: 2020-02-06 03:03, hash: 02226ef653
Worked: (optional)

Short description of error
Undoing a vertex group changes the rest. The video should show the issue. There's 3 vertex groups, A = A, B = B and C = C. If you delete A, B = B and C = C. If you delete A and then undo it, B = A and C = B.

https://youtu.be/Ty9U5rj_6Sw

#63434.blend

  • Open File
  • you should be in editmode
  • remove the zero_weight vertex group
  • Undo {key Ctrl Z}
  • zero_weight vertex group is not back
  • half_weight vertex group now has zero weights
  • full_weight vertex group now has half weights
**System Information** Operating system: Linux-5.4.13-201.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.44 **Blender Version** Broken: version: 2.83 (sub 2), branch: master (modified), commit date: 2020-02-06 03:03, hash: `02226ef653` Worked: (optional) **Short description of error** Undoing a vertex group changes the rest. The video should show the issue. There's 3 vertex groups, A = A, B = B and C = C. If you delete A, B = B and C = C. If you delete A and then undo it, B = A and C = B. https://youtu.be/Ty9U5rj_6Sw [#63434.blend](https://archive.blender.org/developer/F8325231/T63434.blend) - Open File - you should be in editmode - remove the `zero_weight` vertex group - Undo {key Ctrl Z} - `zero_weight` vertex group is not back - `half_weight` vertex group now has zero weights - `full_weight` vertex group now has half weights
Author

Added subscriber: @AFWS

Added subscriber: @AFWS

Added subscriber: @ZedDB

Added subscriber: @ZedDB

I can't reproduce this on my end.
recording.mp4

Is there anything I'm doing wrong?

I can't reproduce this on my end. [recording.mp4](https://archive.blender.org/developer/F6923552/recording.mp4) Is there anything I'm doing wrong?
Author

@ZedDB

Try doing it in edit mode. I see you're doing this in weight paint mode. I can get the same results as you if I'm in weight paint. Looks like this is a undo issue in edit mode.

@ZedDB Try doing it in edit mode. I see you're doing this in weight paint mode. I can get the same results as you if I'm in weight paint. Looks like this is a undo issue in edit mode.
Zachary changed title from Undoing a vertex group changes the rest to Undoing a vertex group in edit mode 2019-04-10 14:32:27 +02:00
Campbell Barton was assigned by Sebastian Parborg 2019-04-10 15:35:57 +02:00

Right, if you are in edit mode it breaks.

Right, if you are in edit mode it breaks.
Campbell Barton was unassigned by Dalai Felinto 2019-12-23 16:34:43 +01:00

Added subscriber: @ideasman42

Added subscriber: @ideasman42

Added subscriber: @iss

Added subscriber: @iss

Changed status from 'Confirmed' to: 'Needs User Info'

Changed status from 'Confirmed' to: 'Needs User Info'

I have re-triaged this report and can not reproduce it (even in edit mode).
Can you please check if this is still an issue in latest build?
https://builder.blender.org/download/

I have re-triaged this report and can not reproduce it (even in edit mode). Can you please check if this is still an issue in latest build? https://builder.blender.org/download/
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'
Member

Can confirm, still an issue, will update report with example file and better repro steps

Can confirm, still an issue, will update report with example file and better repro steps
Philipp Oeser changed title from Undoing a vertex group in edit mode to Undoing the removal of a vertex group in edit mode changes other vertex groups and doesnt bring the removed vertex group back 2020-02-06 10:51:15 +01:00

Added subscriber: @mont29

Added subscriber: @mont29

This is a known issue actually, caused by design flaw in vgroups (they are stored partly in mesh, partly in object). Edit mesh undo steps cannot store undo data for anything else than the mesh, so to support this we'd need to either store a global memfile undo step (which is not possible currently in Edit mode afaik).

Workaround for now could be to forbid editing vgroup list in Edit mode, don't see anything we can do otherwise without some rather severe rework of part of undo code, which goes beyond a bugfix.

This is a known issue actually, caused by design flaw in vgroups (they are stored partly in mesh, partly in object). Edit mesh undo steps cannot store undo data for anything else than the mesh, so to support this we'd need to either store a global memfile undo step (which is not possible currently in Edit mode afaik). Workaround for now could be to forbid editing vgroup list in Edit mode, don't see anything we can do otherwise without some rather severe rework of part of undo code, which goes beyond a bugfix.
Member

Added subscriber: @HDMaster84

Added subscriber: @HDMaster84
Member

@mont29 Even if undo of vertex group can be considered a known issue, the silent corruption of all the other vertex groups should be considered a bug and should get fixed (maybe by disabling the undo behavior here completely?).

@mont29 Even if undo of vertex group can be considered a known issue, the silent corruption of all the other vertex groups should be considered a bug and should get fixed (maybe by disabling the undo behavior here completely?).

@HDMaster84 If you do have time to work on this, please feel free to assign it to yourself and then move this to bug. By definition 'bugs' are issues that are intended to be fixed within a reasonable time, otherwise (especially when current design is at core of the issue), they are 'known issues'.

@HDMaster84 If you do have time to work on this, please feel free to assign it to yourself and then move this to bug. By definition 'bugs' are issues that are intended to be fixed within a reasonable time, otherwise (especially when current design is at core of the issue), they are 'known issues'.
Philipp Oeser removed the
Interest
Modeling
label 2023-02-09 15:29:54 +01:00

This is a very scary bug. You are so used to Undo being able to undo any silly mistake you do, or temporary experiments... until it doesn't like in this case. Luckily there is autosave. (But now that I know about this bug I will know to be very careful when manipulating vertex groups in the future.)

This is a very scary bug. You are so used to Undo being able to undo any silly mistake you do, or temporary experiments... until it doesn't like in this case. Luckily there is autosave. (But now that I know about this bug I will know to be very careful when manipulating vertex groups in the future.)
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
8 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#63434
No description provided.