Renaming of Vertex Groups not possible in complex projects #63650

New Issue

Thomas Huk · 2019-04-16T09:42:56+02:00

Thomas Huk commented

2019-04-16 09:42:56 +02:00

Blender Version
Broken: blender 2.80rc1
Worked: 2.79b

Short description of error
Renaming of Vertex Groups not possible in complex projects

Exact steps for others to reproduce the error

Open Bug_vertexGroupsRenaming.blend
Double click to try to rename the Vertex Group
or
Start New File
add a vertex group (renaming is still possible)
add an emitter (in this case: hair)
increase the number: If the number is set to 100000
renaming of the vertex group is not possible

**Blender Version** Broken: blender 2.80rc1 Worked: 2.79b **Short description of error** Renaming of Vertex Groups not possible in complex projects **Exact steps for others to reproduce the error** - Open [Bug_vertexGroupsRenaming.blend](https://archive.blender.org/developer/F6950743/Bug_vertexGroupsRenaming.blend) - Double click to try to rename the Vertex Group or - Start New File - add a vertex group (renaming is still possible) - add an emitter (in this case: hair) - increase the number: If the number is set to 100000 - renaming of the vertex group is not possible

Thomas Huk commented

2019-04-16 09:42:56 +02:00

Added subscriber: @Hucky

blender-admin commented

2019-04-16 09:42:56 +02:00

#64824 was marked as duplicate of this issue

Dspazio commented

2019-04-16 10:18:13 +02:00

Added subscriber: @Dspazio

Dspazio commented

2019-04-16 10:18:14 +02:00

Can confirm on latest build. On lessen performant machines are specially remarkable (tested on centrino, 4gb RAM, intel iGPU). I tried "triple click" :D and it worked!. Seems related to some sort of buffer issue when blender is busy (this is purely speculative and can be erroneous). Thanks!

Sebastian Parborg commented

2019-04-16 13:45:09 +02:00

Added subscribers: @WilliamReynish, @ZedDB

William Reynish was assigned by Sebastian Parborg

2019-04-16 13:45:09 +02:00

Sebastian Parborg commented

2019-04-16 13:45:09 +02:00

I can confirm that I have to spam click to get it to rename. Without the heavy hair system, as simple double click will do.

@WilliamReynish feel free to reassign if this doesn't fall into the UI category.

I can confirm that I have to spam click to get it to rename. Without the heavy hair system, as simple double click will do. @WilliamReynish feel free to reassign if this doesn't fall into the `UI` category.

Jacques Lucke commented

2019-04-16 14:48:24 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-04-16 14:48:24 +02:00

The problem is that there is some depsgraph update here. That evaluates the modifiers and therefore the hair as well.
It loops over all particles.

Feels like the issue is that the depsgraph is evaluated when one starts editing the name of the vertex group.

The problem is that there is some depsgraph update here. That evaluates the modifiers and therefore the hair as well. It loops over all particles. Feels like the issue is that the depsgraph is evaluated when one starts editing the name of the vertex group.

William Reynish was unassigned by Brecht Van Lommel

2019-04-16 14:49:53 +02:00

Brecht Van Lommel commented

2019-04-16 14:59:15 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-04-16 14:59:15 +02:00

This is a task for a developer to fix, not a UI design issue I think.

Changing the vertex group name should update the dependency graph, because bones and vertex groups are linked by name. I think the problem is that the first click is for changing the active vertex group, which can affect the viewport in weight paint mode for example.

There are a few things that could be improved here:

If a vertex group is already active, then clicking it again should not cause any depsgraph update. (probably simple)
Ideally changing the active vertex group would have more fine-grained tagging so it doesn't affect anything when it doesn't affect any viewport. (may be simple if it's a matter of checking if the object is in weight paint mode in the RNA update function, would need to be checked)
Events coming from GHOST should ideally have a timestamp, and that timestamp should be used to determine the double clicking time. (too much work to handle as a bug report)

This is a task for a developer to fix, not a UI design issue I think. Changing the vertex group name should update the dependency graph, because bones and vertex groups are linked by name. I think the problem is that the first click is for changing the active vertex group, which can affect the viewport in weight paint mode for example. There are a few things that could be improved here: 1) If a vertex group is already active, then clicking it again should not cause any depsgraph update. (probably simple) 2) Ideally changing the active vertex group would have more fine-grained tagging so it doesn't affect anything when it doesn't affect any viewport. (may be simple if it's a matter of checking if the object is in weight paint mode in the RNA update function, would need to be checked) 3) Events coming from GHOST should ideally have a timestamp, and that timestamp should be used to determine the double clicking time. (too much work to handle as a bug report)

Jacques Lucke commented

2019-04-16 16:31:06 +02:00

This is probably related: #63537

Brecht Van Lommel commented

2019-05-23 02:34:34 +02:00

Added subscriber: @finnb

Finn Bear commented

2019-05-23 06:26:22 +02:00

In #63650#661780, @brecht wrote:
Changing the vertex group name should update the dependency graph, because bones and vertex groups are linked by name.

Am I correct that that the operation of renaming has two parts:

Getting the cursor with a double click
Actually changing the name after ENTER or something is pressed

If I understand correctly, (2) is the only thing that needs a non-UI update.

> In #63650#661780, @brecht wrote: > Changing the vertex group name should update the dependency graph, because bones and vertex groups are linked by name. Am I correct that that the operation of renaming has two parts: 1) Getting the cursor with a double click 2) Actually changing the name after ENTER or something is pressed If I understand correctly, (2) is the only thing that needs a non-UI update.

Brecht Van Lommel commented

2019-05-23 09:41:33 +02:00

The issue is that on double click two different things are done:

On the first click, it makes the item active which require a dependency graph update.
On the second click, it starts renaming.

It's not the renaming that's the problem, but the making active that happens right before that.

The issue is that on double click two different things are done: * On the first click, it makes the item active which require a dependency graph update. * On the second click, it starts renaming. It's not the renaming that's the problem, but the making active that happens right before that.

Germano Cavalcante commented

2020-01-29 18:21:42 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-01-29 18:21:42 +01:00

I can confirm in blender 2.83
In the attached file, if you add a second vertex group and try to switch the selection, you may notice a delay that may be related.

I can confirm in blender 2.83 In the attached file, if you add a second vertex group and try to switch the selection, you may notice a delay that may be related.

Philipp Oeser commented

2021-06-09 19:21:37 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-06-09 19:21:37 +02:00

I have updated #40009 (Double click list renaming not working on heavy scenes) with the relevant comment from this report, but this one is really a duplicate, will merge.

Philipp Oeser commented

2021-06-09 19:21:51 +02:00

Closed as duplicate of #40009

Philipp Oeser closed this issue

2021-06-09 19:21:51 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Renaming of Vertex Groups not possible in complex projects #63650