Alt-M for merging vertices bail out #63781

Closed
opened 2019-04-21 12:33:25 +02:00 by yves bodson · 9 comments

System Information
Operating system: Linux-4.18.0-17-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116

Blender Version
Broken: version: 2.80 (sub 58), branch: master, commit date: 2019-04-21 09:39, hash: c8fc23fdbe
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]
I am using Alt-M to merge vertices on a model.
The process goes as follow : I select two vertices, Alt-M, select merge at center. the merging happens but then when I move the cursor to the next vertices to merge, Blender bails out. Crash.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]
On the attached blend file, one can select to vertices from the mesh that is in edit mode. do Alt-M and select At center. The merging happen. Do AA to deselect everything, the move the cursor to the next pair of vertices to merge. At that time Blender bails out. Or it may have bailed out on the motion of the curosr.. This is only when doing merging processes. Otherwise I did not experience the crash.

**System Information** Operating system: Linux-4.18.0-17-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116 **Blender Version** Broken: version: 2.80 (sub 58), branch: master, commit date: 2019-04-21 09:39, hash: `c8fc23fdbe` Worked: (optional) **Short description of error** [Please fill out a short description of the error here] I am using Alt-M to merge vertices on a model. The process goes as follow : I select two vertices, Alt-M, select merge at center. the merging happens but then when I move the cursor to the next vertices to merge, Blender bails out. Crash. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] On the attached blend file, one can select to vertices from the mesh that is in edit mode. do Alt-M and select At center. The merging happen. Do AA to deselect everything, the move the cursor to the next pair of vertices to merge. At that time Blender bails out. Or it may have bailed out on the motion of the curosr.. This is only when doing merging processes. Otherwise I did not experience the crash.
Author

Added subscriber: @YvesBodson

Added subscriber: @YvesBodson
Author
[system-info.txt](https://archive.blender.org/developer/F6963740/system-info.txt) [28 Lilly muguet branches V_04 _01-03.blend](https://archive.blender.org/developer/F6963741/28_Lilly_muguet_branches_V_04__01-03.blend) [blender28_debug.txt](https://archive.blender.org/developer/F6963743/blender28_debug.txt)

Added subscribers: @fclem, @Gvgeo-1

Added subscribers: @fclem, @Gvgeo-1
Clément Foucault was assigned by George Vogiatzis 2019-04-22 21:42:14 +02:00

@fclem The problem starts with commit 223f7e79f9 (need the file to replicate).

in DRW_cache_free_old_batches(Main *bmain)
in DEG_OBJECT_ITER_BEGIN (depsgraph, ob, iter_flags)

_NODISCARD size_type size() const noexcept
		{	// return length of sequence
		return (static_cast<size_type>(this->_Mylast() - this->_Myfirst()));   <------------------error
		}

I get this error:

 **std::_Vector_alloc<std::_Vec_base_types<DEG::IDNode * __ptr64,std::allocator<DEG::IDNode * __ptr64> > >::_Myfirst**(...) returned 0x10.
@fclem The problem starts with commit 223f7e79f9 (need the file to replicate). in DRW_cache_free_old_batches(Main *bmain) in DEG_OBJECT_ITER_BEGIN (depsgraph, ob, iter_flags) ``` _NODISCARD size_type size() const noexcept { // return length of sequence return (static_cast<size_type>(this->_Mylast() - this->_Myfirst())); <------------------error } ``` I get this error: ``` **std::_Vector_alloc<std::_Vec_base_types<DEG::IDNode * __ptr64,std::allocator<DEG::IDNode * __ptr64> > >::_Myfirst**(...) returned 0x10. ```

@fclem Almost forgot.
Because DRW_cache_free_old_batches runs only when there is a screen refresh, you may want to change this line.

  if (ctime % DRW_BATCH_COLLECTION_RATE || ctime == lasttime)
    return;

Right now is a little bit random.

@fclem Almost forgot. Because `DRW_cache_free_old_batches `runs only when there is a screen refresh, you may want to change this line. ``` if (ctime % DRW_BATCH_COLLECTION_RATE || ctime == lasttime) return; ``` Right now is a little bit random.

The problem I mention was fixed, with 5a144c797a.

But I noticed this part:

This is only when doing merging processes. Otherwise I did not experience the crash.

@YvesBodson Is your problem fixed? Or still having crashes?

The problem I mention was fixed, with 5a144c797a3b. But I noticed this part: > This is only when doing merging processes. Otherwise I did not experience the crash. @YvesBodson Is your problem fixed? Or still having crashes?
Author

Hello
I have downloaded the latest release of 2.8 and did test for the Alt-M behavior. It works fine.
I have tested again with the previous versions and got the issue so the fix is correct.
Thank you for your help and very efficient solution
The issue may be close.
Take care

Hello I have downloaded the latest release of 2.8 and did test for the Alt-M behavior. It works fine. I have tested again with the previous versions and got the issue so the fix is correct. Thank you for your help and very efficient solution The issue may be close. Take care

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

fixed 5a144c797a

@YvesBodson thanks for checking it out.

fixed 5a144c797a3b @YvesBodson thanks for checking it out.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#63781
No description provided.