Make Delete in the File Browser use the system Trash #64104

New Issue

William Reynish · 2019-05-03T13:51:18+02:00

William Reynish commented

2019-05-03 13:51:18 +02:00

Related to bug report #61412.

Deleting in the File Browser is currently a highly dangerous and destructive action.

Rather than hard deleting, we should use the correct API's to move items to the system trash in the various OS's we support.

If this is not easily possible, we should disable deleting inside the File Browser for those platforms in the meantime. It's currently too easy to permanently lose large chunks of user hard drive contents with no remedy to get it back, which is not acceptable.

Related to bug report #61412. Deleting in the File Browser is currently a highly dangerous and destructive action. Rather than hard deleting, we should use the correct API's to move items to the system trash in the various OS's we support. If this is not easily possible, we should disable deleting inside the File Browser for those platforms in the meantime. It's currently too easy to permanently lose large chunks of user hard drive contents with no remedy to get it back, which is not acceptable.

William Reynish commented

2019-05-03 13:51:18 +02:00

Added subscriber: @WilliamReynish

William Reynish commented

2019-05-05 15:19:17 +02:00

To me this issue seems so egregious that we should not ship without this being addressed.

If it's too much of a hassle to add this for all platforms, we could start by simply disabling the ability to delete data from the File Browser, until we can do it in a way that doesn't make it easy to accidentally permanently erase your entire hard drive.

To me this issue seems so egregious that we should not ship without this being addressed. If it's too much of a hassle to add this for all platforms, we could start by simply disabling the ability to delete data from the File Browser, until we can do it in a way that doesn't make it easy to accidentally permanently erase your entire hard drive.

William Reynish commented

2019-05-15 13:47:27 +02:00

Main dangerous issue is now addressed. Adding support for system trash is still a useful task though, for later.

Bastien Montagne commented

2019-05-15 14:56:29 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2019-05-15 14:56:29 +02:00

TBH, I would not even bother adding that back (I thought that had been removed already, when the 'delete' button was removed from the header)… Blender is not exactly a filebrowser, being able to add directories is handy, but imho that’s enough.

File (asset) deletion should rather be handled by asset engines, in a secure/specific way matching each asset engine's pipeline, but we should not try to support all OS filesystem features, really.

TBH, I would not even bother adding that back (I thought that had been removed already, when the 'delete' button was removed from the header)… Blender is not exactly a filebrowser, being able to *add* directories is handy, but imho that’s enough. File (asset) deletion should rather be handled by asset engines, in a secure/specific way matching each asset engine's pipeline, but we should not try to support all OS filesystem features, really.

William Reynish commented

2019-05-15 15:02:20 +02:00

@mont29 yes it’s a low priority item I agree. I could even remove this task completely, and it’s not even so much UI-related.

Could be nice to eventually add this in a better way but I also don’t think it’s a big deal if we don’t.

@mont29 yes it’s a low priority item I agree. I could even remove this task completely, and it’s not even so much UI-related. Could be nice to eventually add this in a better way but I also don’t think it’s a big deal if we don’t.

Robert Guetzkow commented

2019-05-15 15:06:05 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2019-05-15 15:06:05 +02:00

@mont29 @WilliamReynish Sorry I've been sick and couldn't work on the patch D4585. This may have to wait some more until I have an empty backlog.

@mont29 @WilliamReynish Sorry I've been sick and couldn't work on the patch [D4585](https://archive.blender.org/developer/D4585). This may have to wait some more until I have an empty backlog.

Brain McBlender commented

2019-11-04 21:49:16 +01:00

Added subscriber: @blender_mac

Brain McBlender commented

2019-11-04 21:49:16 +01:00

so removing basic abilities, that people are used to having in software, like deleting from a file browser is not a big deal? the solution is to not be able to delete from the file browser. really?

virtualy 99% of file browsing in any software allows you to delete files, AND have them go to the recycle bin.

"not from blender". begs to ask, just why?

i get that actual work has to be done, but don't toss this issue aside like it's not a feature virtualy 99% of software is capable of, and people are used to.

it's actually very useful to me at the moment to delete files without having to go between blender and the system!

so removing basic abilities, that people are used to having in software, like deleting from a file browser is not a big deal? the solution is to not be able to delete from the file browser. really? virtualy 99% of file browsing in any software allows you to delete files, AND have them go to the recycle bin. "not from blender". begs to ask, just why? i get that actual work has to be done, but don't toss this issue aside like it's not a feature virtualy 99% of software is capable of, and people are used to. it's actually very useful to me at the moment to delete files without having to go between blender and the system!

Robert Guetzkow commented

2019-11-04 23:16:25 +01:00

@blender_mac The patch is already committed and the feature will be available in 2.81.