Startup crash in versioning for some users after bc3139d792 Eevee DOF Unification #64775

New Issue

Gavin Scott · 2019-05-17T21:56:29+02:00

Gavin Scott commented

2019-05-17 21:56:29 +02:00

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.17

Blender Version
Broken: version: 2.80 (sub 69), branch: master (modified), commit date: 2019-05-17 17:00, hash: be5fd9c09f
Worked: Reportedly builds prior to current buildbot.

Short description of error
Blender crashes on startup in versioning code.

Reported by two people in https://blender.chat/channel/support and I reproduced it here using the supplied .blend

User supplied startup.blend: https://dropbox.com/s/z5hovcne4ue2gfq/startup.blend?dl=0

Exact steps for others to reproduce the error
Using this user-supplied startup.blend will result in a crash on startup. You can simply try opening the file as a normal .blend and it will also crash, so you don't need to put it in place as the actual startup file.

Abort location below. The scene data structure does not look valid and the cam_ob->type reference faults.

    /* Unify DOF settings (EEVEE part only) */
    if (!DNA_struct_elem_find(fd->filesdna, "Camera", "CameraDOFSettings", "dof")) {
      const int SCE_EEVEE_DOF_ENABLED = (1 << 7);
      LISTBASE_FOREACH (Scene *, scene, &bmain->scenes) {
        if (STREQ(scene->r.engine, RE_engine_id_BLENDER_EEVEE)) {
          if (scene->eevee.flag & SCE_EEVEE_DOF_ENABLED) {
            Object *cam_ob = scene->camera;
-->         if (cam_ob && cam_ob->type == OB_CAMERA) {
              Camera *cam = cam_ob->data;
              cam->dof.flag |= CAM_DOF_ENABLED;
            }
          }
        }
      }

Likely related to: https://developer.blender.org/rBbc3139d79226896cf6c2b0813a1188eda70fad09

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.17 **Blender Version** Broken: version: 2.80 (sub 69), branch: master (modified), commit date: 2019-05-17 17:00, hash: `be5fd9c09f` Worked: Reportedly builds prior to current buildbot. **Short description of error** Blender crashes on startup in versioning code. Reported by two people in https://blender.chat/channel/support and I reproduced it here using the supplied .blend User supplied startup.blend: https://dropbox.com/s/z5hovcne4ue2gfq/startup.blend?dl=0 **Exact steps for others to reproduce the error** Using this user-supplied startup.blend will result in a crash on startup. You can simply try opening the file as a normal .blend and it will also crash, so you don't need to put it in place as the actual startup file. Abort location below. The scene data structure does not look valid and the cam_ob->type reference faults. ``` /* Unify DOF settings (EEVEE part only) */ if (!DNA_struct_elem_find(fd->filesdna, "Camera", "CameraDOFSettings", "dof")) { const int SCE_EEVEE_DOF_ENABLED = (1 << 7); LISTBASE_FOREACH (Scene *, scene, &bmain->scenes) { if (STREQ(scene->r.engine, RE_engine_id_BLENDER_EEVEE)) { if (scene->eevee.flag & SCE_EEVEE_DOF_ENABLED) { Object *cam_ob = scene->camera; --> if (cam_ob && cam_ob->type == OB_CAMERA) { Camera *cam = cam_ob->data; cam->dof.flag |= CAM_DOF_ENABLED; } } } } ``` Likely related to: https://developer.blender.org/rBbc3139d79226896cf6c2b0813a1188eda70fad09

Gavin Scott commented

2019-05-17 21:56:29 +02:00

Added subscriber: @GavinScott

Vaughan Ling commented

2019-05-17 22:03:43 +02:00

Added subscriber: @heavypoly

Vaughan Ling commented

2019-05-17 22:03:43 +02:00

Not sure if this matters, the submitted startup.blend camera properties use

bpy.context.object.data.dof_gpu.fstop (I think)
bpy.context.object.data.dof_gpu.blades
bpy.context.object.data.dof_gpu.focus_distance

vs the new properties:

bpy.context.object.data.dof.aperture_fstop
bpy.context.object.data.dof.aperture_blades
bpy.context.object.data.dof.focus_distance

Not sure if this matters, the submitted startup.blend camera properties use bpy.context.object.data.dof_gpu.fstop (I think) bpy.context.object.data.dof_gpu.blades bpy.context.object.data.dof_gpu.focus_distance vs the new properties: bpy.context.object.data.dof.aperture_fstop bpy.context.object.data.dof.aperture_blades bpy.context.object.data.dof.focus_distance

Brecht Van Lommel commented

2019-05-17 22:27:16 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-05-17 22:27:16 +02:00

The link to the startup.blend is dead? I have an idea what might be causing it though.

blender-admin commented

2019-05-17 22:28:49 +02:00

This issue was referenced by 728d99f446

This issue was referenced by 728d99f44683c78bffa5be8b109bb05f99828617

Vaughan Ling commented

2019-05-17 22:43:36 +02:00

In #64775#681693, @brecht wrote:
The link to the startup.blend is dead? I have an idea what might be causing it though.

Sorry, here it is: https://www.dropbox.com/s/e3x6h5h3awicaig/startup.blend?dl=0

> In #64775#681693, @brecht wrote: > The link to the startup.blend is dead? I have an idea what might be causing it though. Sorry, here it is: https://www.dropbox.com/s/e3x6h5h3awicaig/startup.blend?dl=0

Ray molenkamp commented

2019-05-17 22:45:54 +02:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2019-05-17 22:45:54 +02:00

For future reference, when you have files, you can just drag them into the text area and they will be uploaded and attached to the bug report, no need to host them on other sites.