Particle Edit mode for non hair particles - 2 Crashes #64843

New Issue

Michael P. · 2019-05-19T18:13:46+02:00

Michael P. commented

2019-05-19 18:13:46 +02:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 760/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.65

Blender Version
Broken: version: 2.80 (sub 69), branch: blender2.7, commit date: 2019-05-17 23:36, hash: 03672e7783
Worked: (optional)

Short description of error
Particle Edit: 2 Crashes

Exact steps for others to reproduce the error
Particle Edit: 2 Crashes

Open the blender file and click on the buttons "Particle select and display point"
Crash 1 (Screenshot)
Open the blender file and click on the tool "Weight" and click into the particles
Crash 2 (Screenshot)
Also had a crash with "Puff"
file not included
There are some tools that do nothing while others work
User gets no feedback / error message but give no feedback

2019-05-19-particle-edit-crash.blend

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: GeForce GTX 760/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.65 **Blender Version** Broken: version: 2.80 (sub 69), branch: blender2.7, commit date: 2019-05-17 23:36, hash: `03672e7783` Worked: (optional) **Short description of error** Particle Edit: 2 Crashes **Exact steps for others to reproduce the error** Particle Edit: 2 Crashes - Open the blender file and click on the buttons "Particle select and display point" - Crash 1 (Screenshot) - Open the blender file and click on the tool "Weight" and click into the particles - Crash 2 (Screenshot) - Also had a crash with "Puff" - file not included - There are some tools that do nothing while others work - User gets no feedback / error message but give no feedback ![2019-05-19-particle-edit-crashes.png](https://archive.blender.org/developer/F7049145/2019-05-19-particle-edit-crashes.png) [2019-05-19-particle-edit-crash.blend](https://archive.blender.org/developer/F7049147/2019-05-19-particle-edit-crash.blend)

Michael P. commented

2019-05-19 18:13:46 +02:00

Added subscriber: @MichaelParucha

Marco commented

2019-05-19 19:30:38 +02:00

Added subscriber: @nacioss

Marco commented

2019-05-19 19:30:38 +02:00

I confirm all the crashes

Philipp Oeser commented

2019-05-20 09:54:30 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-05-20 09:54:30 +02:00

Confirmed, checking...

Philipp Oeser commented

2019-05-20 11:25:08 +02:00

Added subscribers: @Sergey, @brecht

Philipp Oeser commented

2019-05-20 11:25:08 +02:00

some notes:
I think Puff, Cut and Add are just for hair [not for editing emmiter paths]?
Weight is not really for emmiter paths either (but can be used to tweak softbodies)

Maybe we can hide the brushes/tools (if they are not appropriate)?

crashes:

(1) happens when point->totkey is zero (checking for that in particle_batch_cache_ensure_edit_tip_pos and in ensure_edit_inner_points_count do nothing instead of assert helps), I assume these are unborn/died particles?
(2) Weight brush needs particle->hair (but doesnt check for it... see particle_key_weight)
I can do Diffs for both...
btw. edit point / tip drawing doesnt seem to be implemented yet?
btw. cloth editing seems to work (but misses edit paths drawing)?
btw. softbody editing seems to work (but misses edit paths drawing)?

Since this seems to be a mixed bag of issues, already subscribing @Sergey and @brecht here: shall I do the Diffs (and also look into the editpoint drawing / editpath missing implementations?)
Is this a high prio for 2.80?

some notes: I think `Puff`, `Cut` and `Add` are just for hair [not for editing emmiter paths]? `Weight` is not really for emmiter paths either (but can be used to tweak softbodies) Maybe we can hide the brushes/tools (if they are not appropriate)? crashes: - (1) happens when `point->totkey` is zero (checking for that in `particle_batch_cache_ensure_edit_tip_pos` and in `ensure_edit_inner_points_count` do nothing instead of assert helps), I assume these are unborn/died particles? - (2) `Weight` brush needs particle->hair (but doesnt check for it... see `particle_key_weight`) I can do Diffs for both... - btw. edit point / tip drawing doesnt seem to be implemented yet? - btw. cloth editing seems to work (but misses edit paths drawing)? - btw. softbody editing seems to work (but misses edit paths drawing)? Since this seems to be a mixed bag of issues, already subscribing @Sergey and @brecht here: shall I do the Diffs (and also look into the editpoint drawing / editpath missing implementations?) Is this a high prio for 2.80?

Philipp Oeser commented

2019-05-20 11:42:38 +02:00

EDIT: corrected previous comment about softbody editing (seems to work indeed -- still paths drawing is missing...)

Brecht Van Lommel commented

2019-05-21 18:45:09 +02:00

Not super high priority, but still would be good to fix for 2.80.

Michael P. commented

2019-07-06 13:48:53 +02:00

What is the status here? Will it be fixed for 2.80? Thanks.

Michael P. commented

2019-07-24 17:14:42 +02:00

Can report that the Crash 2 is fixed (doesn't occur because there is no functionality), but Crash 1 is still valid.
Because this ticket is not assigned to anyone, I assigned it to @brecht (I know I'm not allowed to do this...)

Tested with blender-2.80.0-git.5f140e61c28c

Can report that the Crash 2 is fixed (doesn't occur because there is no functionality), but Crash 1 is still valid. Because this ticket is not assigned to anyone, I assigned it to @brecht (I know I'm not allowed to do this...) Tested with blender-2.80.0-git.5f140e61c28c

Brecht Van Lommel was assigned by Michael P.

2019-07-24 17:15:15 +02:00

Brecht Van Lommel removed their assignment 2019-07-24 17:19:32 +02:00

Brecht Van Lommel commented

2019-07-24 17:19:32 +02:00

Thanks, but we'll assign reports ourselves.

Michael P. commented

2019-07-24 17:41:01 +02:00

I know.

Philipp Oeser changed title from ~~Particle Edit: 2 Crashes~~ to Emitter (non-hair) Particle Edit mode: 2 Crashes

2019-09-04 13:23:24 +02:00

Philipp Oeser commented

2019-09-04 20:43:44 +02:00

(1) already asserts earlier now:
BLI_assert failed: /blender/draw/intern/draw_cache_impl_particles.c:1519, particle_batch_cache_ensure_edit_pos_and_seg(), at '!"Hairs are not in edit mode!"'
(Just dropping this here because I have seen in reports elsewhere - hopefully this will make it easier to track down the issue...)

(1) already asserts earlier now: `BLI_assert failed: /blender/draw/intern/draw_cache_impl_particles.c:1519, particle_batch_cache_ensure_edit_pos_and_seg(), at '!"Hairs are not in edit mode!"'` (Just dropping this here because I have seen in reports elsewhere - hopefully this will make it easier to track down the issue...)

Philipp Oeser changed title from ~~Emitter (non-hair) Particle Edit mode: 2 Crashes~~ to Particle Edit mode for non hair particles - 2 Crashes

2021-01-18 09:58:24 +01:00

Philipp Oeser commented

2021-01-18 10:00:52 +01:00

Setting to Known Issue since old particles are EOL

Marco commented

2021-03-02 11:48:42 +01:00

Removed subscriber: @nacioss

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Particle Edit mode for non hair particles - 2 Crashes #64843