Grease Pencil Box & Lasso Select Tool do not work in Sculpt Mode #65108

Closed
opened 2019-05-25 10:19:17 +02:00 by Joanna · 14 comments

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 399.01

Blender Version
Broken: version: 2.80 (sub 72), branch: master, commit date: 2019-05-24 18:32, hash: a629c74c9c
Worked: (optional)

Short description of error

Grease Pencil Sculpt Mode - Select Tool - Box & Lasso do not work.

Exact steps for others to reproduce the error

Draw something
Go to Sculpt mode - selection will occur with single or circle select but not box or lasso select in the Select Tool.

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 399.01 **Blender Version** Broken: version: 2.80 (sub 72), branch: master, commit date: 2019-05-24 18:32, hash: `a629c74c9c` Worked: (optional) **Short description of error** Grease Pencil Sculpt Mode - Select Tool - Box & Lasso do not work. **Exact steps for others to reproduce the error** Draw something Go to Sculpt mode - selection will occur with single or circle select but not box or lasso select in the Select Tool.
Author

Added subscriber: @c.e.r.e.s

Added subscriber: @c.e.r.e.s

Added subscribers: @lichtwerk, @ideasman42, @antoniov

Added subscribers: @lichtwerk, @ideasman42, @antoniov

@lichtwerk IIRC there is already a task opened to this assigned to @ideasman42

@lichtwerk IIRC there is already a task opened to this assigned to @ideasman42
Campbell Barton was assigned by Antonio Vazquez 2019-05-25 10:52:49 +02:00

@ideasman42 Could you take a look? I was looking at the toolbar definition and I was unable to find why the toolbar is not working here.

I assign to you, if you think I need change something more, reassign to me.

@ideasman42 Could you take a look? I was looking at the toolbar definition and I was unable to find why the toolbar is not working here. I assign to you, if you think I need change something more, reassign to me.

I have tested and pressing B works, but the toolbar doesn't.

I have tested and pressing B works, but the toolbar doesn't.

Added subscriber: @AbidMaqbool

Added subscriber: @AbidMaqbool
Campbell Barton was unassigned by Abid Maqbool 2019-05-30 04:22:42 +02:00
Abid Maqbool self-assigned this 2019-05-30 04:22:42 +02:00

I see the code. I think the problem is in these events

("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS'},
 {"properties": [("wait_for_input", False)]}),
("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True},
 {"properties": [("wait_for_input", False)]}),
("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True},
  {"properties": [("wait_for_input", False)]}),

If I comment them, box selection and lesso selection works. I 'am deeply study the functions.

image.png

the problem is that's these are same short-cuts that's are for box-selection / lesso-selection which over ride the short-cuts for selection. I re-arrange the position of
e.g. km_grease_pencil_stroke_sculpt_mode() & km_3d_view_tool_sculpt_gpencil_select_box() it's not solved

I see the code. I think the problem is in these events ``` ("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS'}, {"properties": [("wait_for_input", False)]}), ("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True}, {"properties": [("wait_for_input", False)]}), ("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True}, {"properties": [("wait_for_input", False)]}), ``` If I comment them, box selection and lesso selection works. I 'am deeply study the functions. ![image.png](https://archive.blender.org/developer/F7079025/image.png) the problem is that's these are same short-cuts that's are for box-selection / lesso-selection which over ride the short-cuts for selection. I re-arrange the position of e.g. `km_grease_pencil_stroke_sculpt_mode()` & `km_3d_view_tool_sculpt_gpencil_select_box()` it's not solved

@AbidMaqbool You cannot remove the gpencil.sculpt_paint keys... did you try to replace the shortcut for lasso and box selection?

@AbidMaqbool You cannot remove the gpencil.sculpt_paint keys... did you try to replace the shortcut for lasso and box selection?

@antoniov Yes! I do not remove that's keys. I only tell the prob look like there. e.g means the keys over ride. i am looking forward..

@antoniov Yes! I do not remove that's keys. I only tell the prob look like there. e.g means the keys over ride. i am looking forward..

Actually problem I think is that, when there is some drawing in sculpt mode then box-select & lasso-select not works, rather it's perform last brush operation (under select tool in tool-bar).

If there is no drawing it works.

Select Operation Fails in Sculpt Mode Grease Pencil.gif

Actually problem I think is that, when there is some drawing in sculpt mode then box-select & lasso-select not works, rather it's perform last brush operation (under select tool in tool-bar). If there is no drawing it works. ![Select Operation Fails in Sculpt Mode Grease Pencil.gif](https://archive.blender.org/developer/F7080976/Select_Operation_Fails_in_Sculpt_Mode_Grease_Pencil.gif)
Abid Maqbool removed their assignment 2019-06-01 06:21:50 +02:00
Campbell Barton was assigned by Abid Maqbool 2019-06-01 06:21:50 +02:00

I have checked thoroughly, where any possibility could fix the bug. But it's a little but a complex.

I hope you have now enough info to fix the prob.

I have checked thoroughly, where any possibility could fix the bug. But it's a little but a complex. I hope you have now enough info to fix the prob.

The prob, I think is in these methods in blender_default file:

in km_grease_pencil_stroke_sculpt_mode(params) ->

("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS'},
 {"properties": [("wait_for_input", False)]}),
("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True},
 {"properties": [("wait_for_input", False)]}),
("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True},
 {"properties": [("wait_for_input", False)]}),

These are some how preventing box-selection and lasso-selection to be executed (but only if already stroke is exists)

Note: the selection are are currently executing in sculpt mode are:

km_3d_view_tool_edit_gpencil_select(params),
km_3d_view_tool_edit_gpencil_select_box(params),
km_3d_view_tool_edit_gpencil_select_circle(params),
km_3d_view_tool_edit_gpencil_select_lasso(params),

Just a dome:

Selection Not Working Grease Pencil.gif

The prob, I think is in these methods in `blender_default` file: in `km_grease_pencil_stroke_sculpt_mode(params)` -> ``` ("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS'}, {"properties": [("wait_for_input", False)]}), ("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True}, {"properties": [("wait_for_input", False)]}), ("gpencil.sculpt_paint", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True}, {"properties": [("wait_for_input", False)]}), ``` These are some how preventing box-selection and lasso-selection to be executed (but only if already stroke is exists) **Note:** the selection are are currently executing in sculpt mode are: ``` km_3d_view_tool_edit_gpencil_select(params), km_3d_view_tool_edit_gpencil_select_box(params), km_3d_view_tool_edit_gpencil_select_circle(params), km_3d_view_tool_edit_gpencil_select_lasso(params), ``` Just a dome: ![Selection Not Working Grease Pencil.gif](https://archive.blender.org/developer/F7081779/Selection_Not_Working_Grease_Pencil.gif)

This issue was referenced by b69ed14ff7

This issue was referenced by b69ed14ff745820d104dcf410c6fa64c841712c6

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#65108
No description provided.