Brush adjustment cancel action is hardcoded #65387

New Issue

Ludvik Koutny · 2019-06-01T12:16:43+02:00

Ludvik Koutny commented

2019-06-01 12:16:43 +02:00

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.64

Blender Version
Broken: version: 2.80 (sub 72), branch: blender2.7, commit date: 2019-05-28 21:07, hash: 9bae9b634e
Worked: Probably never

Short description of error
Brush adjustment cancel operator is hardcoded, not adjustable in Keymap editor. This results in big issues when someone wants to assign for example brush radius adjustment to any key combination which involves right mouse button, as RMB release is hardcoded to be cancel. Therefore for example assigning brush radius control to Alt+RMB results into the adjustment being discarded on release, instead of applied. This is very inconsistent as for example Alt+LMB or Alt+MMB work fine.

Exact steps for others to reproduce the error
1, Assign Image Editor brush Radial Control operator to Shift+RMB
2, In Image Editor paint mode, use Shift+RMB to adjust brush size
3, Notice that upon RMB release, the adjustment is discarded instead of applied.

Result: Brush control modal map is hardcoded to have RMB as cancel operator.

Expected: Brush control modal map parameters are exposed in keymap editors, like it is the case with all other modal maps (Gestures, Transforms, Eyedropper etc...)

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.64 **Blender Version** Broken: version: 2.80 (sub 72), branch: blender2.7, commit date: 2019-05-28 21:07, hash: `9bae9b634e` Worked: Probably never **Short description of error** Brush adjustment cancel operator is hardcoded, not adjustable in Keymap editor. This results in big issues when someone wants to assign for example brush radius adjustment to any key combination which involves right mouse button, as RMB release is hardcoded to be cancel. Therefore for example assigning brush radius control to Alt+RMB results into the adjustment being discarded on release, instead of applied. This is very inconsistent as for example Alt+LMB or Alt+MMB work fine. **Exact steps for others to reproduce the error** 1, Assign Image Editor brush Radial Control operator to Shift+RMB 2, In Image Editor paint mode, use Shift+RMB to adjust brush size 3, Notice that upon RMB release, the adjustment is discarded instead of applied. Result: Brush control modal map is hardcoded to have RMB as cancel operator. Expected: Brush control modal map parameters are exposed in keymap editors, like it is the case with all other modal maps (Gestures, Transforms, Eyedropper etc...)

Ludvik Koutny commented

2019-06-01 12:16:43 +02:00

Added subscriber: @Rawalanche

Campbell Barton was assigned by Sebastian Parborg

2019-06-13 15:45:17 +02:00

Brecht Van Lommel commented

2019-07-03 18:21:26 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-07-03 18:21:26 +02:00

Changed status from 'Open' to: 'Archived'

Brecht Van Lommel closed this issue

2019-07-03 18:21:26 +02:00

Brecht Van Lommel commented

2019-07-03 18:21:26 +02:00

Lack of customizability in the keymap is not considered a bug, but a feature request.

Ludvik Koutny commented

2019-07-04 10:25:46 +02:00

In #65387#712411, @brecht wrote:
Lack of customizability in the keymap is not considered a bug, but a feature request.

So assigning for example Shift+LMB to brush radius control and having the mouse button release confirm the radius adjustment while assigning Shift+RMB cancels the radius adjustment is behavior that is not considered buggy, despite there being absolutely no implication of this "limitation"?

Inconsistent, unexpected behavior without any warning or indication should fall within a bug category.

Maybe the report was worded poorly, and correct name should be "Brush radius operator does not work when assigned to any RMB keymap combination"

> In #65387#712411, @brecht wrote: > Lack of customizability in the keymap is not considered a bug, but a feature request. So assigning for example Shift+LMB to brush radius control and having the mouse button release confirm the radius adjustment while assigning Shift+RMB cancels the radius adjustment is behavior that is not considered buggy, despite there being absolutely no implication of this "limitation"? Inconsistent, unexpected behavior without any warning or indication should fall within a bug category. Maybe the report was worded poorly, and correct name should be "Brush radius operator does not work when assigned to any RMB keymap combination"

george b commented

2019-11-24 14:12:41 +01:00

Added subscriber: @GeRo

Guillaume Tjeka commented

2019-12-14 15:01:41 +01:00

Added subscriber: @apprenti90

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Brush adjustment cancel action is hardcoded #65387