Checkboxes alignment tweaks #65965
Closed
opened 2019-06-20 18:47:05 +02:00 by William Reynish
·
35 comments
No Branch/Tag Specified
main
blender-v3.6-release
universal-scene-description
temp-sculpt-dyntopo
blender-v3.3-release
asset-browser-frontend-split
brush-assets-project
asset-shelf
anim/armature-drawing-refactor-3
temp-sculpt-dyntopo-hive-alloc
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-projects-basics
blender-v2.93-release
temp-sculpt-attr-api
realtime-clock
sculpt-dev
gpencil-next
bevelv2
microfacet_hair
xr-dev
principled-v2
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels
This issue affects/is about backward or forward compatibility
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Apply labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
This issue affects/is about backward or forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
16 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#65965
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Alignment
For the Properties in Blender 2.8, we moved to a more simple and structured approach for the lists of buttons and controls, which aim to be aligned around a center-line.
However, checkmark toggles currently do not follow this alignment principle:
There are many cases where it would make sense to align the checkboxes along this center line.
Take this before & after example from the Sequencer :
{F7370312, size=full}
The 'Cache' text on the left side represents a heading, and is used as a visual anchor to guide the eye down the list.
Here are some more before/after examples:
Checkmark + value
In addition, there are many cases where we have configurations where we have a checkmark followed by a value. Currently, we tend to use sub-panels to show this nested relationship:
It works, and communicates the hierarchy, but can often be simplified like so:
{F7370734, size=full}
Currently there's no good way to do this while ensuring proper alignment with other items. A built-in way to do the above would help in many cases where all we need is a simple checkbox+value arrangement.
Other examples:
Implications
Different alignments have different tradeoffs. The center-line alignment here has the advantage that it's more aligned with other properties, and is easier to scan. It also adds overall more consistency because the checkbox is then to the left of the text.
The downside is that there can be some scenarios where there is less space for the text strings, although it is mitigated by adding header text on the left side, as with the above examples.
This may prompt us to want to change the split %. Currently it's 50/50 but could become 40/60 for eg.
Added subscribers: @WilliamReynish, @BartekMoniewski, @LucianoMunoz, @DuarteRamos, @zebus3dream, @A.Lex_3D, @CharlieJolly, @schweppie, @Hexbob6, @freemind, @PierreSchiller, @SteffenD, @remotecrab131, @Thane5, @orvb, @brezdo, @iss, @0o00o0oo, @ideasman42, @RamiroCantu, @Regnas
Added subscriber: @Blendify
With, Checkmark + value it looks a bit awkward when using number buttons (like in the example below) should the text in the bottom be shift left slightly to be alingned with the other numbers?
Added subscriber: @AlbertoVelazquez
I want to remember this proposal in RCS with a lot of community support
https://blender.community/c/rightclickselect/Jkcbbc/
This is what we had originally, to try this out, comment
UI_PROP_SEP_ICON_WIDTH_EXCEPTION
ininterface_layout.c
.Maybe I'm wrong. But commenting
define UI_PROP_SEP_ICON_WIDTH_EXCEPTION
I only obtain that checkbox move to the center. But the proposal is about text left aligned (an old request from community) basically, and a few changes in the checkbox to make it better.
Added subscriber: @Harley
Just for completeness, my own (unpopular) opinion on this checkbox alignment issue is to treat checkboxes more like other items. Think of them like toggle buttons we already use all over. Or consider them like sliders with only two positions. The alignment issue goes away, they become all more consistent, and the hit area is much larger:
Added subscriber: @ThinkingPolygons
@Harley To me it looks more like a color slot property. lol

It DOES. LOL. I was too lazy to add what it probably needs, which is an "unchecked checkmark" in the middle of it.
The problem with that is that user lost a good reference point in the menus that is the difference between controls and checkbox. If all that basic shapes are the same user only can identify things with the text. So muscle memory have a hard work with that.
I certainly agree in a way. But then you could use the same argument to say that the difference in alignment also helps as a reference point. I personally don't need difference in appearance for reference points since each grouping we have is quite small in a section. But that might just be a preference.
Added subscriber: @merlinstail
Just to throw my tequila into the punchbowl, a variation on harley's proposal
3rd time lucky
I'm really fine with the center aligned checkboxes proposal in the task description. The ´heading' text to the left and the description to the right really improve readability with minor downsides; but if we are going with any "wider" solution that's meant to make checkboxes as wide as other UI buttons and sliders, than I'd go with some sort of iOS style toggle buttons, that could stretch to fill the same width without looking too out of place.
Something along the lines of this GIF:

I still think it would be a step back compared to a simple center aligned checkbox.
This comment was removed by @merlinstail
Added subscriber: @SecuoyaEx
The checkmark + value proposal esentially puts two things in one row, going against the new philosophy for animated properties. What would the keyframe icon on the right do, would it animate the checkmark or the value? Center alignment looks good otherwise, and addressing excesive nesting is something that could be tackled in the future in another design task.
@SecuoyaEx it would show the state for the value, which you are more likely to want to animate.
You can still animate any property of course, if you really want to.
I realized I had split these, thought I would update with all controls shown for contrast
Added subscriber: @vademenev
Overall this is great. One small issue that needs to be addressed imho. Placement of checkboxes that are not related to a group might suggest they belong to them.
I think rows of grouped items should be aligned, maybe separators would help too.
@BartekMoniewski
You are right. A little bit of spacing helps here:

I will add this spacer here once this is committed to master.
This issue was referenced by
219049bb3b
This issue was referenced by blender/cycles@849cf27664
This issue was referenced by
7fc60bff14
Added subscriber: @JulianEisel
Changed status from 'Confirmed' to: 'Resolved'
All changes explained in the task description should be addressed with
219049bb3b
and7fc60bff14
.I'm personally quite happy about the result, it seems like a great improvement. The UI team members involved agreed that this design is the way forward, at least for now.
Added subscriber: @unimbox
@WilliamReynish wrote:
I just wanna add my two cents here.

When i took a first look at the checkbox columns i immediately assumed that on the left-hand side is a main category and on the-right hand side are subcategories. Seems logical to me. You have the word "Show" on the left and then everything you wanna show is on the right. Since "Render Region" is a separate category of itself, why not just to align the text on the left-hand side?
Like this:
Removed subscriber: @Thane5
Removed subscriber: @brezdo