Node Editor: Node Actions not started from the mouse are directly confirmed #66146

New Issue

Jeroen Bakker · 2019-06-26T10:35:09+02:00

Jeroen Bakker commented

2019-06-26 10:35:09 +02:00

System Information
Operating system: Linux-4.15.0-52-generic-x86_64-with-Ubuntu-18.04-bionic 64 Bits
Graphics card: AMD Radeon (TM) Pro WX 7100 Graphics ATI Technologies Inc. 4.5.13542 Core Profile Context FireGL 18.50.1.418

Blender Version
Broken: version: 2.80 (sub 74), branch: Unknown, commit date: Unknown Unknown, hash: rBUnknown
Worked: (optional)

Short description of error
When performing actions on mouse from a keyboard ('G' or 'Shift-D' for example), the actions are confirmed directly. I was able to reproduce this issue in any node editor. (Shader, Compositor etc)

Exact steps for others to reproduce the error

Open a node editor
Select a node
Perform an action starting from a key stroke (Shift-D for example)

The node is duplicated but depending on actual type of node the node might be placed exactly on top of the previous node. I would expect that the user could move the node around and confirm it by himself.

**System Information** Operating system: Linux-4.15.0-52-generic-x86_64-with-Ubuntu-18.04-bionic 64 Bits Graphics card: AMD Radeon (TM) Pro WX 7100 Graphics ATI Technologies Inc. 4.5.13542 Core Profile Context FireGL 18.50.1.418 **Blender Version** Broken: version: 2.80 (sub 74), branch: Unknown, commit date: Unknown Unknown, hash: `rBUnknown` Worked: (optional) **Short description of error** When performing actions on mouse from a keyboard ('G' or 'Shift-D' for example), the actions are confirmed directly. I was able to reproduce this issue in any node editor. (Shader, Compositor etc) **Exact steps for others to reproduce the error** 1. Open a node editor 2. Select a node 3. Perform an action starting from a key stroke (`Shift-D` for example) The node is duplicated but depending on actual type of node the node might be placed exactly on top of the previous node. I would expect that the user could move the node around and confirm it by himself.

blender-admin commented

2019-06-26 10:35:09 +02:00

#66160 was marked as duplicate of this issue

Jeroen Bakker commented

2019-06-26 10:35:10 +02:00

Added subscriber: @Jeroen-Bakker

Sebastian Koenig commented

2019-06-26 10:54:17 +02:00

Added subscriber: @sebastian_k

Sebastian Koenig commented

2019-06-26 10:54:17 +02:00

This is rather new though. Pretty sure it didn't confirm until 1 or 2 days ago.

Jeroen Bakker changed title from ~~Node Editor: Duplicate Nodes Automatically Confirms Action~~ to Node Editor: Node Actions not started from the mouse are directly confirmed

2019-06-26 11:22:15 +02:00

Jeroen Bakker commented

2019-06-26 11:25:30 +02:00

Seems to be introduced by 30bf48c9ca

Seems to be introduced by 30bf48c9ca

Sebastian Parborg was assigned by Brecht Van Lommel

2019-06-26 11:39:22 +02:00

Sebastian Parborg commented

2019-06-26 16:00:28 +02:00

The issue here is that the key map ships with "Confirm on Release" for the g shortcuts in the node editor. However, for the node.translate_attach binding, this setting isn't visible and no options can be changed from this operator...
So besides just having messed up default keybindings that came to light after my fix, we also have a bug with shortcuts.

The issue here is that the key map ships with "Confirm on Release" for the `g` shortcuts in the node editor. However, for the `node.translate_attach` binding, this setting isn't visible and no options can be changed from this operator... So besides just having messed up default keybindings that came to light after my fix, we also have a bug with shortcuts.

Sebastian Parborg commented

2019-06-26 17:01:05 +02:00

I've posted a fix here: D5139

I've posted a fix here: [D5139](https://archive.blender.org/developer/D5139)

Sebastian Parborg commented

2019-06-26 18:00:28 +02:00

Changed status from 'Open' to: 'Resolved'

Sebastian Parborg closed this issue

2019-06-26 18:00:28 +02:00

Sebastian Parborg commented

2019-06-27 09:15:35 +02:00

Added subscribers: @BartekMoniewski, @ZedDB