Keyframes and drivers on custom nodes properties seem not working #66392

New Issue

System Information
Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel(R) Iris(TM) Graphics 540 Intel Inc. 4.1 INTEL-12.4.7

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-02 22:33, hash: 50ccbe6bb2
Worked: (optional)

Short description of error
I'm not able to animate the properties of custom nodes. Keyframes do not work properly: when I set one all the others seem to disappear and only the last value set as a keyframe is shown on every time step.

Exact steps for others to reproduce the error

Go to the text editor, import the 'Custom Nodes' template and run the script.
Open the 'Custom Node Tree' area.
Add a 'Custom Node', in the 'Some Nodes' category.
Add a keyframe for 'my_float_prop' on frame 1.
Change the frame, change 'my_float_prop' value and set a keyframe.
Now I should see (at least it was like this in the last version) the property changing while scrolling through the timeline between the two keyframes I just set, but I don't. The property keeps the last value.

**System Information** Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits Graphics card: Intel(R) Iris(TM) Graphics 540 Intel Inc. 4.1 INTEL-12.4.7 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-02 22:33, hash: `50ccbe6bb2` Worked: (optional) **Short description of error** I'm not able to animate the properties of custom nodes. Keyframes do not work properly: when I set one all the others seem to disappear and only the last value set as a keyframe is shown on every time step. **Exact steps for others to reproduce the error** 1. Go to the text editor, import the 'Custom Nodes' template and run the script. 2. Open the 'Custom Node Tree' area. 3. Add a 'Custom Node', in the 'Some Nodes' category. 4. Add a keyframe for 'my_float_prop' on frame 1. 5. Change the frame, change 'my_float_prop' value and set a keyframe. 6. Now I should see (at least it was like this in the last version) the property changing while scrolling through the timeline between the two keyframes I just set, but I don't. The property keeps the last value.

Added subscriber: @lorenzocelli

#78383 was marked as duplicate of this issue

#74050 was marked as duplicate of this issue

Added subscriber: @lichtwerk

Confirmed.

note: #63793, #63548 might be related...

Confirmed. note: #63793, #63548 might be related...

Added subscriber: @Sparazza

Added subscribers: @JacquesLucke, @TuomoKeskitalo

I found out that this bug (keyframing property values is not working for custom nodes) seem to exist also in Animation Nodes on Blender 2.80, FYI @JacquesLucke

Hmm, it looks like the animated f-curve evaluates correctly in python console via D.node_groups['NodeTree'].animation_data.action.fcurves- [x].evaluate() even though value shown in node is not updated.

@lorenzocelli can you please test: is the animated value actually changing correctly, even though value is not shown updated on the node?

Hmm, it looks like the animated f-curve evaluates correctly in python console via D.node_groups['NodeTree'].animation_data.action.fcurves- [x].evaluate() even though value shown in node is not updated. @lorenzocelli can you please test: is the animated value actually changing correctly, even though value is not shown updated on the node?

This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out.
For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead.

Should still be fixed though... Not sure if there is already another bug report for this.

This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out. For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead. Should still be fixed though... Not sure if there is already another bug report for this.

@TuomoKeskitalo I tested it and to me it seems that the properties don't update at all, not in the UI and not by accessing them via python. The last keyframe you set just becomes the value for all frames, ignoring the other keyframes you set before

It looks like this goes down to somewhere in depsgraph/animation sources of Blender. Beyond my skills, so I hope someone more experienced can help. At least the F-curve is there apparently OK. Thanks @lorenzocelli for confirmation.

Anything new? Maybe I'm missing another similar bug report

Hello everybody! Any news?

Added subscriber: @dr.sybren

In #66392#749929, @JacquesLucke wrote:
This is a fairly well known limitation.

In that case I'll change this task from a Bug to a To Do, and put it in the appropriate work board. It would be nice to lift such a limitation at some point, but that probably would require doing some proper design work.

> In #66392#749929, @JacquesLucke wrote: > This is a fairly well known limitation. In that case I'll change this task from a Bug to a To Do, and put it in the appropriate work board. It would be nice to lift such a limitation at some point, but that probably would require doing some proper design work.

Added subscriber: @RyanSouthall

Most of my addon's interface is in the form of nodes with their own properties, so I would very much like to see this capability reimplemented.

Added subscriber: @roquito17

Added subscriber: @AhmedKamal

Added subscriber: @endrju555

In #66392#749929, @JacquesLucke wrote:
This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out.
For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead.

Should still be fixed though... Not sure if there is already another bug report for this.

Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers

> In #66392#749929, @JacquesLucke wrote: > This is a fairly well known limitation. I'm not sure what is needed to make it work, but we should be able to figure that out. > For animation nodes, I usually advice people to not keyframe their nodes but create controller objects in the 3d view instead. > > Should still be fixed though... Not sure if there is already another bug report for this. Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers

In #66392#900690, @endrju555 wrote:
Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers

This is a bug tracker, not a support forum. Please visit https://animation-nodes.com/ for info about Animation Nodes.

> In #66392#900690, @endrju555 wrote: > Hello! Can you tell more about this controllers setup? I can't find informations about how to set it up. I mean in Animation Nodes, because in Node Editor it works when I use drivers This is a bug tracker, not a support forum. Please visit https://animation-nodes.com/ for info about Animation Nodes.

Added subscriber: @ichlubna

Yes this is quite an annoying problem. I solved it by using bpy.app.handlers.frame_change_pre but...
EDIT: Seems like I just was able to call update but not to get the actual correct value from the property :-(.
EDIT2: Weird, in compositor for example I can see the good result but not when rendering even when using bpy.app.handlers.render_pre. Seems like when changing frame like when clicking or pressing arrow key the animated value is working but not during render. Is it related to #63548?

Yes this is quite an annoying problem. I solved it by using **bpy.app.handlers.frame_change_pre** but... EDIT: Seems like I just was able to call update but not to get the actual correct value from the property :-(. EDIT2: Weird, in compositor for example I can see the good result but not when rendering even when using bpy.app.handlers.render_pre. Seems like when changing frame like when clicking or pressing arrow key the animated value is working but not during render. Is it related to #63548?

Added subscriber: @matt.dougan

Added subscriber: @rpopovici

Added subscriber: @JerahmyPocott

Added subscriber: @Zeastin

Added subscriber: @TravisOBrien

Added subscriber: @Dval

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Keyframes and drivers on custom nodes properties seem not working #66392