CRASH Eyedropper operator crash blender #66524

New Issue

Jordi · 2019-07-07T13:14:09+02:00

Jordi commented

2019-07-07 13:14:09 +02:00

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.81

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-05 16:36, hash: 699193713f
Worked: (optional)

Short description of error
Eyedropper operator from brush menu, when gradient is activated, crash blender

Exact steps for others to reproduce the error
See attached file.
Just go to texture paint, with an object with a texture ready to be painted, and open the brush popover on tool settings.
Then activate the gradient mode, and on the color ramp settings, open the little down arrow dropdown and select the eyedropper operator, then blender crash.
Texture_Paint_Gradient_Fill_Eyedropper_Bug.blend

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.81 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-05 16:36, hash: `699193713f` Worked: (optional) **Short description of error** Eyedropper operator from brush menu, when gradient is activated, crash blender **Exact steps for others to reproduce the error** See attached file. Just go to texture paint, with an object with a texture ready to be painted, and open the brush popover on tool settings. Then activate the gradient mode, and on the color ramp settings, open the little down arrow dropdown and select the eyedropper operator, then blender crash. [Texture_Paint_Gradient_Fill_Eyedropper_Bug.blend](https://archive.blender.org/developer/F7571416/Texture_Paint_Gradient_Fill_Eyedropper_Bug.blend)

Jordi commented

2019-07-07 13:14:09 +02:00

Added subscriber: @JVM

Philipp Oeser commented

2019-07-08 09:37:00 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-07-08 09:37:00 +02:00

Confirmed, checking...

Campbell Barton was assigned by Philipp Oeser

2019-07-08 10:41:21 +02:00

Philipp Oeser commented

2019-07-08 10:41:21 +02:00

Added subscriber: @ideasman42

Philipp Oeser commented

2019-07-08 10:41:21 +02:00

Seems like ui_context_button_active cant get a button from a menu in a popover.
Same is true if you do this from the panel in the View3D sidebar.
The region uiblocks is just empty in that case.

Seems like this was being addressed in b749e43cd3 [added ctx pointer to color_ramp to work around the button not being available] but this fix seems incomplete?

code in eyedropper_colorband_init still needs the button to do:

eye->ptr = ((Colorband_RNAUpdateCb *)but->func_argN)->ptr;
eye->prop = ((Colorband_RNAUpdateCb *)but->func_argN)->prop;
eye->is_undo = UI_but_flag_is_set(but, UI_BUT_UNDO);

@ideasman42: mind checking?

Seems like `ui_context_button_active` cant get a button from a menu in a popover. Same is true if you do this from the panel in the View3D sidebar. The region uiblocks is just empty in that case. Seems like this was being addressed in b749e43cd3 [added ctx pointer to `color_ramp` to work around the button not being available] but this fix seems incomplete? code in `eyedropper_colorband_init` still needs the button to do: ``` eye->ptr = ((Colorband_RNAUpdateCb *)but->func_argN)->ptr; eye->prop = ((Colorband_RNAUpdateCb *)but->func_argN)->prop; eye->is_undo = UI_but_flag_is_set(but, UI_BUT_UNDO); ``` @ideasman42: mind checking?

blender-admin commented

2019-07-08 12:39:27 +02:00

This issue was referenced by 90dae36213

This issue was referenced by 90dae36213316b338cbe6b31c41c746ee7a69b8e

Campbell Barton commented

2019-07-08 12:42:21 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2019-07-08 12:42:21 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

CRASH Eyedropper operator crash blender #66524