Status bar indicates wrong information after cancelling a render #66916

New Issue

Julien Enche · 2019-07-14T14:54:58+02:00

Julien Enche commented

2019-07-14 14:54:58 +02:00

System Information
Operating system: Fedora 30

Blender Version
Broken: (example: 2.80 Release Candidate

Short description of error
Status bar shows wrong information after cancelling a render.

Exact steps for others to reproduce the error
Load a blend file (one of those linked here : https://www.blender.org/download/releases/2-80). The status bar indicates "Shaders Compilation" and the current progress.
Start a render, then cancel it.
Now, the status bar indicates "Cancelling..." instead of "Shaders Compilation" when you load another blend file.

**System Information** Operating system: Fedora 30 **Blender Version** Broken: (example: 2.80 Release Candidate **Short description of error** Status bar shows wrong information after cancelling a render. **Exact steps for others to reproduce the error** Load a blend file (one of those linked here : https://www.blender.org/download/releases/2-80). The status bar indicates "Shaders Compilation" and the current progress. Start a render, then cancel it. Now, the status bar indicates "Cancelling..." instead of "Shaders Compilation" when you load another blend file.

Julien Enche commented

2019-07-14 14:54:58 +02:00

Added subscriber: @JulienEnche

Gavin Scott commented

2019-07-14 15:18:47 +02:00

Added subscriber: @GavinScott

Gavin Scott commented

2019-07-14 15:18:48 +02:00

Confirmed on Windows. Opening a new .blend does not reset it and it will show "Cancelling..." while doing the shader compilation for the newly opened file.

Germano Cavalcante commented

2019-07-15 17:26:55 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-07-15 17:26:55 +02:00

Cycles or Eevee?
Which scene did you use to test?

Cycles or Eevee? Which scene did you use to test?

Julien Enche commented

2019-07-15 20:50:10 +02:00

I did test with Eevee.
The problem occurs with any scenes that can be downloaded from the link I provided in the bug report.
Please note that the problems also occurs when you cancel the shaders compilation and then load another scene, the status bar will then also indicates "Cancelling...".

I did test with Eevee. The problem occurs with any scenes that can be downloaded from the link I provided in the bug report. Please note that the problems also occurs when you cancel the shaders compilation and then load another scene, the status bar will then also indicates "Cancelling...".

Gavin Scott commented

2019-07-15 21:38:18 +02:00

I did it with the Tree Creature scene.

Clément Foucault was assigned by Germano Cavalcante

2019-07-16 13:16:12 +02:00

Germano Cavalcante commented

2019-07-16 13:16:12 +02:00

You don't need to render to test (just cancel when you see "Compiling Shaders" when opening the file).
G.is_break remains true between files.
Here is a solution:

diff --git a/source/blender/draw/intern/draw_manager_shader.c b/source/blender/draw/intern/draw_manager_shader.c
index d0aa6d55c03..3fe9e5beb07 100644
--- a/source/blender/draw/intern/draw_manager_shader.c
+++ b/source/blender/draw/intern/draw_manager_shader.c
@@ -236,6 +236,9 @@ static void drw_deferred_shader_add(GPUMaterial *mat, bool deferred)
   WM_jobs_timer(wm_job, 0.1, NC_MATERIAL | ND_SHADING_DRAW, 0);
   WM_jobs_delay_start(wm_job, 0.1);
   WM_jobs_callbacks(wm_job, drw_deferred_shader_compilation_exec, NULL, NULL, NULL);
+
+  G.is_break = false;
+
   WM_jobs_start(wm, wm_job);
 }

You don't need to render to test (just cancel when you see "Compiling Shaders" when opening the file). `G.is_break` remains true between files. Here is a solution: ``` diff --git a/source/blender/draw/intern/draw_manager_shader.c b/source/blender/draw/intern/draw_manager_shader.c index d0aa6d55c03..3fe9e5beb07 100644 --- a/source/blender/draw/intern/draw_manager_shader.c +++ b/source/blender/draw/intern/draw_manager_shader.c @@ -236,6 +236,9 @@ static void drw_deferred_shader_add(GPUMaterial *mat, bool deferred) WM_jobs_timer(wm_job, 0.1, NC_MATERIAL | ND_SHADING_DRAW, 0); WM_jobs_delay_start(wm_job, 0.1); WM_jobs_callbacks(wm_job, drw_deferred_shader_compilation_exec, NULL, NULL, NULL); + + G.is_break = false; + WM_jobs_start(wm, wm_job); } ```

Peter commented

2019-08-04 15:22:01 +02:00

Added subscriber: @peto2006

Clément Foucault was unassigned by Dalai Felinto

2019-12-23 16:33:44 +01:00

Dalai Felinto commented

2019-12-23 16:33:44 +01:00

Added subscriber: @fclem

blender-admin commented

2020-05-19 21:15:41 +02:00

This issue was referenced by 5201bc9dd4

This issue was referenced by 5201bc9dd4a764c3ea054a953aa17da23d8107d7

Clément Foucault commented

2020-05-19 21:26:31 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2020-05-19 21:26:31 +02:00

Clément Foucault self-assigned this 2020-05-19 21:26:31 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Status bar indicates wrong information after cancelling a render #66916