Sculpt mode: UNDO doesn't work for values in workspace / context window #67458

Closed
opened 2019-07-22 17:22:02 +02:00 by Christoph Werner · 14 comments

System Information
Operating system: Windows 10 Pro
Graphics card: GeForce GTX 1080Ti

Blender Version
Broken: Blender 2.8 RC2
Worked: (optional)

UNDO doesn't work for changing values in workspace area.

Exact steps for others to reproduce the error

  1. Create a UV sphere and select it.
  2. Activate Sculpt mode.
  3. Sculpt some strokes with draw brush e.g.
  4. Change the brush value in the workspace area manually.
  5. Use UNDO -> The value will not be reset to the last value.

UNDO doesn't work in sculpt mode for any value changes in the properties window.

blender_undo_sculptmode01.jpg

**System Information** Operating system: Windows 10 Pro Graphics card: GeForce GTX 1080Ti **Blender Version** Broken: Blender 2.8 RC2 Worked: (optional) UNDO doesn't work for changing values in workspace area. **Exact steps for others to reproduce the error** 1. Create a UV sphere and select it. 2. Activate Sculpt mode. 3. Sculpt some strokes with draw brush e.g. 4. Change the brush value in the workspace area manually. 5. Use UNDO -> The value will not be reset to the last value. UNDO doesn't work in sculpt mode for any value changes in the properties window. ![blender_undo_sculptmode01.jpg](https://archive.blender.org/developer/F7623206/blender_undo_sculptmode01.jpg)

Added subscriber: @ChristophWerner

Added subscriber: @ChristophWerner

#69793 was marked as duplicate of this issue

#69793 was marked as duplicate of this issue
Christoph Werner changed title from Sculpt mode: UNDO doesn't work in workspace / context window to Sculpt mode: UNDO doesn't work for values in workspace / context window 2019-07-22 17:22:46 +02:00

Added subscriber: @brecht

Added subscriber: @brecht

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Brecht Van Lommel self-assigned this 2019-07-22 17:41:01 +02:00

This is a known limitation of the current undo system, in sculpt mode only sculpting can be undone.

This is a known limitation of the current undo system, in sculpt mode only sculpting can be undone.

OK. But it's strange for the user.
Should be changed in the future.

Thank you

OK. But it's strange for the user. Should be changed in the future. Thank you

Added subscriber: @mjthehunter

Added subscriber: @mjthehunter

It's definitely an issue that should be looked at.
My workflow has been:
Change brush size > sculpt > undo

This both undoes the sculpting as well as the brush size change.
It might be a limitation of the current system, just want to bring some more attention to the bug.

It's definitely an issue that should be looked at. My workflow has been: Change brush size > sculpt > undo This both undoes the sculpting as well as the brush size change. It might be a limitation of the current system, just want to bring some more attention to the bug.

The same happens in weight painting mode. So in my opinion there should be definitely a higher attention to this problem.

Just for reminder.

Still existing in v2.81 master.

The same happens in weight painting mode. So in my opinion there should be definitely a higher attention to this problem. Just for reminder. Still existing in v2.81 master.

Added subscriber: @Voguart

Added subscriber: @Voguart

Yes all settings brush must not have an 'UNDO', that's what I think.

Yes all settings brush must not have an 'UNDO', that's what I think.

In #67458#831567, @Voguart wrote:
Yes all settings brush must not have an 'UNDO', that's what I think.

I know what you mean, but for the development this is not that easy as you think.
Basically we need always an undo, even when you set a value you need a way to undo the value.

The problem is in brush paint mode the user wants brush undos only, when painting or beeing "inside the viewport".
A way could be to create an undo system that is mouse cursor dependent. Depending of where the mouse cursor is, there the undo will do what you expect.

Examples:

  1. If the mouse pointer is inside the viewport area, the brush painting or whatever you've done there will be undone.
  2. If the mouse pointer is in a different area, like the sidebar, header or footer, then there the undo works. But this is tricky. Especially for the header inputs. The user moves the mouse automatically off the header e.g.

Not that easy....

> In #67458#831567, @Voguart wrote: > Yes all settings brush must not have an 'UNDO', that's what I think. I know what you mean, but for the development this is not that easy as you think. Basically we need always an undo, even when you set a value you need a way to undo the value. The problem is in brush paint mode the user wants brush undos only, when painting or beeing "inside the viewport". A way could be to create an undo system that is mouse cursor dependent. Depending of where the mouse cursor is, there the undo will do what you expect. Examples: 1. If the mouse pointer is inside the viewport area, the brush painting or whatever you've done there will be undone. 2. If the mouse pointer is in a different area, like the sidebar, header or footer, then there the undo works. But this is tricky. Especially for the header inputs. The user moves the mouse automatically off the header e.g. Not that easy....

Christoph Werner (Taros)

I understand that simple words or observations cannot write code or repair it and I am far from wanting to do it or pretend, I know that it is very delicate !!Now your example suits me perfectly.Maybe this problem will be resolved by 2020, of course I speak on behalf of the blender community.
thank you !!

Christoph Werner (Taros) I understand that simple words or observations cannot write code or repair it and I am far from wanting to do it or pretend, I know that it is very delicate !!Now your example suits me perfectly.Maybe this problem will be resolved by 2020, of course I speak on behalf of the blender community. thank you !!

Added subscriber: @Sonnh

Added subscriber: @Sonnh
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#67458
No description provided.