Crash when smoke type switch from Flow to Domain with Cycles viewport rendering #68359

New Issue

Kinouti Takahiro · 2019-08-07T12:18:21+02:00

Kinouti Takahiro commented

2019-08-07 12:18:21 +02:00

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: 67EF:CF ATI Technologies Inc. 4.5.13474 Core Profile Context 22.19.162.4

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f5449
Worked: (optional)

Short description of error
Crash when smoke type switch from Flow to Domain with Cycles viewport rendering.

Exact steps for others to reproduce the error

Use Cycles
Add Quick Smoke
Change Smoke Type to Flow
Swhitch viewport to Rendered
Change Smoke Type to Domain
Crash

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: 67EF:CF ATI Technologies Inc. 4.5.13474 Core Profile Context 22.19.162.4 **Blender Version** Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: `f6cb5f5449` Worked: (optional) **Short description of error** Crash when smoke type switch from Flow to Domain with Cycles viewport rendering. **Exact steps for others to reproduce the error** 1. Use Cycles 2. Add Quick Smoke 3. Change Smoke Type to Flow 4. Swhitch viewport to Rendered 5. Change Smoke Type to Domain 6. Crash

Kinouti Takahiro commented

2019-08-07 12:18:21 +02:00

Added subscriber: @dskjal-1

Philipp Oeser commented

2019-08-07 12:57:36 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-08-07 12:57:36 +02:00

Confirmed, checking...

Brecht Van Lommel was assigned by Philipp Oeser

2019-08-07 13:55:45 +02:00

Philipp Oeser commented

2019-08-07 13:55:45 +02:00

Setting smoke type already does rna_Modifier_dependency_update and thus DEG_relations_tag_update(bmain), so not sure if there is more to be done on the blender side...

Crash is in cycles BVH refitting, if the BVH is rebuilt instead, all is fine...

quick proof: following seems to work, but there is probably a more elegant way to do this (or a completely other solution alltogether)...
P1068: #68359 snippet



diff --git a/intern/cycles/blender/blender_mesh.cpp b/intern/cycles/blender/blender_mesh.cpp
index c672bc9f3e2..ae789aaa47c 100644
--- a/intern/cycles/blender/blender_mesh.cpp
+++ b/intern/cycles/blender/blender_mesh.cpp
@@ -1002,6 +1002,14 @@ Mesh *BlenderSync::sync_mesh(BL::Depsgraph &b_depsgraph,
   oldcurve_keys.steal_data(mesh->curve_keys);
   oldcurve_radius.steal_data(mesh->curve_radius);
 
+  /* ensure bvh rebuild if smoke type changed from flow to domain, not sure why... */
+  bool oldhas_voxel_attributes = false;
+  foreach (Attribute &attr, mesh->attributes.attributes) {
+    if (attr.element == ATTR_ELEMENT_VOXEL) {
+      oldhas_voxel_attributes = true;
+    }
+  }
+
   mesh->clear();
   mesh->used_shaders = used_shaders;
   mesh->name = ustring(b_ob_data.name().c_str());
@@ -1048,9 +1056,17 @@ Mesh *BlenderSync::sync_mesh(BL::Depsgraph &b_depsgraph,
   sync_mesh_fluid_motion(b_ob, scene, mesh);
 
   /* tag update */
+  bool has_voxel_attributes = false;
+  foreach (Attribute &attr, mesh->attributes.attributes) {
+    if (attr.element == ATTR_ELEMENT_VOXEL) {
+      has_voxel_attributes = true;
+    }
+  }
+
   bool rebuild = (oldtriangles != mesh->triangles) || (oldsubd_faces != mesh->subd_faces) ||
                  (oldsubd_face_corners != mesh->subd_face_corners) ||
-                 (oldcurve_keys != mesh->curve_keys) || (oldcurve_radius != mesh->curve_radius);
+                 (oldcurve_keys != mesh->curve_keys) || (oldcurve_radius != mesh->curve_radius) ||
+                 (oldhas_voxel_attributes != has_voxel_attributes);
 
   mesh->tag_update(scene, rebuild);

Setting smoke type already does `rna_Modifier_dependency_update` and thus `DEG_relations_tag_update(bmain)`, so not sure if there is more to be done on the blender side... Crash is in cycles BVH **refitting**, if the BVH is **rebuilt** instead, all is fine... quick proof: following seems to work, but there is probably a more elegant way to do this (or a completely other solution alltogether)... [P1068: #68359 snippet](https://archive.blender.org/developer/P1068.txt) ``` diff --git a/intern/cycles/blender/blender_mesh.cpp b/intern/cycles/blender/blender_mesh.cpp index c672bc9f3e2..ae789aaa47c 100644 --- a/intern/cycles/blender/blender_mesh.cpp +++ b/intern/cycles/blender/blender_mesh.cpp @@ -1002,6 +1002,14 @@ Mesh *BlenderSync::sync_mesh(BL::Depsgraph &b_depsgraph, oldcurve_keys.steal_data(mesh->curve_keys); oldcurve_radius.steal_data(mesh->curve_radius); + /* ensure bvh rebuild if smoke type changed from flow to domain, not sure why... */ + bool oldhas_voxel_attributes = false; + foreach (Attribute &attr, mesh->attributes.attributes) { + if (attr.element == ATTR_ELEMENT_VOXEL) { + oldhas_voxel_attributes = true; + } + } + mesh->clear(); mesh->used_shaders = used_shaders; mesh->name = ustring(b_ob_data.name().c_str()); @@ -1048,9 +1056,17 @@ Mesh *BlenderSync::sync_mesh(BL::Depsgraph &b_depsgraph, sync_mesh_fluid_motion(b_ob, scene, mesh); /* tag update */ + bool has_voxel_attributes = false; + foreach (Attribute &attr, mesh->attributes.attributes) { + if (attr.element == ATTR_ELEMENT_VOXEL) { + has_voxel_attributes = true; + } + } + bool rebuild = (oldtriangles != mesh->triangles) || (oldsubd_faces != mesh->subd_faces) || (oldsubd_face_corners != mesh->subd_face_corners) || - (oldcurve_keys != mesh->curve_keys) || (oldcurve_radius != mesh->curve_radius); + (oldcurve_keys != mesh->curve_keys) || (oldcurve_radius != mesh->curve_radius) || + (oldhas_voxel_attributes != has_voxel_attributes); mesh->tag_update(scene, rebuild); ```

Philipp Oeser commented

2019-08-14 10:37:33 +02:00

#58569 is the same thing really...