Boolean merges CustomData inconsistently (UVs, VCols), breaks UV Map Node #68732

New Issue

Sebastian Koenig · 2019-08-16T15:25:36+02:00

Sebastian Koenig commented

2019-08-16 15:25:36 +02:00

System Information
Operating system: Linux-5.0.0-25-generic-x86_64-with-Ubuntu-19.04-disco 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.34

Blender Version
Broken: version: 2.81 (sub 2), branch: master, commit date: 2019-08-16 08:35, hash: bdf8450713
Worked: (optional)

Short description of error
The UV Map of an object with Boolean Modifier doesn't work when the UV is assigned to the texture with the UV Map node.

Exact steps for others to reproduce the error
Open this file:
boolean_uv_map.blend
The UV layout of the bigger cube is not used. Once you unplug the custom UV Map node in the shader, the UV Map works again. It also works when you disable the Boolean Modifier.

**System Information** Operating system: Linux-5.0.0-25-generic-x86_64-with-Ubuntu-19.04-disco 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.34 **Blender Version** Broken: version: 2.81 (sub 2), branch: master, commit date: 2019-08-16 08:35, hash: `bdf8450713` Worked: (optional) **Short description of error** The UV Map of an object with Boolean Modifier doesn't work when the UV is assigned to the texture with the UV Map node. **Exact steps for others to reproduce the error** Open this file: [boolean_uv_map.blend](https://archive.blender.org/developer/F7667328/boolean_uv_map.blend) The UV layout of the bigger cube is not used. Once you unplug the custom UV Map node in the shader, the UV Map works again. It also works when you disable the Boolean Modifier.

Sebastian Koenig commented

2019-08-16 15:25:36 +02:00

Added subscriber: @sebastian_k

blender-admin commented

2019-08-16 15:25:36 +02:00

#72539 was marked as duplicate of this issue

Martin Capitanio commented

2019-08-16 18:56:14 +02:00

Added subscriber: @capnm

Martin Capitanio commented

2019-08-16 18:56:14 +02:00

This only works if you use the same uvmap name as the uvmap of the cutter object.
If you apply the boolean modifier, you can see that both uvmaps are merged into new one. The problem is that both, the old destroyed uvmap and the new one with the name of the cutter uvmap are preserved here.

The UV Map node node only reveals the bug:

This only works if you use the same uvmap name as the uvmap of the cutter object. If you apply the boolean modifier, you can see that both uvmaps are merged into new one. The problem is that both, the old destroyed uvmap and the new one with the name of the cutter uvmap are preserved here. ![image.png](https://archive.blender.org/developer/F7668772/image.png) The UV Map node node only reveals the bug: ![image.png](https://archive.blender.org/developer/F7668850/image.png)

Philipp Oeser commented

2019-08-28 22:12:28 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-08-28 22:12:28 +02:00

I also think the data should be merged into the layers of the source object (so the UVMap node would keep working).

For UVs, this seems to go the other way around, VCols are seemingly fine though?
Havent checked the exact logic of CustomData_bmesh_merge and friends ( CustomData_merge, CustomData_update_typemap), I think this could be improved (to the point that this feels like a bug)

We could just flip the order the order of BM_mesh_bm_from_me in the modifier like
P1088: #68732 snippet



diff --git a/source/blender/modifiers/intern/MOD_boolean.c b/source/blender/modifiers/intern/MOD_boolean.c
index ea42ddb03f4..53f112c3f78 100644
--- a/source/blender/modifiers/intern/MOD_boolean.c
+++ b/source/blender/modifiers/intern/MOD_boolean.c
@@ -189,7 +189,7 @@ static Mesh *applyModifier(ModifierData *md, const ModifierEvalContext *ctx, Mes
                           }));
 
       BM_mesh_bm_from_me(bm,
-                         mesh_other,
+                         mesh,
                          &((struct BMeshFromMeshParams){
                              .calc_face_normal = true,
                          }));
@@ -204,7 +204,7 @@ static Mesh *applyModifier(ModifierData *md, const ModifierEvalContext *ctx, Mes
       }
 
       BM_mesh_bm_from_me(bm,
-                         mesh,
+                         mesh_other,
                          &((struct BMeshFromMeshParams){
                              .calc_face_normal = true,
                          }));

But this then flips the VCols...
So real solution is probably in smarter way of handling CustomData merging (as mentioned above)

I also think the data should be merged into the layers of the source object (so the UVMap node would keep working). For UVs, this seems to go the other way around, VCols are seemingly fine though? Havent checked the exact logic of `CustomData_bmesh_merge` and friends ( `CustomData_merge`, `CustomData_update_typemap`), I think this could be improved (to the point that this feels like a bug) We could just flip the order the order of BM_mesh_bm_from_me in the modifier like [P1088: #68732 snippet](https://archive.blender.org/developer/P1088.txt) ``` diff --git a/source/blender/modifiers/intern/MOD_boolean.c b/source/blender/modifiers/intern/MOD_boolean.c index ea42ddb03f4..53f112c3f78 100644 --- a/source/blender/modifiers/intern/MOD_boolean.c +++ b/source/blender/modifiers/intern/MOD_boolean.c @@ -189,7 +189,7 @@ static Mesh *applyModifier(ModifierData *md, const ModifierEvalContext *ctx, Mes })); BM_mesh_bm_from_me(bm, - mesh_other, + mesh, &((struct BMeshFromMeshParams){ .calc_face_normal = true, })); @@ -204,7 +204,7 @@ static Mesh *applyModifier(ModifierData *md, const ModifierEvalContext *ctx, Mes } BM_mesh_bm_from_me(bm, - mesh, + mesh_other, &((struct BMeshFromMeshParams){ .calc_face_normal = true, })); ``` But this then flips the VCols... So real solution is probably in smarter way of handling CustomData merging (as mentioned above)

Philipp Oeser changed title from ~~UV layout doesn't work with Boolean and UV Map Node~~ to Boolean merges CustomData inconsistently (UVs, VCols), breaks UV Map Node

2019-08-28 22:14:18 +02:00

Germano Cavalcante commented

2019-12-20 15:53:39 +01:00

Added subscribers: @crantisz, @lateasusual