"Match Texture Space" Causes blender to crash (also doesnt evaluate right when curve geo changes) #68779

New Issue

Likkez · 2019-08-17T20:12:07+02:00

Likkez commented

2019-08-17 20:12:07 +02:00

System Information
Operating system: Linux-5.0.12-050012-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.40

Blender Version
Broken: version: 2.81 (sub 2), branch: master, commit date: 2019-08-16 13:02, hash: 078d02f557
Worked: (optional)

Short description of error
Blender instantly closes after clicking 'Match texture space' button on bezier curve object

Exact steps for others to reproduce the error

Add bezier curve
Go to Object Data tab and open Texture Space submenu
Click Match Texture Space button.

**System Information** Operating system: Linux-5.0.12-050012-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.40 **Blender Version** Broken: version: 2.81 (sub 2), branch: master, commit date: 2019-08-16 13:02, hash: `078d02f557` Worked: (optional) **Short description of error** Blender instantly closes after clicking 'Match texture space' button on bezier curve object **Exact steps for others to reproduce the error** 1. Add bezier curve 2. Go to Object Data tab and open Texture Space submenu 3. Click Match Texture Space button.

Likkez commented

2019-08-17 20:12:07 +02:00

Added subscriber: @Likkez-2

Philipp Oeser commented

2019-08-19 10:30:10 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-08-19 10:30:10 +02:00

Can confirm this, checking...

Philipp Oeser commented

2019-08-19 12:14:05 +02:00

Added subscribers: @mont29, @Sergey

Philipp Oeser commented

2019-08-19 12:14:05 +02:00

Caused by 3566b81c8b.
Even though we ensure an evaluated depsgraph in match_texture_space_exec, the object->runtime.curve_cache is NULL...

If I substitute the Assert in https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/curve/editcurve.c$7111

with

  if (object->runtime.curve_cache == NULL) {
    Scene *scene = CTX_data_scene(C);
    BKE_displist_make_curveTypes(depsgraph, scene, object, false, false);
  }

Then I dont get a crash, but still the runtime curve cache doesnt seem to be updated/invalidated at all (if I change a defaults bezier curve Depth e.g., shouldnt I get a different result if I do Match Texture Space then? -- it is always the same, no matter how much the bounding box actually changes...)

I guess @Sergey or @mont29 would know?

Caused by 3566b81c8b. Even though we ensure an evaluated depsgraph in `match_texture_space_exec`, the `object->runtime.curve_cache` is NULL... If I substitute the Assert in https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/curve/editcurve.c$7111 with ``` if (object->runtime.curve_cache == NULL) { Scene *scene = CTX_data_scene(C); BKE_displist_make_curveTypes(depsgraph, scene, object, false, false); } ``` Then I dont get a crash, but still the runtime curve cache doesnt seem to be updated/invalidated at all (if I change a defaults bezier curve Depth e.g., shouldnt I get a different result if I do `Match Texture Space` then? -- it is always the same, no matter how much the bounding box actually changes...) I guess @Sergey or @mont29 would know?

Philipp Oeser changed title from ~~"Match Texture Space" Causes blender to crash~~ to "Match Texture Space" Causes blender to crash (also doesnt evaluate right when curve geo changes)

2019-08-19 12:14:42 +02:00

Sergey Sharybin commented

2019-08-19 12:53:06 +02:00

@lichtwerk, you need to access runtime.curve_cache from evaluated object, and write new texture space based on the min/max values calculated from it to original curve.

There is also missing dependency graph recalc tag on the curve at the end of that operator.

@lichtwerk, you need to access `runtime.curve_cache` from evaluated object, and write new texture space based on the min/max values calculated from it to original curve. There is also missing dependency graph recalc tag on the curve at the end of that operator.

blender-admin commented

2019-08-19 13:49:42 +02:00

This issue was referenced by 5615c675af

This issue was referenced by 5615c675afedf68261562d6d944b808a64ace8fe

Philipp Oeser commented

2019-08-19 14:37:51 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-08-19 14:37:51 +02:00

Philipp Oeser self-assigned this 2019-08-19 14:37:51 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

"Match Texture Space" Causes blender to crash (also doesnt evaluate right when curve geo changes) #68779